Commit a7a42ffc authored by Francois Doray's avatar Francois Doray Committed by Commit Bot

[blink scheduler] Configure WakeUpBudgetPool with wake up interval.

This CL changes SetWakeUpRate(double wake_ups_per_second) to
SetWakeInterval(base::TimeDelta interval) to avoid conversions
between rate and interval.

This CL is a no-op.

Bug: 1075553
Change-Id: I1b72f6b56f364c24c73a14eb8f1c3aea8ca31bc3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219524Reviewed-by: default avatarAlexander Timin <altimin@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#773356}
parent 29c80a4c
......@@ -132,7 +132,7 @@ TEST_F(BudgetPoolTest, WakeUpBudgetPool) {
scheduler_->NewTimerTaskQueue(
MainThreadTaskQueue::QueueType::kFrameThrottleable, nullptr);
pool->SetWakeUpRate(0.1);
pool->SetWakeUpInterval(base::TimeDelta::FromSeconds(10));
pool->SetWakeUpDuration(base::TimeDelta::FromMilliseconds(10));
// Can't run tasks until a wake-up.
......
......@@ -1305,8 +1305,8 @@ TEST_F(TaskQueueThrottlerTest, WakeUpBasedThrottling_EnableDisableThrottling) {
constexpr base::TimeDelta kDelay = base::TimeDelta::FromSeconds(10);
constexpr base::TimeDelta kTimeBetweenWakeUps =
base::TimeDelta::FromMinutes(1);
scheduler_->GetWakeUpBudgetPoolForTesting()->SetWakeUpRate(
1.0 / kTimeBetweenWakeUps.InSeconds());
scheduler_->GetWakeUpBudgetPoolForTesting()->SetWakeUpInterval(
kTimeBetweenWakeUps);
scheduler_->GetWakeUpBudgetPoolForTesting()->SetWakeUpDuration(
base::TimeDelta::FromMilliseconds(1));
Vector<base::TimeTicks> run_times;
......
......@@ -18,7 +18,7 @@ WakeUpBudgetPool::WakeUpBudgetPool(const char* name,
BudgetPoolController* budget_pool_controller,
base::TimeTicks now)
: BudgetPool(name, budget_pool_controller),
wake_up_interval_(base::TimeDelta::FromSecondsD(1.0)) {}
wake_up_interval_(base::TimeDelta::FromSeconds(1)) {}
WakeUpBudgetPool::~WakeUpBudgetPool() = default;
......@@ -26,8 +26,8 @@ QueueBlockType WakeUpBudgetPool::GetBlockType() const {
return QueueBlockType::kNewTasksOnly;
}
void WakeUpBudgetPool::SetWakeUpRate(double wake_ups_per_second) {
wake_up_interval_ = base::TimeDelta::FromSecondsD(1 / wake_ups_per_second);
void WakeUpBudgetPool::SetWakeUpInterval(base::TimeDelta interval) {
wake_up_interval_ = interval;
}
void WakeUpBudgetPool::SetWakeUpDuration(base::TimeDelta duration) {
......
......@@ -24,7 +24,7 @@ class PLATFORM_EXPORT WakeUpBudgetPool : public BudgetPool {
// Note: this does not have an immediate effect and should be called only
// during initialization of a WakeUpBudgetPool.
void SetWakeUpRate(double wake_ups_per_second);
void SetWakeUpInterval(base::TimeDelta interval);
// Note: this does not have an immediate effect and should be called only
// during initialization of a WakeUpBudgetPool.
......
......@@ -2742,7 +2742,8 @@ void MainThreadSchedulerImpl::InitWakeUpBudgetPoolIfNeeded() {
main_thread_only().wake_up_budget_pool =
task_queue_throttler()->CreateWakeUpBudgetPool("renderer_wake_up_pool");
main_thread_only().wake_up_budget_pool->SetWakeUpRate(1);
main_thread_only().wake_up_budget_pool->SetWakeUpInterval(
base::TimeDelta::FromSeconds(1));
main_thread_only().wake_up_budget_pool->SetWakeUpDuration(
GetWakeUpDuration());
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment