[Autofill] Manage Cards button now links to Payments subpage instead of Autofill subpage.

This change fixes the Manage Cards button, in the Manage Cards prompt, to link to chrome://settings/payments instead of chrome://settings/autofill


bug: 855186
Change-Id: I3d274367deae5d04c7a3029db8e5eec3aa852cc1
Reviewed-on: https://chromium-review.googlesource.com/1163743
Commit-Queue: Manas Verma <manasverma@google.com>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581029}

chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc

@@ -57,18 +57,28 @@ namespace {
 // This list should be kept in sync with chrome/common/webui_url_constants.h.
 // Only include useful sub-pages, confirmation alerts are not useful.
 const char* const kChromeSettingsSubPages[] = {
-    chrome::kAutofillSubPage,        chrome::kClearBrowserDataSubPage,
-    chrome::kContentSettingsSubPage, chrome::kLanguageOptionsSubPage,
-    chrome::kPasswordManagerSubPage, chrome::kResetProfileSettingsSubPage,
-    chrome::kSearchEnginesSubPage,   chrome::kSyncSetupSubPage,
+    chrome::kAutofillSubPage,
+    chrome::kClearBrowserDataSubPage,
+    chrome::kContentSettingsSubPage,
+    chrome::kLanguageOptionsSubPage,
+    chrome::kPasswordManagerSubPage,
+    chrome::kPaymentsSubPage,
+    chrome::kResetProfileSettingsSubPage,
+    chrome::kSearchEnginesSubPage,
+    chrome::kSyncSetupSubPage,
 #if defined(OS_CHROMEOS)
-    chrome::kAccessibilitySubPage,   chrome::kBluetoothSubPage,
-    chrome::kDateTimeSubPage,        chrome::kDisplaySubPage,
-    chrome::kInternetSubPage,        chrome::kPowerSubPage,
+    chrome::kAccessibilitySubPage,
+    chrome::kBluetoothSubPage,
+    chrome::kDateTimeSubPage,
+    chrome::kDisplaySubPage,
+    chrome::kInternetSubPage,
+    chrome::kPowerSubPage,
     chrome::kStylusSubPage,
 #else
-    chrome::kCreateProfileSubPage,   chrome::kImportDataSubPage,
-    chrome::kManageProfileSubPage,   chrome::kPeopleSubPage,
+    chrome::kCreateProfileSubPage,
+    chrome::kImportDataSubPage,
+    chrome::kManageProfileSubPage,
+    chrome::kPeopleSubPage,
 #endif
 };
 #endif  // !defined(OS_ANDROID)

chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc

@@ -364,7 +364,7 @@ void SaveCardBubbleControllerImpl::OnManageCardsClicked() {
   // TODO(crbug/855186): Implement metrics for sign-in promo.
   chrome::ShowSettingsSubPage(
       chrome::FindBrowserWithWebContents(web_contents()),
-      chrome::kAutofillSubPage);
+      chrome::kPaymentsSubPage);
 }
 
 void SaveCardBubbleControllerImpl::OnBubbleClosed() {

chrome/common/webui_url_constants.cc

@@ -274,6 +274,7 @@ const char kHandlerSettingsSubPage[] = "handlers";
 const char kImportDataSubPage[] = "importData";
 const char kLanguageOptionsSubPage[] = "languages";
 const char kPasswordManagerSubPage[] = "passwords";
+const char kPaymentsSubPage[] = "payments";
 const char kPrintingSettingsSubPage[] = "printing";
 const char kResetProfileSettingsSubPage[] = "resetProfileSettings";
 const char kSearchEnginesSubPage[] = "searchEngines";

chrome/common/webui_url_constants.h

@@ -266,6 +266,7 @@ extern const char kImportDataSubPage[];
 extern const char kLanguageOptionsSubPage[];
 extern const char kManageProfileSubPage[];
 extern const char kPasswordManagerSubPage[];
+extern const char kPaymentsSubPage[];
 extern const char kPeopleSubPage[];
 extern const char kPrintingSettingsSubPage[];
 extern const char kResetProfileSettingsSubPage[];