Skip to content

GitLab

T
tangled
Commit a7fd06ba authored by eae@chromium.org's avatar eae@chromium.org
Browse files
Options

Fix fast/css tests for Win7/DirectWrite by explicitly setting height 

The height of text and form control can vary slightly depending on
alignment and baseline. Explicitly set height for CSS tests that do not
test nor depend on text rendering.

BUG=378610
R=dglazkov@chromium.org, eseidel@chromium.org

Review URL: https://codereview.chromium.org/323293002

git-svn-id: svn://svn.chromium.org/blink/trunk@176035 bbb929c8-8fbe-4397-9dbb-9b2b20218538
parent f016bb32
Hide whitespace changes
Inline Side-by-side
Showing with 7 additions and 2 deletions
third_party/WebKit/LayoutTests/TestExpectations
View file @ a7fd06ba
...@@ -419,8 +419,6 @@ crbug.com/377696 printing/width-overflow.html [ Skip ] ...@@ -419,8 +419,6 @@ crbug.com/377696 printing/width-overflow.html [ Skip ]
# Reftests that needs investigation. # Reftests that needs investigation.
crbug.com/378610 compositing/gestures/gesture-tapHighlight-pixel-transparent.html [ NeedsRebaseline ] crbug.com/378610 compositing/gestures/gesture-tapHighlight-pixel-transparent.html [ NeedsRebaseline ]
crbug.com/378610 [ Win7 ] css3/flexbox/auto-margins.html [ ImageOnlyFailure ] crbug.com/378610 [ Win7 ] css3/flexbox/auto-margins.html [ ImageOnlyFailure ]
crbug.com/378610 [ Win7 ] fast/css/font-face-unicode-range.html [ ImageOnlyFailure ]
crbug.com/378610 [ Win7 ] fast/css/negative-text-indent-in-inline-block.html [ ImageOnlyFailure ]
crbug.com/378610 [ Win7 ] fast/multicol/newmulticol/breaks-3-columns-3.html [ ImageOnlyFailure ] crbug.com/378610 [ Win7 ] fast/multicol/newmulticol/breaks-3-columns-3.html [ ImageOnlyFailure ]
crbug.com/378610 [ Win7 ] fast/selectors/selection-window-inactive.html [ ImageOnlyFailure ] crbug.com/378610 [ Win7 ] fast/selectors/selection-window-inactive.html [ ImageOnlyFailure ]
crbug.com/378610 [ Win7 ] fast/selectors/shadow-host-div-with-span.html [ ImageOnlyFailure ] crbug.com/378610 [ Win7 ] fast/selectors/shadow-host-div-with-span.html [ ImageOnlyFailure ]
......
third_party/WebKit/LayoutTests/fast/css/font-face-unicode-range-expected.html
View file @ a7fd06ba
...@@ -3,6 +3,7 @@ ...@@ -3,6 +3,7 @@
div { border: 1px solid; padding: 0 8px; margin: 8px 0; } div { border: 1px solid; padding: 0 8px; margin: 8px 0; }
span.ahem { font-family: 'Ahem'; } span.ahem { font-family: 'Ahem'; }
span.courier { font-family: 'Courier', 'Courier New'; } span.courier { font-family: 'Courier', 'Courier New'; }
p { height: 30px; }
</style> </style>
</head> </head>
<body> <body>
......
third_party/WebKit/LayoutTests/fast/css/font-face-unicode-range.html
View file @ a7fd06ba
...@@ -73,6 +73,10 @@ ...@@ -73,6 +73,10 @@
src: url('../../resources/Ahem.ttf'); src: url('../../resources/Ahem.ttf');
unicode-range: U+0027; /* missing glyph */ unicode-range: U+0027; /* missing glyph */
} }
p {
height: 30px;
}
</style> </style>
</head> </head>
<body onload="finished()"> <body onload="finished()">
......
third_party/WebKit/LayoutTests/fast/css/negative-text-indent-in-inline-block.html
View file @ a7fd06ba
...@@ -11,12 +11,14 @@ ...@@ -11,12 +11,14 @@
float: left; float: left;
margin-left: -20px; margin-left: -20px;
visibility: hidden; visibility: hidden;
height: 10px;
} }
#floatRTL { #floatRTL {
float: right; float: right;
margin-right: -20px; margin-right: -20px;
visibility: hidden; visibility: hidden;
height: 10px;
} }
#ltr > div { #ltr > div {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment