[PE] Invalidate <use> instances even when mutating from the parser

When a layout is triggered when the parser is interrupted, an instance tree can be built for a <use> that references a subtree that contains the insertion point of the parser. This <use> instance (or instances) would then not be invalidated when the parsing resumed. Invalidate instances of an element when its children changes even when the mutation originates from the parser. (This condition was added in 3c2310f2 without further explanation "Only invalidate SVGElementInstances when !changedByParser is set.". Due to the lazyness of the shadow tree/instance rebuilding this will hopefully not regress performance.) Bug: 794594 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I58f3a74ef9812503c0111d3564dad8ee3527d27b Reviewed-on: https://chromium-review.googlesource.com/832386Reviewed-by: Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#524726}

[PE] Invalidate <use> instances even when mutating from the parser
When a layout is triggered when the parser is interrupted, an instance tree can be built for a <use> that references a subtree that contains the insertion point of the parser. This <use> instance (or instances) would then not be invalidated when the parsing resumed. Invalidate instances of an element when its children changes even when the mutation originates from the parser. (This condition was added in 3c2310f2 without further explanation "Only invalidate SVGElementInstances when !changedByParser is set.". Due to the lazyness of the shadow tree/instance rebuilding this will hopefully not regress performance.) Bug: 794594 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I58f3a74ef9812503c0111d3564dad8ee3527d27b Reviewed-on: https://chromium-review.googlesource.com/832386Reviewed-by: Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#524726}
a8014bf1 · Fredrik Söderquist · Commit Bot · fd1fa7e7 · a8014bf1 · a8014bf1
Commit a8014bf1 authored Dec 18, 2017 by Fredrik Söderquist Committed by Commit Bot Dec 18, 2017
3 changed files
--- a/third_party/WebKit/LayoutTests/svg/custom/use-child-change-by-parser-expected.html
+++ b/third_party/WebKit/LayoutTests/svg/custom/use-child-change-by-parser-expected.html
+<!DOCTYPE html>
+<div style="width: 100px; height: 100px; background-color: green"></div>
--- a/third_party/WebKit/LayoutTests/svg/custom/use-child-change-by-parser.html
+++ b/third_party/WebKit/LayoutTests/svg/custom/use-child-change-by-parser.html
+<!DOCTYPE html>
+<svg>
+  <rect width="100" height="100" fill="red"/>
+  <use href="#foo"/>
+  <defs>
+    <g id="foo">
+      <rect width="50" height="100" fill="green"/>
+      <script>
+        // Force a layout so that the shadow tree is instantiated.
+      	document.documentElement.offsetTop;
+      </script>
+      <rect x="50" width="50" height="100" fill="green"/>
+    </g>
+  </defs>
+</svg>
--- a/third_party/WebKit/Source/core/svg/SVGElement.cpp
+++ b/third_party/WebKit/Source/core/svg/SVGElement.cpp
@@ -444,8 +444,7 @@ void SVGElement::ChildrenChanged(const ChildrenChange& change) {
  Element::ChildrenChanged(change);
  // Invalidate all instances associated with us.
-  if (!change.by_parser)
+  InvalidateInstances();
-    InvalidateInstances();
 }
 CSSPropertyID SVGElement::CssPropertyIdForSVGAttributeName(