Roll ./src/third_party/googletest/src/ 7f8fefabe..247a3d8e5 (59 commits)

https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/7f8fefabedf2..f1a87d73fc60

$ git log 7f8fefabe..247a3d8e5 --date=short --no-merges --format='%ad %ae %s'
2017-11-07 whame@users.noreply.github.com Fixes issue #826 by treating MinGW as "non-Windows" when determining colored output
2017-10-29 thielen@hs-worms.de remove markdown stars (bold) from code examples
2017-10-25 arkady.shapkin@gmail.com Enable CI for VS2017
2016-10-21 romain.geissler@gmail.com Remove gcc 6 misleading indentations.
2017-06-08 arkady.shapkin@gmail.com Fix gmock tests when std::unary_function unavailable
2017-05-03 arkady.shapkin@gmail.com Fix tests with VS2015 and VS2017
2017-05-03 arkady.shapkin@gmail.com Enable C++11 features for VS2015 and VS2017
2017-10-17 manojgupta@google.com googletest: Add GTEST_API_ attribute to ThreadLocal class.
2017-10-18 gennadiycivil@users.noreply.github.com Workaround for Travis issue https://goo.gl/d5eV8o
2017-10-18 gennadiycivil@users.noreply.github.com Revert "Workaround for Travis issue https://github.com/travis-ci/travis-ci/is…"
2017-10-18 gennadiycivil@users.noreply.github.com Workaround for Travis issue https://github.com/travis-ci/travis-ci/issues/8552
2017-10-14 dariusz.ostolski@gmail.com #1282: Doc typo fix
2017-10-07 joe@robotgoblin.co.uk Updated README with information about C runtime dynamic/static linking issues in Windows
2017-09-27 jwakely@redhat.com Use gender-neutral pronouns in comments and docs
2017-09-21 gennadiycivil@users.noreply.github.com Revert "Allow macros inside of parametrized test names."
2017-09-19 stkhapugin@chromium.org Swap reinterpret_cast for static_cast
2017-09-16 benjamin.kircher@gmail.com Remove redundant declaration
2017-09-14 31530391+ly2048@users.noreply.github.com Add explicit `CMAKE_DEBUG_POSTFIX` option
2017-09-01 sokolov@google.com Make the failure messages from EXPECT_EQ and friends actually symmetric,
2017-09-08 31780593+yursha@users.noreply.github.com Fix ellipsis position in examples
2017-09-07 thielen@hs-worms.de use GTEST_ATTRIBUTE_UNUSED_ instead of dummy function
2017-09-07 gaspardpetit@gmail.com Removed flush scopes around GTEST_LOG(FATAL) and exit call since FATAL is expected to abort()
2017-09-05 thielen@hs-worms.de remove unused variables from travis environment
2017-09-05 thielen@hs-worms.de drop unused valgrind package from installation
2017-09-05 thielen@hs-worms.de reset ccache statistics at install
2017-09-05 thielen@hs-worms.de show ccache statistics in log
2017-09-05 thielen@hs-worms.de call clang via ccache on Linux
2017-09-05 stkhapugin@google.com add a cast
2017-09-05 thielen@hs-worms.de remove obsolete link_directories command
2017-09-04 thielen@hs-worms.de limit processors to use in Travis build to 4
2017-09-04 thielen@hs-worms.de install ccache on travis osx build slave
2017-09-04 thielen@hs-worms.de set MAKEFLAGS to use multiple processors on Travis CI
2017-09-02 thielen@hs-worms.de cache ccache
2017-08-30 thielen@hs-worms.de avoid warning about unused variable
2017-09-04 thielen@hs-worms.de avoid -Wshadow warning on GCC
2016-02-10 bauerb@chromium.org Add a non-parametrized test.
2016-02-04 bauerb@chromium.org Allow macros inside of parametrized test names.
2017-08-30 thielen@hs-worms.de treat all warnings as errors for GCC (-Werror)
2017-08-30 thielen@hs-worms.de switch one build to Release mode
2016-12-30 lebedev.ri@gmail.com CMake: use threads if allowed and found, not just if found.
2017-08-31 thielen@hs-worms.de change links from former code.google.com to current github repository
2017-08-31 thielen@hs-worms.de fix example's comment
2016-09-05 arkady.shapkin@gmail.com AppVeyor MinGW-w64 test build
2017-08-30 thielen@hs-worms.de create different python based tests for single and multi configuration build generators
2017-08-30 thielen@hs-worms.de Revert "ask cmake for per-configuration output subdir"
2017-08-30 thielen@hs-worms.de ask cmake for per-configuration output subdir
2017-08-30 thielen@hs-worms.de remove obsolete comment regarding python tests on linux
2017-08-30 thielen@hs-worms.de use upper-case build type
2017-08-30 thielen@hs-worms.de use build type set in .travis.yml
2017-08-29 thielen@hs-worms.de remove non-existing gmock_build_samples switch
2017-05-09 thielen@hs-worms.de remove unused TestCase import
2017-08-14 gaspard.petit@eidosmontreal.com Removed extra colon in error log
2017-08-14 gaspard.petit@eidosmontreal.com Use GTEST_LOG instead of printf
2017-07-02 chehsunliu@gmail.com Update googletest README.md
2017-02-13 olivier.clavel@gmail.com googlemock version must be changed as well
2017-02-13 olivier.clavel@gmail.com Wrong version reported (1.7.0 should be 1.8.0)
2016-10-08 adriyetichaves@gmail.com Fix WhenSorted() documentation example
2016-08-30 claus.stovgaard@gmail.com Moved the ignoring of *.pyc files to top level for also covering googlemock python scripts.
2016-05-22 tobbi.bugs@googlemail.com Performance fixes reported by cppcheck

Created with:
  roll-dep ./src/third_party/googletest/src

Bug: 
Change-Id: I72edf5c1ec21f34aab852f661fec6a58bedbd365
Reviewed-on: https://chromium-review.googlesource.com/681214
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Asanka Herath <asanka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522087}

DEPS

@@ -377,7 +377,7 @@ deps = {
   },
 
   'src/third_party/googletest/src':
-    Var('chromium_git') + '/external/github.com/google/googletest.git' + '@' + '7f8fefabedf2965980585be8c2bff97458f28e0b',
+    Var('chromium_git') + '/external/github.com/google/googletest.git' + '@' + '247a3d8e5e5d403f7fcacdb8ccc71e5059f15daa',
 
   # GNU binutils assembler for x86-32.
   'src/third_party/gnu_binutils': {

net/socket/sequenced_socket_data_unittest.cc

@@ -671,8 +671,8 @@ TEST_F(SequencedSocketDataTest, SingleSyncWriteTooSmall) {
 
   static const char* kExpectedFailures[] = {
       "Expected: (data.length()) >= (expected_data.length())",
-      "To be equal to: actual_data",
-      "To be equal to: sock_->Write(buf.get(), len, failing_callback_)"};
+      "Expected equality of these values:\n  expected_data",
+      "Expected equality of these values:\n  rv"};
   ASSERT_EQ(arraysize(kExpectedFailures),
             static_cast<size_t>(gtest_failures.size()));