PlzNavigate: make ctrl+click works.

Opening a link in a new tab/window was broken with PlzNavigate.

This CL solves the majority of broken tests. There is still 3
browser_tests that doesn't work properly yet, but it seems to me this
is unrelated to click modifiers (ctrl/shift/meta+click).

Timeout:
    ReferrerPolicyTest.HttpLeftClickRedirectToHTTPOriginWhenCrossOrigin

Flaky fail:
    ClickModifierTest.WindowOpenControlShiftClickTest
    ClickModifierTest.WindowOpenBasicClickTest

BUG=644116

R=clamy@chromium.org

Review-Url: https://codereview.chromium.org/2323153003
Cr-Commit-Position: refs/heads/master@{#418990}

content/renderer/render_frame_impl.cc

@@ -5115,8 +5115,13 @@ WebNavigationPolicy RenderFrameImpl::decidePolicyForNavigation(
   if (IsBrowserSideNavigationEnabled() &&
       info.urlRequest.checkForBrowserSideNavigation() &&
       ShouldMakeNetworkRequestForURL(url)) {
-    BeginNavigation(info);
-    return blink::WebNavigationPolicyHandledByClient;
+    if (info.defaultPolicy == blink::WebNavigationPolicyCurrentTab) {
+      BeginNavigation(info);
+      return blink::WebNavigationPolicyHandledByClient;
+    } else {
+      LoadURLExternally(info.urlRequest, info.defaultPolicy);
+      return blink::WebNavigationPolicyIgnore;
+    }
   }
 
   return info.defaultPolicy;

testing/buildbot/filters/browser-side-navigation.linux.browser_tests.filter

@@ -184,10 +184,6 @@
 -PushMessaging*
 -RedirectTest.ClientServerServer
 -ReferrerPolicyTest.HttpLeftClickRedirectToHTTPOriginWhenCrossOrigin
--ReferrerPolicyTest.HttpsMiddleClickOrigin
--ReferrerPolicyTest.HttpsMiddleClickRedirect
--ReferrerPolicyTest.MiddleClickOrigin
--ReferrerPolicyTest.MiddleClickRedirect
 -RepostFormWarningTest.TestDoubleReload
 -RestartTest.Pos*
 -SafeBrowsing*

third_party/WebKit/LayoutTests/FlagExpectations/enable-browser-side-navigation

@@ -25,12 +25,6 @@
   plugins/iframe-plugin-bgcolor.html [ Crash ]
   plugins/plugin-document-back-forward.html [ Crash ]
 
-# Failing due to ctrl+click doesn't work on same site navigation.
-  editing/pasteboard/paste-when-over-link.html [ Failure ]
-  fast/events/isolated-worlds-override-keystate.html [ Failure ]
-  fast/events/main-world-does-not-override-keystate.html [ Failure ]
-  fast/events/simulated-click-on-anchor-with-target-blank.html [ Failure ]
-
 # https://crbug.com/608375: PlzNavigate: Appcache support
   http/tests/appcache/fallback.html [ Timeout ]
   http/tests/appcache/main-resource-hash.html [ Crash Timeout ]