Commit a83734ec authored by Chris Sharp's avatar Chris Sharp Committed by Commit Bot

Assert GetInterpolableValue is a length before attempting to cast it.

Instead of just expecting, which doesn't stop executing if it isn't.

TBR=xiaochengh@chromium.org

Bug: 1117509
Change-Id: I058f8fd69d8dbebad60b9625c6dfda112eb0b5db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363227Reviewed-by: default avatarChris Sharp <csharp@chromium.org>
Commit-Queue: Chris Sharp <csharp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799217}
parent a8e02752
......@@ -74,7 +74,7 @@ class AnimationKeyframeEffectModel : public PageTestBase {
->GetCachedValueForTesting();
// Length values are stored as an |InterpolableLength|; here we assume
// pixels.
EXPECT_TRUE(typed_value->GetInterpolableValue().IsLength());
ASSERT_TRUE(typed_value->GetInterpolableValue().IsLength());
const InterpolableLength& length =
To<InterpolableLength>(typed_value->GetInterpolableValue());
// Lengths are computed in logical units, which are quantized to 64ths of
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment