Commit a846ad7d authored by Sky Malice's avatar Sky Malice Committed by Commit Bot

Rename CHROME_SYNC_SERVICE to CHROME_SYNC_EVENT_LOGGER

Bug: 788004
Change-Id: I455ac63969e5ab52ef063fbd1b9ba14be833f211
Reviewed-on: https://chromium-review.googlesource.com/806653Reviewed-by: default avatarSteven Holte <holte@chromium.org>
Reviewed-by: default avatarPavel Yatsuk <pavely@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521555}
parent 35dc4286
...@@ -300,7 +300,7 @@ IN_PROC_BROWSER_TEST_F(SingleClientUserEventsSyncTest, FieldTrial) { ...@@ -300,7 +300,7 @@ IN_PROC_BROWSER_TEST_F(SingleClientUserEventsSyncTest, FieldTrial) {
const std::string group_name = "GroupName"; const std::string group_name = "GroupName";
ASSERT_TRUE(SetupSync()); ASSERT_TRUE(SetupSync());
variations::AssociateGoogleVariationID(variations::CHROME_SYNC_SERVICE, variations::AssociateGoogleVariationID(variations::CHROME_SYNC_EVENT_LOGGER,
trial_name, group_name, 123); trial_name, group_name, 123);
base::FieldTrialList::CreateFieldTrial(trial_name, group_name); base::FieldTrialList::CreateFieldTrial(trial_name, group_name);
base::FieldTrialList::FindFullName(trial_name); base::FieldTrialList::FindFullName(trial_name);
......
...@@ -37,7 +37,7 @@ base::TimeDelta GetFieldTrialDelay() { ...@@ -37,7 +37,7 @@ base::TimeDelta GetFieldTrialDelay() {
TrialRecorder::TrialRecorder(UserEventService* user_event_service) TrialRecorder::TrialRecorder(UserEventService* user_event_service)
: user_event_service_(user_event_service), : user_event_service_(user_event_service),
variations_(variations::CHROME_SYNC_SERVICE, variations_(variations::CHROME_SYNC_EVENT_LOGGER,
base::BindRepeating(&TrialRecorder::OnNewVariationId, base::BindRepeating(&TrialRecorder::OnNewVariationId,
base::Unretained(this))) { base::Unretained(this))) {
DCHECK(user_event_service_); DCHECK(user_event_service_);
......
...@@ -47,7 +47,7 @@ void VerifyEvent(std::set<variations::VariationID> expected_variations, ...@@ -47,7 +47,7 @@ void VerifyEvent(std::set<variations::VariationID> expected_variations,
void SetupAndFinalizeTrial(const std::string& trial_name, void SetupAndFinalizeTrial(const std::string& trial_name,
variations::VariationID id) { variations::VariationID id) {
variations::AssociateGoogleVariationID(variations::CHROME_SYNC_SERVICE, variations::AssociateGoogleVariationID(variations::CHROME_SYNC_EVENT_LOGGER,
trial_name, kGroup, id); trial_name, kGroup, id);
base::FieldTrialList::CreateFieldTrial(trial_name, kGroup); base::FieldTrialList::CreateFieldTrial(trial_name, kGroup);
base::FieldTrialList::FindFullName(trial_name); base::FieldTrialList::FindFullName(trial_name);
......
...@@ -214,7 +214,7 @@ TEST_F(UserEventServiceImplTest, SessionIdIsDifferent) { ...@@ -214,7 +214,7 @@ TEST_F(UserEventServiceImplTest, SessionIdIsDifferent) {
} }
TEST_F(UserEventServiceImplTest, FieldTrial) { TEST_F(UserEventServiceImplTest, FieldTrial) {
variations::AssociateGoogleVariationID(variations::CHROME_SYNC_SERVICE, variations::AssociateGoogleVariationID(variations::CHROME_SYNC_EVENT_LOGGER,
"trial", "group", 123); "trial", "group", 123);
base::FieldTrialList::CreateFieldTrial("trial", "group"); base::FieldTrialList::CreateFieldTrial("trial", "group");
base::FieldTrialList::FindFullName("trial"); base::FieldTrialList::FindFullName("trial");
......
...@@ -66,8 +66,8 @@ enum IDCollectionKey { ...@@ -66,8 +66,8 @@ enum IDCollectionKey {
// X-Client-Data header. // X-Client-Data header.
GOOGLE_WEB_PROPERTIES_TRIGGER, GOOGLE_WEB_PROPERTIES_TRIGGER,
// This collection is used by Chrome Sync services, transmitted through the // This collection is used by Chrome Sync services, transmitted through the
// Chrome Sync experiment labels. // Sync Event Logger.
CHROME_SYNC_SERVICE, CHROME_SYNC_EVENT_LOGGER,
// The total count of collections. // The total count of collections.
ID_COLLECTION_COUNT, ID_COLLECTION_COUNT,
}; };
......
...@@ -166,21 +166,21 @@ TEST_F(VariationsAssociatedDataTest, CollectionsCoexist) { ...@@ -166,21 +166,21 @@ TEST_F(VariationsAssociatedDataTest, CollectionsCoexist) {
EXPECT_EQ(EMPTY_ID, EXPECT_EQ(EMPTY_ID,
GetIDForTrial(GOOGLE_WEB_PROPERTIES_TRIGGER, trial_true.get())); GetIDForTrial(GOOGLE_WEB_PROPERTIES_TRIGGER, trial_true.get()));
EXPECT_EQ(EMPTY_ID, EXPECT_EQ(EMPTY_ID,
GetIDForTrial(CHROME_SYNC_SERVICE, trial_true.get())); GetIDForTrial(CHROME_SYNC_EVENT_LOGGER, trial_true.get()));
AssociateGoogleVariationID(GOOGLE_WEB_PROPERTIES, trial_true->trial_name(), AssociateGoogleVariationID(GOOGLE_WEB_PROPERTIES, trial_true->trial_name(),
default_name, TEST_VALUE_A); default_name, TEST_VALUE_A);
EXPECT_EQ(TEST_VALUE_A, EXPECT_EQ(TEST_VALUE_A,
GetIDForTrial(GOOGLE_WEB_PROPERTIES, trial_true.get())); GetIDForTrial(GOOGLE_WEB_PROPERTIES, trial_true.get()));
EXPECT_EQ(EMPTY_ID, EXPECT_EQ(EMPTY_ID,
GetIDForTrial(CHROME_SYNC_SERVICE, trial_true.get())); GetIDForTrial(CHROME_SYNC_EVENT_LOGGER, trial_true.get()));
AssociateGoogleVariationID(CHROME_SYNC_SERVICE, trial_true->trial_name(), AssociateGoogleVariationID(CHROME_SYNC_EVENT_LOGGER, trial_true->trial_name(),
default_name, TEST_VALUE_A); default_name, TEST_VALUE_A);
EXPECT_EQ(TEST_VALUE_A, EXPECT_EQ(TEST_VALUE_A,
GetIDForTrial(GOOGLE_WEB_PROPERTIES, trial_true.get())); GetIDForTrial(GOOGLE_WEB_PROPERTIES, trial_true.get()));
EXPECT_EQ(TEST_VALUE_A, EXPECT_EQ(TEST_VALUE_A,
GetIDForTrial(CHROME_SYNC_SERVICE, trial_true.get())); GetIDForTrial(CHROME_SYNC_EVENT_LOGGER, trial_true.get()));
trial_true = CreateFieldTrial("d2", 10, default_name, &default_group_number); trial_true = CreateFieldTrial("d2", 10, default_name, &default_group_number);
ASSERT_EQ(default_group_number, trial_true->group()); ASSERT_EQ(default_group_number, trial_true->group());
...@@ -192,14 +192,14 @@ TEST_F(VariationsAssociatedDataTest, CollectionsCoexist) { ...@@ -192,14 +192,14 @@ TEST_F(VariationsAssociatedDataTest, CollectionsCoexist) {
EXPECT_EQ(TEST_VALUE_A, EXPECT_EQ(TEST_VALUE_A,
GetIDForTrial(GOOGLE_WEB_PROPERTIES_TRIGGER, trial_true.get())); GetIDForTrial(GOOGLE_WEB_PROPERTIES_TRIGGER, trial_true.get()));
EXPECT_EQ(EMPTY_ID, EXPECT_EQ(EMPTY_ID,
GetIDForTrial(CHROME_SYNC_SERVICE, trial_true.get())); GetIDForTrial(CHROME_SYNC_EVENT_LOGGER, trial_true.get()));
AssociateGoogleVariationID(CHROME_SYNC_SERVICE, trial_true->trial_name(), AssociateGoogleVariationID(CHROME_SYNC_EVENT_LOGGER, trial_true->trial_name(),
default_name, TEST_VALUE_A); default_name, TEST_VALUE_A);
EXPECT_EQ(TEST_VALUE_A, EXPECT_EQ(TEST_VALUE_A,
GetIDForTrial(GOOGLE_WEB_PROPERTIES_TRIGGER, trial_true.get())); GetIDForTrial(GOOGLE_WEB_PROPERTIES_TRIGGER, trial_true.get()));
EXPECT_EQ(TEST_VALUE_A, EXPECT_EQ(TEST_VALUE_A,
GetIDForTrial(CHROME_SYNC_SERVICE, trial_true.get())); GetIDForTrial(CHROME_SYNC_EVENT_LOGGER, trial_true.get()));
} }
} // namespace variations } // namespace variations
...@@ -229,7 +229,7 @@ std::string VariationsHttpHeaderProvider::GenerateBase64EncodedProto( ...@@ -229,7 +229,7 @@ std::string VariationsHttpHeaderProvider::GenerateBase64EncodedProto(
case GOOGLE_WEB_PROPERTIES_TRIGGER: case GOOGLE_WEB_PROPERTIES_TRIGGER:
proto.add_trigger_variation_id(entry.first); proto.add_trigger_variation_id(entry.first);
break; break;
case CHROME_SYNC_SERVICE: case CHROME_SYNC_EVENT_LOGGER:
case ID_COLLECTION_COUNT: case ID_COLLECTION_COUNT:
// These cases included to get full enum coverage for switch, so that // These cases included to get full enum coverage for switch, so that
// new enums introduce compiler warnings. Nothing to do for these. // new enums introduce compiler warnings. Nothing to do for these.
......
...@@ -58,10 +58,8 @@ void RegisterVariationIds(const Study_Experiment& experiment, ...@@ -58,10 +58,8 @@ void RegisterVariationIds(const Study_Experiment& experiment,
if (experiment.has_chrome_sync_experiment_id()) { if (experiment.has_chrome_sync_experiment_id()) {
const VariationID variation_id = const VariationID variation_id =
static_cast<VariationID>(experiment.chrome_sync_experiment_id()); static_cast<VariationID>(experiment.chrome_sync_experiment_id());
AssociateGoogleVariationIDForce(CHROME_SYNC_SERVICE, AssociateGoogleVariationIDForce(CHROME_SYNC_EVENT_LOGGER, trial_name,
trial_name, experiment.name(), variation_id);
experiment.name(),
variation_id);
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment