Commit a85e404a authored by Xida Chen's avatar Xida Chen Committed by Commit Bot

Temporary fix for a crash at TouchActionFilter::ReportTouchAction

This is a temporary fix to ensure that there will be no crash at
TouchActionFilter::ReportTouchAction when the |scrolling_touch_action_|
has no value.

TBR=nzolghadr@chromium.org

Bug: 879511
Change-Id: I007efc418c6169bc4ca91e9ac3d8e1627a8f2a4c
Reviewed-on: https://chromium-review.googlesource.com/1226823Reviewed-by: default avatarXida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591397}
parent e80e014f
...@@ -269,9 +269,12 @@ void TouchActionFilter::ReportTouchAction() { ...@@ -269,9 +269,12 @@ void TouchActionFilter::ReportTouchAction() {
// Since |cc::kTouchActionAuto| is equivalent to |cc::kTouchActionMax|, we // Since |cc::kTouchActionAuto| is equivalent to |cc::kTouchActionMax|, we
// must add one to the upper bound to be able to visualize the number of // must add one to the upper bound to be able to visualize the number of
// times |cc::kTouchActionAuto| is hit. // times |cc::kTouchActionAuto| is hit.
UMA_HISTOGRAM_ENUMERATION("TouchAction.EffectiveTouchAction", // https://crbug.com/879511, remove this temporary fix.
scrolling_touch_action_.value(), if (scrolling_touch_action_.has_value()) {
cc::kTouchActionMax + 1); UMA_HISTOGRAM_ENUMERATION("TouchAction.EffectiveTouchAction",
scrolling_touch_action_.value(),
cc::kTouchActionMax + 1);
}
// Report how often the effective touch action computed by blink is or is // Report how often the effective touch action computed by blink is or is
// not equivalent to the whitelisted touch action computed by the // not equivalent to the whitelisted touch action computed by the
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment