Commit a8722a59 authored by Arthur Eubanks's avatar Arthur Eubanks Committed by Commit Bot

Clarify updating Clang docs

Be more specific about "reasonably green".
Add instructions on how to roll your own Clang.

Change-Id: If5fd297e41f9a66c7c6e736903c14e911fe5819f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373265Reviewed-by: default avatarHans Wennborg <hans@chromium.org>
Commit-Queue: Arthur Eubanks <aeubanks@google.com>
Cr-Commit-Position: refs/heads/master@{#801436}
parent ea11a407
...@@ -7,7 +7,9 @@ describes how to build a package at a newer revision and update Chromium to it. ...@@ -7,7 +7,9 @@ describes how to build a package at a newer revision and update Chromium to it.
An archive of all packages built so far is at https://is.gd/chromeclang An archive of all packages built so far is at https://is.gd/chromeclang
1. Check that https://ci.chromium.org/p/chromium/g/chromium.clang/console 1. Check that https://ci.chromium.org/p/chromium/g/chromium.clang/console
looks reasonably green. looks reasonably green. Red bots with seemingly normal test failures are
usually ok, that likely means the test is broken with the stable Clang as
well.
1. Sync your Chromium tree to the latest revision to pick up any plugin 1. Sync your Chromium tree to the latest revision to pick up any plugin
changes. changes.
1. Run [go/chrome-push-clang-to-goma](https://goto.google.com/chrome-push-clang-to-goma). 1. Run [go/chrome-push-clang-to-goma](https://goto.google.com/chrome-push-clang-to-goma).
...@@ -18,6 +20,12 @@ An archive of all packages built so far is at https://is.gd/chromeclang ...@@ -18,6 +20,12 @@ An archive of all packages built so far is at https://is.gd/chromeclang
https://crbug.com/1034081). Then it will push the packages to goma. If you https://crbug.com/1034081). Then it will push the packages to goma. If you
do not have the necessary credentials to do the upload, ask do not have the necessary credentials to do the upload, ask
clang@chromium.org to find someone who does. clang@chromium.org to find someone who does.
* Alternatively, to create your own roll CL, you can manually run
`tools/clang/scripts/upload_revision.py` with a recent upstream LLVM
commit hash as the argument. After the `*_upload_clang` trybots are
successfully finished, run
[go/chrome-promote-clang](https://goto.google.com/chrome-promote-clang)
on the new Clang package name.
1. Run an exhaustive set of try jobs to test the new compiler. The CL 1. Run an exhaustive set of try jobs to test the new compiler. The CL
description created previously by upload_revision.py includes description created previously by upload_revision.py includes
`Cq-Include-Trybots:` lines for all needed bots, so it's sufficient to just `Cq-Include-Trybots:` lines for all needed bots, so it's sufficient to just
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment