Commit a87cdc42 authored by Yi Gu's avatar Yi Gu Committed by Chromium LUCI CQ

[CodeHealth] Convert chrome/browser/ui/views/tabs from base::Bind and...

[CodeHealth] Convert chrome/browser/ui/views/tabs from base::Bind and base::Callback to Once/Repeating

Bug: 1152282
Change-Id: I4ab30e88b352645a9a32dcc834931c5a8089c87a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586155Reviewed-by: default avatarElly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836761}
parent 59791060
...@@ -223,8 +223,8 @@ BrowserTabStripController::BrowserTabStripController( ...@@ -223,8 +223,8 @@ BrowserTabStripController::BrowserTabStripController(
local_pref_registrar_.Init(g_browser_process->local_state()); local_pref_registrar_.Init(g_browser_process->local_state());
local_pref_registrar_.Add( local_pref_registrar_.Add(
prefs::kTabStripStackedLayout, prefs::kTabStripStackedLayout,
base::Bind(&BrowserTabStripController::UpdateStackedLayout, base::BindRepeating(&BrowserTabStripController::UpdateStackedLayout,
base::Unretained(this))); base::Unretained(this)));
} }
BrowserTabStripController::~BrowserTabStripController() { BrowserTabStripController::~BrowserTabStripController() {
......
...@@ -210,7 +210,8 @@ ColorPickerView::ColorPickerView( ...@@ -210,7 +210,8 @@ ColorPickerView::ColorPickerView(
// references to them. base::Unretained() is safe here since we delete these // references to them. base::Unretained() is safe here since we delete these
// views in our destructor, ensuring we outlive them. // views in our destructor, ensuring we outlive them.
elements_.push_back(AddChildView(std::make_unique<ColorPickerElementView>( elements_.push_back(AddChildView(std::make_unique<ColorPickerElementView>(
base::Bind(&ColorPickerView::OnColorSelected, base::Unretained(this)), base::BindRepeating(&ColorPickerView::OnColorSelected,
base::Unretained(this)),
bubble_view, color.first, color.second))); bubble_view, color.first, color.second)));
if (initial_color_id == color.first) if (initial_color_id == color.first)
elements_.back()->SetSelected(true); elements_.back()->SetSelected(true);
......
...@@ -18,7 +18,7 @@ class TabCloseButton : public views::ImageButton, ...@@ -18,7 +18,7 @@ class TabCloseButton : public views::ImageButton,
public views::MaskedTargeterDelegate { public views::MaskedTargeterDelegate {
public: public:
using MouseEventCallback = using MouseEventCallback =
base::Callback<void(views::View*, const ui::MouseEvent&)>; base::RepeatingCallback<void(views::View*, const ui::MouseEvent&)>;
// The mouse_event callback will be called for every mouse event to allow // The mouse_event callback will be called for every mouse event to allow
// middle clicks to be handled by the parent. // middle clicks to be handled by the parent.
......
...@@ -1571,7 +1571,7 @@ class MaximizedBrowserWindowWaiter { ...@@ -1571,7 +1571,7 @@ class MaximizedBrowserWindowWaiter {
BrowserWindow* window_; BrowserWindow* window_;
// The waiter's RunLoop quit closure. // The waiter's RunLoop quit closure.
base::Closure quit_; base::RepeatingClosure quit_;
}; };
} // namespace } // namespace
......
...@@ -173,8 +173,8 @@ TabGroupEditorBubbleView::TabGroupEditorBubbleView( ...@@ -173,8 +173,8 @@ TabGroupEditorBubbleView::TabGroupEditorBubbleView(
color_selector_ = color_selector_ =
group_modifier_container->AddChildView(std::make_unique<ColorPickerView>( group_modifier_container->AddChildView(std::make_unique<ColorPickerView>(
this, colors_, initial_color_id, this, colors_, initial_color_id,
base::Bind(&TabGroupEditorBubbleView::UpdateGroup, base::BindRepeating(&TabGroupEditorBubbleView::UpdateGroup,
base::Unretained(this)))); base::Unretained(this))));
color_selector_->SetProperty( color_selector_->SetProperty(
views::kMarginsKey, views::kMarginsKey,
gfx::Insets(0, control_insets.left(), 0, control_insets.right())); gfx::Insets(0, control_insets.left(), 0, control_insets.right()));
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment