Commit a883e341 authored by Sebastien Lalancette's avatar Sebastien Lalancette Committed by Commit Bot

[iOS] Removing Open in Incognito action from Recent Tabs Menus

Recent Tabs should not have any overlap with Incognito.

Bug: 1119377
Change-Id: Ic28d1c8ad7309e09e94478913956c8534bebe061
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367973
Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Auto-Submit: Sebastien Lalancette <seblalancette@chromium.org>
Reviewed-by: default avatarSergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800375}
parent 56942ef2
...@@ -189,10 +189,6 @@ ...@@ -189,10 +189,6 @@
[self dismissRecentTabs]; [self dismissRecentTabs];
} }
- (void)showActiveIncognitoTabFromRecentTabs {
[self dismissRecentTabs];
}
- (void)showHistoryFromRecentTabs { - (void)showHistoryFromRecentTabs {
// Dismiss recent tabs before presenting history. // Dismiss recent tabs before presenting history.
CommandDispatcher* dispatcher = self.browser->GetCommandDispatcher(); CommandDispatcher* dispatcher = self.browser->GetCommandDispatcher();
......
...@@ -83,16 +83,6 @@ ...@@ -83,16 +83,6 @@
showActiveRegularTabFromRecentTabs]; showActiveRegularTabFromRecentTabs];
}]]; }]];
ProceduralBlock incognitoCompletion = ^{
[strongSelf.recentTabsPresentationDelegate
showActiveIncognitoTabFromRecentTabs];
};
[menuElements
addObject:
[actionFactory
actionToOpenInNewIncognitoTabWithURL:item.URL
completion:incognitoCompletion]];
if (IsMultipleScenesSupported()) { if (IsMultipleScenesSupported()) {
[menuElements [menuElements
addObject: addObject:
......
...@@ -20,9 +20,6 @@ class DistantSession; ...@@ -20,9 +20,6 @@ class DistantSession;
// Tells the receiver to show the tab UI for regular tabs. NO-OP if the correct // Tells the receiver to show the tab UI for regular tabs. NO-OP if the correct
// tab UI is already visible. Receiver may also dismiss recent tabs. // tab UI is already visible. Receiver may also dismiss recent tabs.
- (void)showActiveRegularTabFromRecentTabs; - (void)showActiveRegularTabFromRecentTabs;
// Tells the receiver to show the tab UI for incognito tabs. NO-OP if the
// correct tab UI is already visible. Receiver may also dismiss recent tabs.
- (void)showActiveIncognitoTabFromRecentTabs;
// Tells the receiver to show the history UI. Receiver may also dismiss recent // Tells the receiver to show the history UI. Receiver may also dismiss recent
// tabs. // tabs.
- (void)showHistoryFromRecentTabs; - (void)showHistoryFromRecentTabs;
......
...@@ -407,12 +407,6 @@ ...@@ -407,12 +407,6 @@
focusOmnibox:NO]; focusOmnibox:NO];
} }
- (void)showActiveIncognitoTabFromRecentTabs {
[self.delegate tabGrid:self
shouldFinishWithBrowser:self.incognitoBrowser
focusOmnibox:NO];
}
#pragma mark - HistoryPresentationDelegate #pragma mark - HistoryPresentationDelegate
- (void)showActiveRegularTabFromHistory { - (void)showActiveRegularTabFromHistory {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment