Commit a8cc78fa authored by Yi Su's avatar Yi Su Committed by Commit Bot

Disable FontSizeJsTest.* when running on iOS13 and compiled with Xcode10

Bug: 983776
Change-Id: I96b5e093b2c33e94339051625b75fe9733e915ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706852
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: default avatarRohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#678390}
parent d7b98d0c
......@@ -5,6 +5,7 @@
#import <Foundation/Foundation.h>
#include <stddef.h>
#include "base/ios/ios_util.h"
#include "base/macros.h"
#import "ios/web/public/test/web_js_test.h"
#import "ios/web/public/test/web_test_with_web_state.h"
......@@ -57,6 +58,15 @@ class FontSizeJsTest : public web::WebJsTest<web::WebTestWithWebState> {
// Tests that __gCrWeb.accessibility.adjustFontSize works for any scale.
TEST_F(FontSizeJsTest, TestAdjustFontSizeForScale) {
// TODO(crbug.com/983776): This test fails when compiled with Xcode 10 and
// running on iOS 13 because expected font size and actual font size don't
// match. Re-enable this test when Xcode 11 is used for compiling.
#if !defined(__IPHONE_13_0) || (__IPHONE_OS_VERSION_MAX_ALLOWED < __IPHONE_13_0)
if (base::ios::IsRunningOnIOS13OrLater()) {
return;
}
#endif
float original_size = 0;
float current_size = 0;
......@@ -171,6 +181,15 @@ TEST_F(FontSizeJsTest, TestAdjustFontSizeForScale) {
// Tests that __gCrWeb.accessibility.adjustFontSize works for any CSS unit.
TEST_F(FontSizeJsTest, TestAdjustFontSizeForUnit) {
// TODO(crbug.com/983776): This test fails when compiled with Xcode 10 and
// running on iOS 13 because expected font size and actual font size don't
// match. Re-enable this test when Xcode 11 is used for compiling.
#if !defined(__IPHONE_13_0) || (__IPHONE_OS_VERSION_MAX_ALLOWED < __IPHONE_13_0)
if (base::ios::IsRunningOnIOS13OrLater()) {
return;
}
#endif
float original_size = 0;
float current_size = 0;
......@@ -237,6 +256,15 @@ TEST_F(FontSizeJsTest, TestAdjustFontSizeForUnit) {
// Tests that __gCrWeb.accessibility.adjustFontSize works for nested elements.
TEST_F(FontSizeJsTest, TestAdjustFontSizeForNestedElements) {
// TODO(crbug.com/983776): This test fails when compiled with Xcode 10 and
// running on iOS 13 because expected font size and actual font size don't
// match. Re-enable this test when Xcode 11 is used for compiling.
#if !defined(__IPHONE_13_0) || (__IPHONE_OS_VERSION_MAX_ALLOWED < __IPHONE_13_0)
if (base::ios::IsRunningOnIOS13OrLater()) {
return;
}
#endif
float original_size_1 = 0;
float original_size_2 = 0;
float current_size_1 = 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment