Commit a8d5415e authored by Finnur Thorarinsson's avatar Finnur Thorarinsson Committed by Chromium LUCI CQ

[Android]: Fix uninitialized read in AppBannerManager.

Bug: 1166410
Change-Id: Ifea16684b7d1d653ca2447b907eb217d09ce0abf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632764
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: default avatarDominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844740}
parent 5fefa48e
...@@ -535,7 +535,6 @@ public class AppBannerManagerTest { ...@@ -535,7 +535,6 @@ public class AppBannerManagerTest {
} }
@Test @Test
@DisabledTest(message = "https://crbug.com/1166410")
@SmallTest @SmallTest
@Feature({"AppBanners"}) @Feature({"AppBanners"})
public void testAppInstalledModalNativeAppBannerBrowserTabWithUrl() throws Exception { public void testAppInstalledModalNativeAppBannerBrowserTabWithUrl() throws Exception {
...@@ -553,7 +552,6 @@ public class AppBannerManagerTest { ...@@ -553,7 +552,6 @@ public class AppBannerManagerTest {
} }
@Test @Test
@DisabledTest(message = "https://crbug.com/1166410")
@SmallTest @SmallTest
@Feature({"AppBanners"}) @Feature({"AppBanners"})
public void testAppInstalledModalNativeAppBannerCustomTab() throws Exception { public void testAppInstalledModalNativeAppBannerCustomTab() throws Exception {
...@@ -612,7 +610,6 @@ public class AppBannerManagerTest { ...@@ -612,7 +610,6 @@ public class AppBannerManagerTest {
} }
@Test @Test
@DisabledTest(message = "https://crbug.com/1166410")
@SmallTest @SmallTest
@Feature({"AppBanners"}) @Feature({"AppBanners"})
public void testModalNativeAppBannerCanBeTriggeredMultipleTimesBrowserTab() throws Exception { public void testModalNativeAppBannerCanBeTriggeredMultipleTimesBrowserTab() throws Exception {
......
...@@ -209,6 +209,7 @@ AppBannerManager::AppBannerManager(content::WebContents* web_contents) ...@@ -209,6 +209,7 @@ AppBannerManager::AppBannerManager(content::WebContents* web_contents)
: content::WebContentsObserver(web_contents), : content::WebContentsObserver(web_contents),
SiteEngagementObserver(site_engagement::SiteEngagementService::Get( SiteEngagementObserver(site_engagement::SiteEngagementService::Get(
Profile::FromBrowserContext(web_contents->GetBrowserContext()))), Profile::FromBrowserContext(web_contents->GetBrowserContext()))),
has_maskable_primary_icon_(false),
state_(State::INACTIVE), state_(State::INACTIVE),
manager_(InstallableManager::FromWebContents(web_contents)), manager_(InstallableManager::FromWebContents(web_contents)),
has_sufficient_engagement_(false), has_sufficient_engagement_(false),
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment