[fuchsia] Migrate NetInterface::flags to bits

Fixed: 1099393
Change-Id: I15d48675a9824f54542f70a5eb03c429443c88f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358210
Commit-Queue: Tamir Duberstein <tamird@google.com>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799102}

net/base/network_change_notifier_fuchsia_unittest.cc

@@ -68,8 +68,7 @@ fuchsia::netstack::NetInterface DefaultNetInterface() {
   // is sufficient.
   fuchsia::netstack::NetInterface interface;
   interface.id = kDefaultInterfaceId;
-  interface.flags = static_cast<decltype(interface.flags)>(
-      fuchsia::netstack::NetInterfaceFlagUp);
+  interface.flags = fuchsia::netstack::Flags::UP;
   interface.features = {};
   interface.addr = IpAddressFrom(kDefaultIPv4Address);
   interface.netmask = IpAddressFrom(kDefaultIPv4Netmask);
@@ -82,8 +81,7 @@ fuchsia::netstack::NetInterface SecondaryNetInterface() {
   // is sufficient.
   fuchsia::netstack::NetInterface interface;
   interface.id = kSecondaryInterfaceId;
-  interface.flags = static_cast<decltype(interface.flags)>(
-      fuchsia::netstack::NetInterfaceFlagUp);
+  interface.flags = fuchsia::netstack::Flags::UP;
   interface.features = {};
   interface.addr = IpAddressFrom(kSecondaryIPv4Address);
   interface.netmask = IpAddressFrom(kSecondaryIPv4Netmask);
@@ -527,8 +525,7 @@ TEST_F(NetworkChangeNotifierFuchsiaTest, InterfaceUp) {
   EXPECT_EQ(NetworkChangeNotifier::ConnectionType::CONNECTION_NONE,
             notifier_->GetCurrentConnectionType());
 
-  interfaces[0].flags = static_cast<decltype(interfaces[0].flags)>(
-      fuchsia::netstack::NetInterfaceFlagUp);
+  interfaces[0].flags = fuchsia::netstack::Flags::UP;
   netstack_.SetInterfaces(interfaces);
 
   EXPECT_TRUE(type_observer_->RunAndExpectConnectionTypes(

net/base/network_interfaces_fuchsia.cc

@@ -60,9 +60,8 @@ NetworkInterface NetworkInterfaceFromAddress(
 
 NetworkChangeNotifier::ConnectionType ConvertConnectionType(
     const fuchsia::netstack::NetInterface& iface) {
-  auto up =
-      static_cast<decltype(iface.flags)>(fuchsia::netstack::NetInterfaceFlagUp);
-  if ((iface.flags & up) != up) {
+  if ((iface.flags & fuchsia::netstack::Flags::UP) !=
+      fuchsia::netstack::Flags::UP) {
     return NetworkChangeNotifier::CONNECTION_NONE;
   } else if ((iface.features & fuchsia::hardware::ethernet::Features::WLAN) ==
              fuchsia::hardware::ethernet::Features::WLAN) {