Skip to content

GitLab

T
tangled
Commit a908956b authored by Mario Sanchez Prada's avatar Mario Sanchez Prada Committed by Commit Bot
Browse files
Options

[css-grid] Migrate flex-and-minmax-content-resolution-columns to WPT 

Migrate this test out of blink/web_tests/fast/css-grid-layout
and into the WPT-specific directory, adding links to the relevant
specs and a test assertion describing its purpose.

Additionally, migrate this test from being a testRunner-based reftest
with plain text expectation into a testharness.js-based test that uses
check-layout-th.js instead of the utils from the Chromium-specific
check-layout.js file, and drop the expectations file.

Bug: 767015, 1063749
Change-Id: I4291bedea5a83fcc9012ba7c0707238f93a6b052
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144187
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Reviewed-by: default avatarManuel Rego <rego@igalia.com>
Reviewed-by: default avatarChristian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758781}
parent f30eedb4
Hide whitespace changes
Inline Side-by-side
Showing with 17 additions and 30 deletions
third_party/blink/web_tests/fast/css-grid-layout/flex-and-minmax-content-resolution-columns.html → third_party/blink/web_tests/external/wpt/css/css-grid/grid-definition/flex-and-minmax-content-resolution-columns-001.html
View file @ a908956b
<!DOCTYPE html> <!DOCTYPE html>
<html> <html>
<link href="resources/grid.css" rel="stylesheet"> <title>CSS Grid Layout Test: Auto repeat tracks, grid-template-columns and minmax sizes.</title>
<link rel="author" title="Julien Chaffraix" href="mailto:jchaffraix@chromium.org">
<link rel="help" href="https://drafts.csswg.org/css-grid-1/#track-sizes">
<link rel="help" href="https://drafts.csswg.org/css-grid-1/#fr-unit">
<link rel="help" href="https://bugs.chromium.org/p/chromium/issues/detail?id=235258">
<link rel="stylesheet" href="/fonts/ahem.css">
<link rel="stylesheet" href="/css/support/grid.css">
<meta name="assert" content="Test that resolving auto tracks on grid items inside containers using minmax() with grid-template-columns works properly." />
<style> <style>
.gridMaxMaxContent { .gridMaxMaxContent {
grid-template-columns: minmax(10px, max-content) minmax(10px, 1fr); grid-template-columns: minmax(10px, max-content) minmax(10px, 1fr);
...@@ -36,10 +44,15 @@ ...@@ -36,10 +44,15 @@
grid-row: 1; grid-row: 1;
} }
</style> </style>
<script src="../../resources/check-layout.js"></script>
<body onload="checkLayout('.grid');">
<p>Test that resolving auto tracks on grid items works properly.</p> <script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="/resources/check-layout-th.js"></script>
<script type="text/javascript">
setup({ explicit_done: true });
</script>
<body onload="document.fonts.ready.then(() => { checkLayout('.grid'); })">
<div class="constrainedContainer"> <div class="constrainedContainer">
<div class="grid gridMaxMaxContent"> <div class="grid gridMaxMaxContent">
......
third_party/blink/web_tests/fast/css-grid-layout/flex-and-minmax-content-resolution-columns-expected.txt deleted 100644 → 0
View file @ f30eedb4
Test that resolving auto tracks on grid items works properly.
XXXXX
PASS
XXXXX
PASS
XXXXX
PASS
XX XX
XX XX
PASS
XX XX
XX XX
PASS
XX XX
XX XX
PASS
PASS
XXXXXXXXXX
PASS
XXXXXXXXXX XXXXXXXXX
PASS
XXXXXXXXXX XXXXXXXXX
PASS
XXXXXXXXXX XXXXXXXXX
PASS
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment