Remove more base::Bind() calls in chrome/renderer

In this CL, we replace base::Bind() with BindOnce/BindRepeating.
BindOnce is preferred, so here is the rationale for the BindRepeating
cases:
* In SearchBouncer, the base::Bind is used as a parameter of
AddInterface(), which requires a repeating callback. It also makes sense
to allow for multiple receivers.
* In TranslateAgentBrowsertest, it is used as a parameter to
SetBinderForTesting, which also requires a repeating callback.

Both Repeating cases are associated to methods in Blink which are
already marked as receiving repeating callbacks.

Bug: 1007641
Change-Id: I03c1b25669a63e58ce5b384f301d2c5b1399e0bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107716Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751333}

chrome/renderer/pepper/pepper_flash_drm_renderer_host.cc

@@ -59,13 +59,11 @@ int32_t PepperFlashDRMRendererHost::OnGetVoucherFile(
   create_msgs.push_back(PpapiHostMsg_FileRef_CreateForRawFS(voucher_file));
 
   renderer_ppapi_host_->CreateBrowserResourceHosts(
-      pp_instance(),
-      create_msgs,
-      base::Bind(&PepperFlashDRMRendererHost::DidCreateFileRefHosts,
-                 weak_factory_.GetWeakPtr(),
-                 context->MakeReplyMessageContext(),
-                 voucher_file,
-                 renderer_pending_host_id));
+      pp_instance(), create_msgs,
+      base::BindOnce(&PepperFlashDRMRendererHost::DidCreateFileRefHosts,
+                     weak_factory_.GetWeakPtr(),
+                     context->MakeReplyMessageContext(), voucher_file,
+                     renderer_pending_host_id));
   return PP_OK_COMPLETIONPENDING;
 }
 

chrome/renderer/searchbox/search_bouncer.cc

@@ -36,7 +36,7 @@ void SearchBouncer::RegisterMojoInterfaces(
     blink::AssociatedInterfaceRegistry* associated_interfaces) {
   // Note: Unretained is safe here because this class is a leaky LazyInstance.
   // For the same reason, UnregisterMojoInterfaces isn't required.
-  associated_interfaces->AddInterface(base::Bind(
+  associated_interfaces->AddInterface(base::BindRepeating(
       &SearchBouncer::BindSearchBouncerReceiver, base::Unretained(this)));
 }
 

chrome/renderer/translate/translate_agent_browsertest.cc

@@ -94,8 +94,8 @@ class TestTranslateAgent : public translate::TranslateAgent {
 
     // Will get new result values via OnPageTranslated.
     TranslateFrame(translate_script, source_lang, target_lang,
-                   base::Bind(&TestTranslateAgent::OnPageTranslated,
-                              base::Unretained(this)));
+                   base::BindOnce(&TestTranslateAgent::OnPageTranslated,
+                                  base::Unretained(this)));
   }
 
   bool GetPageTranslatedResult(std::string* original_lang,
@@ -160,8 +160,8 @@ class TranslateAgentBrowserTest : public ChromeRenderViewTest {
         ->GetBrowserInterfaceBroker()
         ->SetBinderForTesting(
             translate::mojom::ContentTranslateDriver::Name_,
-            base::Bind(&FakeContentTranslateDriver::BindHandle,
-                       base::Unretained(&fake_translate_driver_)));
+            base::BindRepeating(&FakeContentTranslateDriver::BindHandle,
+                                base::Unretained(&fake_translate_driver_)));
   }
 
   void TearDown() override {