Commit a91e5309 authored by dgozman's avatar dgozman Committed by Commit bot

[DevTools] Turn ConsoleModel into a singleton

This effectively merges ConsoleModel and MultitargetConsoleModel.

This is in preparation to extracting ConsoleModel out of SDK and
turning it into ConsoleView's presentation model.

BUG=none

Review-Url: https://codereview.chromium.org/2751173003
Cr-Commit-Position: refs/heads/master@{#457354}
parent 2b9f74d8
...@@ -24,7 +24,7 @@ function frameLoaded(event) { ...@@ -24,7 +24,7 @@ function frameLoaded(event) {
function test() function test()
{ {
for (var message of SDK.multitargetConsoleModel.messages()) { for (var message of SDK.consoleModel.messages()) {
var args = (message.parameters || []).map((arg) => arg.type); var args = (message.parameters || []).map((arg) => arg.type);
InspectorTest.addResult("Message: \"" + message.messageText + "\", arguments: [" + args.join(", ") + "]"); InspectorTest.addResult("Message: \"" + message.messageText + "\", arguments: [" + args.join(", ") + "]");
} }
......
...@@ -31,7 +31,7 @@ function createIFrame() ...@@ -31,7 +31,7 @@ function createIFrame()
function test() function test()
{ {
for (var message of SDK.multitargetConsoleModel.messages()) { for (var message of SDK.consoleModel.messages()) {
var args = (message.parameters || []).map((arg) => arg.type); var args = (message.parameters || []).map((arg) => arg.type);
InspectorTest.addResult("Message: \"" + message.messageText + "\", arguments: [" + args.join(", ") + "]"); InspectorTest.addResult("Message: \"" + message.messageText + "\", arguments: [" + args.join(", ") + "]");
} }
......
...@@ -16,7 +16,7 @@ function test() ...@@ -16,7 +16,7 @@ function test()
var mainTarget = SDK.targetManager.mainTarget(); var mainTarget = SDK.targetManager.mainTarget();
var debuggerModel = SDK.DebuggerModel.fromTarget(mainTarget); var debuggerModel = SDK.DebuggerModel.fromTarget(mainTarget);
var message = new SDK.ConsoleMessage(mainTarget, SDK.ConsoleMessage.MessageSource.JS, SDK.ConsoleMessage.MessageLevel.Info, "hello?", null, "http://127.0.0.1:8000/inspector/resources/source2.js"); var message = new SDK.ConsoleMessage(mainTarget, SDK.ConsoleMessage.MessageSource.JS, SDK.ConsoleMessage.MessageLevel.Info, "hello?", null, "http://127.0.0.1:8000/inspector/resources/source2.js");
SDK.multitargetConsoleModel.addMessage(message); SDK.consoleModel.addMessage(message);
debuggerModel.addEventListener(SDK.DebuggerModel.Events.ParsedScriptSource, onScriptAdded); debuggerModel.addEventListener(SDK.DebuggerModel.Events.ParsedScriptSource, onScriptAdded);
InspectorTest.dumpConsoleMessages(); InspectorTest.dumpConsoleMessages();
......
...@@ -987,7 +987,7 @@ SDK.targetManager.observeTargets({ ...@@ -987,7 +987,7 @@ SDK.targetManager.observeTargets({
InspectorTest.serviceWorkerManager = target.model(SDK.ServiceWorkerManager); InspectorTest.serviceWorkerManager = target.model(SDK.ServiceWorkerManager);
InspectorTest.tracingManager = target.model(SDK.TracingManager); InspectorTest.tracingManager = target.model(SDK.TracingManager);
InspectorTest.mainTarget = target; InspectorTest.mainTarget = target;
Promise.resolve().then(() => { InspectorTest.consoleModel = SDK.multitargetConsoleModel._consoleModels.get(target); }); InspectorTest.consoleModel = SDK.consoleModel;
}, },
targetRemoved: function(target) { } targetRemoved: function(target) { }
......
...@@ -30,13 +30,13 @@ function test() ...@@ -30,13 +30,13 @@ function test()
function waitForConsoleMessage(regex) function waitForConsoleMessage(regex)
{ {
return new Promise(function(resolve) { return new Promise(function(resolve) {
SDK.multitargetConsoleModel.addEventListener(SDK.ConsoleModel.Events.MessageAdded, sniff); SDK.consoleModel.addEventListener(SDK.ConsoleModel.Events.MessageAdded, sniff);
function sniff(e) function sniff(e)
{ {
if (e.data && regex.test(e.data.messageText)) { if (e.data && regex.test(e.data.messageText)) {
resolve(e.data); resolve(e.data);
SDK.multitargetConsoleModel.removeEventListener(SDK.ConsoleModel.Events.MessageAdded, sniff); SDK.consoleModel.removeEventListener(SDK.ConsoleModel.Events.MessageAdded, sniff);
} }
} }
}); });
......
...@@ -5,7 +5,7 @@ ...@@ -5,7 +5,7 @@
<script> <script>
function test() function test()
{ {
InspectorTest.consoleModel.addMessage(new SDK.ConsoleMessage(InspectorTest.consoleModel.target(), SDK.ConsoleMessage.MessageSource.Other, SDK.ConsoleMessage.MessageLevel.Info, "PASS")); InspectorTest.consoleModel.addMessage(new SDK.ConsoleMessage(InspectorTest.mainTarget, SDK.ConsoleMessage.MessageSource.Other, SDK.ConsoleMessage.MessageLevel.Info, "PASS"));
Common.settingForTest("preserveConsoleLog").set(true); Common.settingForTest("preserveConsoleLog").set(true);
InspectorTest.reloadPage(function() { InspectorTest.reloadPage(function() {
InspectorTest.dumpConsoleMessages(); InspectorTest.dumpConsoleMessages();
......
...@@ -18,8 +18,8 @@ function handlePromiseRejection() ...@@ -18,8 +18,8 @@ function handlePromiseRejection()
function test() function test()
{ {
SDK.multitargetConsoleModel.addEventListener(SDK.ConsoleModel.Events.MessageAdded, InspectorTest.wrapListener(messageAdded)); SDK.consoleModel.addEventListener(SDK.ConsoleModel.Events.MessageAdded, InspectorTest.wrapListener(messageAdded));
SDK.multitargetConsoleModel.addEventListener(SDK.ConsoleModel.Events.MessageUpdated, InspectorTest.wrapListener(messageUpdated)); SDK.consoleModel.addEventListener(SDK.ConsoleModel.Events.MessageUpdated, InspectorTest.wrapListener(messageUpdated));
InspectorTest.addResult("Creating worker with promise"); InspectorTest.addResult("Creating worker with promise");
InspectorTest.evaluateInPageWithTimeout("createPromise()"); InspectorTest.evaluateInPageWithTimeout("createPromise()");
......
...@@ -14,7 +14,7 @@ function test() ...@@ -14,7 +14,7 @@ function test()
function addMessageWithFixedTimestamp(messageText, timestamp) function addMessageWithFixedTimestamp(messageText, timestamp)
{ {
var message = new SDK.ConsoleMessage( var message = new SDK.ConsoleMessage(
InspectorTest.consoleModel.target(), InspectorTest.mainTarget,
SDK.ConsoleMessage.MessageSource.Other, // source SDK.ConsoleMessage.MessageSource.Other, // source
SDK.ConsoleMessage.MessageLevel.Info, // level SDK.ConsoleMessage.MessageLevel.Info, // level
messageText, messageText,
......
...@@ -64,11 +64,11 @@ function initialize_extensionsPanelTest() ...@@ -64,11 +64,11 @@ function initialize_extensionsPanelTest()
InspectorTest.disableConsoleViewport(); InspectorTest.disableConsoleViewport();
InspectorTest.evaluateInPage("logMessage()"); InspectorTest.evaluateInPage("logMessage()");
var wrappedConsoleMessageAdded = InspectorTest.safeWrap(consoleMessageAdded); var wrappedConsoleMessageAdded = InspectorTest.safeWrap(consoleMessageAdded);
SDK.multitargetConsoleModel.addEventListener(SDK.ConsoleModel.Events.MessageAdded, wrappedConsoleMessageAdded); SDK.consoleModel.addEventListener(SDK.ConsoleModel.Events.MessageAdded, wrappedConsoleMessageAdded);
function consoleMessageAdded() function consoleMessageAdded()
{ {
SDK.multitargetConsoleModel.removeEventListener(SDK.ConsoleModel.Events.MessageAdded, wrappedConsoleMessageAdded); SDK.consoleModel.removeEventListener(SDK.ConsoleModel.Events.MessageAdded, wrappedConsoleMessageAdded);
Console.ConsoleView.instance()._viewportThrottler.flush(); Console.ConsoleView.instance()._viewportThrottler.flush();
InspectorTest.deprecatedRunAfterPendingDispatches(clickOnMessage) InspectorTest.deprecatedRunAfterPendingDispatches(clickOnMessage)
} }
......
...@@ -62,7 +62,7 @@ function dispatchEvents() ...@@ -62,7 +62,7 @@ function dispatchEvents()
function test() function test()
{ {
SDK.multitargetConsoleModel.addEventListener(SDK.ConsoleModel.Events.MessageAdded, InspectorTest.safeWrap(onConsoleMessage)); SDK.consoleModel.addEventListener(SDK.ConsoleModel.Events.MessageAdded, InspectorTest.safeWrap(onConsoleMessage));
step1(); step1();
function step1() function step1()
......
...@@ -40,7 +40,7 @@ function test() ...@@ -40,7 +40,7 @@ function test()
function testDumpFunctionDefinition(next) function testDumpFunctionDefinition(next)
{ {
InspectorTest.addSniffer(ObjectUI.ObjectPropertiesSection, "formatObjectAsFunction", onConsoleMessagesReceived); InspectorTest.addSniffer(ObjectUI.ObjectPropertiesSection, "formatObjectAsFunction", onConsoleMessagesReceived);
SDK.ConsoleModel.evaluateCommandInConsole(UI.context.flavor(SDK.ExecutionContext), "jumpToMe"); SDK.consoleModel.evaluateCommandInConsole(UI.context.flavor(SDK.ExecutionContext), "jumpToMe");
function onConsoleMessagesReceived() function onConsoleMessagesReceived()
{ {
......
...@@ -514,22 +514,19 @@ ...@@ -514,22 +514,19 @@
TestSuite.prototype.testConsoleOnNavigateBack = function() { TestSuite.prototype.testConsoleOnNavigateBack = function() {
function filteredMessages() { function filteredMessages() {
return SDK.multitargetConsoleModel.messages().filter( return SDK.consoleModel.messages().filter(a => a.source !== SDK.ConsoleMessage.MessageSource.Violation);
a => a.source !== SDK.ConsoleMessage.MessageSource.Violation);
} }
if (filteredMessages().length === 1) { if (filteredMessages().length === 1)
firstConsoleMessageReceived.call(this, null); firstConsoleMessageReceived.call(this, null);
} else { else
SDK.multitargetConsoleModel.addEventListener( SDK.consoleModel.addEventListener(SDK.ConsoleModel.Events.MessageAdded, firstConsoleMessageReceived, this);
SDK.ConsoleModel.Events.MessageAdded, firstConsoleMessageReceived, this);
}
function firstConsoleMessageReceived(event) { function firstConsoleMessageReceived(event) {
if (event && event.data.source === SDK.ConsoleMessage.MessageSource.Violation) if (event && event.data.source === SDK.ConsoleMessage.MessageSource.Violation)
return; return;
SDK.multitargetConsoleModel.removeEventListener( SDK.consoleModel.removeEventListener(SDK.ConsoleModel.Events.MessageAdded, firstConsoleMessageReceived, this);
SDK.ConsoleModel.Events.MessageAdded, firstConsoleMessageReceived, this);
this.evaluateInConsole_('clickLink();', didClickLink.bind(this)); this.evaluateInConsole_('clickLink();', didClickLink.bind(this));
} }
...@@ -685,12 +682,12 @@ ...@@ -685,12 +682,12 @@
messages.splice(index, 1); messages.splice(index, 1);
if (!messages.length) { if (!messages.length) {
SDK.multitargetConsoleModel.removeEventListener(SDK.ConsoleModel.Events.MessageAdded, onConsoleMessage, this); SDK.consoleModel.removeEventListener(SDK.ConsoleModel.Events.MessageAdded, onConsoleMessage, this);
next(); next();
} }
} }
SDK.multitargetConsoleModel.addEventListener(SDK.ConsoleModel.Events.MessageAdded, onConsoleMessage, this); SDK.consoleModel.addEventListener(SDK.ConsoleModel.Events.MessageAdded, onConsoleMessage, this);
SDK.multitargetNetworkManager.setNetworkConditions(preset); SDK.multitargetNetworkManager.setNetworkConditions(preset);
} }
...@@ -835,7 +832,7 @@ ...@@ -835,7 +832,7 @@
}; };
TestSuite.prototype.testWindowInitializedOnNavigateBack = function() { TestSuite.prototype.testWindowInitializedOnNavigateBack = function() {
var messages = SDK.multitargetConsoleModel.messages(); var messages = SDK.consoleModel.messages();
this.assertEquals(1, messages.length); this.assertEquals(1, messages.length);
var text = messages[0].messageText; var text = messages[0].messageText;
if (text.indexOf('Uncaught') !== -1) if (text.indexOf('Uncaught') !== -1)
...@@ -870,7 +867,7 @@ ...@@ -870,7 +867,7 @@
}; };
TestSuite.prototype.waitForTestResultsInConsole = function() { TestSuite.prototype.waitForTestResultsInConsole = function() {
var messages = SDK.multitargetConsoleModel.messages(); var messages = SDK.consoleModel.messages();
for (var i = 0; i < messages.length; ++i) { for (var i = 0; i < messages.length; ++i) {
var text = messages[i].messageText; var text = messages[i].messageText;
if (text === 'PASS') if (text === 'PASS')
...@@ -887,7 +884,7 @@ ...@@ -887,7 +884,7 @@
this.fail(text); this.fail(text);
} }
SDK.multitargetConsoleModel.addEventListener(SDK.ConsoleModel.Events.MessageAdded, onConsoleMessage, this); SDK.consoleModel.addEventListener(SDK.ConsoleModel.Events.MessageAdded, onConsoleMessage, this);
this.takeControl(); this.takeControl();
}; };
...@@ -931,12 +928,12 @@ ...@@ -931,12 +928,12 @@
Array.prototype.slice.call(arguments, 1, -1).map(arg => JSON.stringify(arg)).join(',') + ','; Array.prototype.slice.call(arguments, 1, -1).map(arg => JSON.stringify(arg)).join(',') + ',';
this.evaluateInConsole_( this.evaluateInConsole_(
`${functionName}(${argsString} function() { console.log('${doneMessage}'); });`, function() {}); `${functionName}(${argsString} function() { console.log('${doneMessage}'); });`, function() {});
SDK.multitargetConsoleModel.addEventListener(SDK.ConsoleModel.Events.MessageAdded, onConsoleMessage); SDK.consoleModel.addEventListener(SDK.ConsoleModel.Events.MessageAdded, onConsoleMessage);
function onConsoleMessage(event) { function onConsoleMessage(event) {
var text = event.data.messageText; var text = event.data.messageText;
if (text === doneMessage) { if (text === doneMessage) {
SDK.multitargetConsoleModel.removeEventListener(SDK.ConsoleModel.Events.MessageAdded, onConsoleMessage); SDK.consoleModel.removeEventListener(SDK.ConsoleModel.Events.MessageAdded, onConsoleMessage);
callback(); callback();
} }
} }
......
...@@ -44,10 +44,9 @@ Bindings.PresentationConsoleMessageHelper = class { ...@@ -44,10 +44,9 @@ Bindings.PresentationConsoleMessageHelper = class {
/** @type {!Array.<!Bindings.PresentationConsoleMessage>} */ /** @type {!Array.<!Bindings.PresentationConsoleMessage>} */
this._presentationConsoleMessages = []; this._presentationConsoleMessages = [];
SDK.multitargetConsoleModel.addEventListener(SDK.ConsoleModel.Events.ConsoleCleared, this._consoleCleared, this); SDK.consoleModel.addEventListener(SDK.ConsoleModel.Events.ConsoleCleared, this._consoleCleared, this);
SDK.multitargetConsoleModel.addEventListener( SDK.consoleModel.addEventListener(SDK.ConsoleModel.Events.MessageAdded, this._onConsoleMessageAdded, this);
SDK.ConsoleModel.Events.MessageAdded, this._onConsoleMessageAdded, this); SDK.consoleModel.messages().forEach(this._consoleMessageAdded, this);
SDK.multitargetConsoleModel.messages().forEach(this._consoleMessageAdded, this);
// TODO(dgozman): setImmediate because we race with DebuggerWorkspaceBinding on ParsedScriptSource event delivery. // TODO(dgozman): setImmediate because we race with DebuggerWorkspaceBinding on ParsedScriptSource event delivery.
SDK.targetManager.addModelListener( SDK.targetManager.addModelListener(
SDK.DebuggerModel, SDK.DebuggerModel.Events.ParsedScriptSource, SDK.DebuggerModel, SDK.DebuggerModel.Events.ParsedScriptSource,
......
...@@ -191,7 +191,7 @@ Console.ConsolePrompt = class extends UI.Widget { ...@@ -191,7 +191,7 @@ Console.ConsolePrompt = class extends UI.Widget {
this.setText(''); this.setText('');
var currentExecutionContext = UI.context.flavor(SDK.ExecutionContext); var currentExecutionContext = UI.context.flavor(SDK.ExecutionContext);
if (currentExecutionContext) { if (currentExecutionContext) {
SDK.ConsoleModel.evaluateCommandInConsole(currentExecutionContext, text, useCommandLineAPI); SDK.consoleModel.evaluateCommandInConsole(currentExecutionContext, text, useCommandLineAPI);
if (Console.ConsolePanel.instance().isShowing()) if (Console.ConsolePanel.instance().isShowing())
Host.userMetrics.actionTaken(Host.UserMetrics.Action.CommandEvaluatedInConsolePanel); Host.userMetrics.actionTaken(Host.UserMetrics.Action.CommandEvaluatedInConsolePanel);
} }
......
...@@ -182,7 +182,7 @@ Console.ConsoleView = class extends UI.VBox { ...@@ -182,7 +182,7 @@ Console.ConsoleView = class extends UI.VBox {
} }
static clearConsole() { static clearConsole() {
SDK.multitargetConsoleModel.requestClearMessages(); SDK.consoleModel.requestClearMessages();
} }
/** /**
...@@ -225,14 +225,11 @@ Console.ConsoleView = class extends UI.VBox { ...@@ -225,14 +225,11 @@ Console.ConsoleView = class extends UI.VBox {
} }
_fetchMultitargetMessages() { _fetchMultitargetMessages() {
SDK.multitargetConsoleModel.addEventListener(SDK.ConsoleModel.Events.ConsoleCleared, this._consoleCleared, this); SDK.consoleModel.addEventListener(SDK.ConsoleModel.Events.ConsoleCleared, this._consoleCleared, this);
SDK.multitargetConsoleModel.addEventListener( SDK.consoleModel.addEventListener(SDK.ConsoleModel.Events.MessageAdded, this._onConsoleMessageAdded, this);
SDK.ConsoleModel.Events.MessageAdded, this._onConsoleMessageAdded, this); SDK.consoleModel.addEventListener(SDK.ConsoleModel.Events.MessageUpdated, this._onConsoleMessageUpdated, this);
SDK.multitargetConsoleModel.addEventListener( SDK.consoleModel.addEventListener(SDK.ConsoleModel.Events.CommandEvaluated, this._commandEvaluated, this);
SDK.ConsoleModel.Events.MessageUpdated, this._onConsoleMessageUpdated, this); SDK.consoleModel.messages().forEach(this._addConsoleMessage, this);
SDK.multitargetConsoleModel.addEventListener(
SDK.ConsoleModel.Events.CommandEvaluated, this._commandEvaluated, this);
SDK.multitargetConsoleModel.messages().forEach(this._addConsoleMessage, this);
this._viewport.invalidate(); this._viewport.invalidate();
} }
...@@ -805,7 +802,7 @@ Console.ConsoleView = class extends UI.VBox { ...@@ -805,7 +802,7 @@ Console.ConsoleView = class extends UI.VBox {
result.target(), exceptionDetails, SDK.ConsoleMessage.MessageType.Result, undefined, undefined); result.target(), exceptionDetails, SDK.ConsoleMessage.MessageType.Result, undefined, undefined);
} }
message.setOriginatingMessage(originatingConsoleMessage); message.setOriginatingMessage(originatingConsoleMessage);
SDK.multitargetConsoleModel.addMessage(message); SDK.consoleModel.addMessage(message);
} }
/** /**
......
...@@ -165,7 +165,7 @@ Main.Main = class { ...@@ -165,7 +165,7 @@ Main.Main = class {
UI.ContextMenu.installHandler(document); UI.ContextMenu.installHandler(document);
UI.Tooltip.installHandler(document); UI.Tooltip.installHandler(document);
Components.dockController = new Components.DockController(canDock); Components.dockController = new Components.DockController(canDock);
SDK.multitargetConsoleModel = new SDK.MultitargetConsoleModel(); SDK.consoleModel = new SDK.ConsoleModel();
SDK.multitargetNetworkManager = new SDK.MultitargetNetworkManager(); SDK.multitargetNetworkManager = new SDK.MultitargetNetworkManager();
SDK.targetManager.addEventListener( SDK.targetManager.addEventListener(
SDK.TargetManager.Events.SuspendStateChanged, this._onSuspendStateChanged.bind(this)); SDK.TargetManager.Events.SuspendStateChanged, this._onSuspendStateChanged.bind(this));
...@@ -602,9 +602,9 @@ Main.Main.WarningErrorCounter = class { ...@@ -602,9 +602,9 @@ Main.Main.WarningErrorCounter = class {
this._warnings = this._createItem(shadowRoot, 'smallicon-warning'); this._warnings = this._createItem(shadowRoot, 'smallicon-warning');
this._titles = []; this._titles = [];
SDK.multitargetConsoleModel.addEventListener(SDK.ConsoleModel.Events.ConsoleCleared, this._update, this); SDK.consoleModel.addEventListener(SDK.ConsoleModel.Events.ConsoleCleared, this._update, this);
SDK.multitargetConsoleModel.addEventListener(SDK.ConsoleModel.Events.MessageAdded, this._update, this); SDK.consoleModel.addEventListener(SDK.ConsoleModel.Events.MessageAdded, this._update, this);
SDK.multitargetConsoleModel.addEventListener(SDK.ConsoleModel.Events.MessageUpdated, this._update, this); SDK.consoleModel.addEventListener(SDK.ConsoleModel.Events.MessageUpdated, this._update, this);
this._update(); this._update();
} }
...@@ -637,8 +637,8 @@ Main.Main.WarningErrorCounter = class { ...@@ -637,8 +637,8 @@ Main.Main.WarningErrorCounter = class {
} }
_update() { _update() {
var errors = SDK.multitargetConsoleModel.errors(); var errors = SDK.consoleModel.errors();
var warnings = SDK.multitargetConsoleModel.warnings(); var warnings = SDK.consoleModel.warnings();
this._titles = []; this._titles = [];
this._toolbarItem.setVisible(!!(errors || warnings)); this._toolbarItem.setVisible(!!(errors || warnings));
......
...@@ -28,7 +28,7 @@ SDK.LogModel = class extends SDK.SDKModel { ...@@ -28,7 +28,7 @@ SDK.LogModel = class extends SDK.SDKModel {
* @param {!Protocol.Log.LogEntry} payload * @param {!Protocol.Log.LogEntry} payload
*/ */
entryAdded(payload) { entryAdded(payload) {
this.emit(new SDK.LogModel.EntryAddedEvent(payload)); this.emit(new SDK.LogModel.EntryAddedEvent(this, payload));
} }
requestClear() { requestClear() {
...@@ -41,9 +41,11 @@ SDK.SDKModel.register(SDK.LogModel, SDK.Target.Capability.Log); ...@@ -41,9 +41,11 @@ SDK.SDKModel.register(SDK.LogModel, SDK.Target.Capability.Log);
/** @implements {Common.Emittable} */ /** @implements {Common.Emittable} */
SDK.LogModel.EntryAddedEvent = class { SDK.LogModel.EntryAddedEvent = class {
/** /**
* @param {!SDK.LogModel} logModel
* @param {!Protocol.Log.LogEntry} entry * @param {!Protocol.Log.LogEntry} entry
*/ */
constructor(entry) { constructor(logModel, entry) {
this.logModel = logModel;
this.entry = entry; this.entry = entry;
} }
}; };
...@@ -278,7 +278,7 @@ Snippets.ScriptSnippetModel = class extends Common.Object { ...@@ -278,7 +278,7 @@ Snippets.ScriptSnippetModel = class extends Common.Object {
var consoleMessage = new SDK.ConsoleMessage( var consoleMessage = new SDK.ConsoleMessage(
target, SDK.ConsoleMessage.MessageSource.JS, SDK.ConsoleMessage.MessageLevel.Info, '', undefined, sourceURL, target, SDK.ConsoleMessage.MessageSource.JS, SDK.ConsoleMessage.MessageLevel.Info, '', undefined, sourceURL,
undefined, undefined, undefined, [result], undefined, undefined, undefined, scriptId); undefined, undefined, undefined, [result], undefined, undefined, undefined, scriptId);
SDK.multitargetConsoleModel.addMessage(consoleMessage); SDK.consoleModel.addMessage(consoleMessage);
} }
/** /**
...@@ -287,7 +287,7 @@ Snippets.ScriptSnippetModel = class extends Common.Object { ...@@ -287,7 +287,7 @@ Snippets.ScriptSnippetModel = class extends Common.Object {
* @param {?string=} sourceURL * @param {?string=} sourceURL
*/ */
_printRunOrCompileScriptResultFailure(target, exceptionDetails, sourceURL) { _printRunOrCompileScriptResultFailure(target, exceptionDetails, sourceURL) {
SDK.multitargetConsoleModel.addMessage( SDK.consoleModel.addMessage(
SDK.ConsoleMessage.fromException(target, exceptionDetails, undefined, undefined, sourceURL || undefined)); SDK.ConsoleMessage.fromException(target, exceptionDetails, undefined, undefined, sourceURL || undefined));
} }
......
...@@ -956,7 +956,7 @@ Sources.SourcesPanel = class extends UI.Panel { ...@@ -956,7 +956,7 @@ Sources.SourcesPanel = class extends UI.Panel {
if (wasThrown || !result || result.type !== 'string') { if (wasThrown || !result || result.type !== 'string') {
failedToSave(result); failedToSave(result);
} else { } else {
SDK.ConsoleModel.evaluateCommandInConsole( SDK.consoleModel.evaluateCommandInConsole(
/** @type {!SDK.ExecutionContext} */ (currentExecutionContext), result.value, /** @type {!SDK.ExecutionContext} */ (currentExecutionContext), result.value,
/* useCommandLineAPI */ false); /* useCommandLineAPI */ false);
} }
...@@ -1268,7 +1268,7 @@ Sources.SourcesPanel.DebuggingActionDelegate = class { ...@@ -1268,7 +1268,7 @@ Sources.SourcesPanel.DebuggingActionDelegate = class {
var text = frame.textEditor.text(frame.textEditor.selection()); var text = frame.textEditor.text(frame.textEditor.selection());
var executionContext = UI.context.flavor(SDK.ExecutionContext); var executionContext = UI.context.flavor(SDK.ExecutionContext);
if (executionContext) if (executionContext)
SDK.ConsoleModel.evaluateCommandInConsole(executionContext, text, /* useCommandLineAPI */ true); SDK.consoleModel.evaluateCommandInConsole(executionContext, text, /* useCommandLineAPI */ true);
} }
return true; return true;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment