Commit a92ab3a5 authored by Peter Kasting's avatar Peter Kasting Committed by Commit Bot

Update comments on some tests to clarify their associated bugs.

Bug: 396347, 445155, 911949
TBR: kylixrd
Change-Id: I72d14d9cc3a80be89c039c654204fd0b38fb6dbc
Reviewed-on: https://chromium-review.googlesource.com/c/1413659Reviewed-by: default avatarPeter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622962}
parent 5e570f2e
...@@ -611,7 +611,6 @@ IN_PROC_BROWSER_TEST_F(BrowserTest, ClearPendingOnFailUnlessNTP) { ...@@ -611,7 +611,6 @@ IN_PROC_BROWSER_TEST_F(BrowserTest, ClearPendingOnFailUnlessNTP) {
// Test for crbug.com/297289. Ensure that modal dialogs are closed when a // Test for crbug.com/297289. Ensure that modal dialogs are closed when a
// cross-process navigation is ready to commit. // cross-process navigation is ready to commit.
// Flaky test, see https://crbug.com/445155.
IN_PROC_BROWSER_TEST_F(BrowserTest, CrossProcessNavCancelsDialogs) { IN_PROC_BROWSER_TEST_F(BrowserTest, CrossProcessNavCancelsDialogs) {
ASSERT_TRUE(embedded_test_server()->Start()); ASSERT_TRUE(embedded_test_server()->Start());
GURL url(embedded_test_server()->GetURL("/empty.html")); GURL url(embedded_test_server()->GetURL("/empty.html"));
...@@ -2316,7 +2315,6 @@ IN_PROC_BROWSER_TEST_F(ClickModifierTest, HrefControlClickTest) { ...@@ -2316,7 +2315,6 @@ IN_PROC_BROWSER_TEST_F(ClickModifierTest, HrefControlClickTest) {
// Control-shift-clicks open in a foreground tab. // Control-shift-clicks open in a foreground tab.
// On OSX meta [the command key] takes the place of control. // On OSX meta [the command key] takes the place of control.
// http://crbug.com/396347
IN_PROC_BROWSER_TEST_F(ClickModifierTest, HrefControlShiftClickTest) { IN_PROC_BROWSER_TEST_F(ClickModifierTest, HrefControlShiftClickTest) {
#if defined(OS_MACOSX) #if defined(OS_MACOSX)
int modifiers = blink::WebInputEvent::kMetaKey; int modifiers = blink::WebInputEvent::kMetaKey;
...@@ -2338,7 +2336,6 @@ IN_PROC_BROWSER_TEST_F(ClickModifierTest, HrefMiddleClickTest) { ...@@ -2338,7 +2336,6 @@ IN_PROC_BROWSER_TEST_F(ClickModifierTest, HrefMiddleClickTest) {
} }
// Shift-middle-clicks open in a foreground tab. // Shift-middle-clicks open in a foreground tab.
// http://crbug.com/396347
IN_PROC_BROWSER_TEST_F(ClickModifierTest, HrefShiftMiddleClickTest) { IN_PROC_BROWSER_TEST_F(ClickModifierTest, HrefShiftMiddleClickTest) {
int modifiers = blink::WebInputEvent::kShiftKey; int modifiers = blink::WebInputEvent::kShiftKey;
blink::WebMouseEvent::Button button = blink::WebMouseEvent::Button::kMiddle; blink::WebMouseEvent::Button button = blink::WebMouseEvent::Button::kMiddle;
......
...@@ -575,6 +575,7 @@ IN_PROC_BROWSER_TEST_F(TopControlsSlideControllerTest, TestScrollingPage) { ...@@ -575,6 +575,7 @@ IN_PROC_BROWSER_TEST_F(TopControlsSlideControllerTest, TestScrollingPage) {
TopChromeShownState::kFullyShown); TopChromeShownState::kFullyShown);
} }
// TODO(https://crbug.com/911949): Times out on CrOS on the waterfall.
IN_PROC_BROWSER_TEST_F(TopControlsSlideControllerTest, IN_PROC_BROWSER_TEST_F(TopControlsSlideControllerTest,
DISABLED_TestScrollingPageAndSwitchingToNTP) { DISABLED_TestScrollingPageAndSwitchingToNTP) {
ToggleTabletMode(); ToggleTabletMode();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment