Added New Tab feature in IPH

To implement the FeatureEngagementTracker for a New Tab feature,
code was added to include a kIPHNewTabFeature. This feature will
only be included in Windows.

Bug: 734176
Change-Id: I85764c5dd6373c0bfcda0bb4fe0fad1af5b1f02d
Reviewed-on: https://chromium-review.googlesource.com/538815
Commit-Queue: Catherine Chung <catherinechung@google.com>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480849}

components/feature_engagement_tracker/public/feature_constants.cc

@@ -23,4 +23,9 @@ const base::Feature kIPHDownloadHomeFeature{"IPH_DownloadHome",
                                             base::FEATURE_DISABLED_BY_DEFAULT};
 #endif  // OS_ANDROID
 
+#if defined(OS_WIN)
+const base::Feature kIPHNewTabFeature{"IPH_NewTab",
+                                      base::FEATURE_DISABLED_BY_DEFAULT};
+#endif  // OS_WIN
+
 }  // namespace feature_engagement_tracker

components/feature_engagement_tracker/public/feature_constants.h

@@ -26,6 +26,10 @@ extern const base::Feature kIPHDownloadPageFeature;
 extern const base::Feature kIPHDownloadHomeFeature;
 #endif  // OS_ANDROID
 
+#if defined(OS_WIN)
+extern const base::Feature kIPHNewTabFeature;
+#endif  // OS_WIN
+
 }  // namespace feature_engagement_tracker
 
 #endif  // COMPONENTS_FEATURE_ENGAGEMENT_TRACKER_PUBLIC_FEATURE_CONSTANTS_H_

components/feature_engagement_tracker/public/feature_list.cc

@@ -20,6 +20,9 @@ const base::Feature* kAllFeatures[] = {
     &kIPHDownloadPageFeature,
     &kIPHDownloadHomeFeature,
 #endif  // OS_ANDROID
+#if defined(OS_WIN)
+    &kIPHNewTabFeature,
+#endif  // OS_WIN
 };
 }  // namespace
 

components/feature_engagement_tracker/public/feature_list.h

@@ -50,6 +50,9 @@ DEFINE_VARIATION_PARAM(kIPHDataSaverDetailFeature, "IPH_DataSaverDetail");
 DEFINE_VARIATION_PARAM(kIPHDownloadPageFeature, "IPH_DownloadPage");
 DEFINE_VARIATION_PARAM(kIPHDownloadHomeFeature, "IPH_DownloadHome");
 #endif  // OS_ANDROID
+#if defined(OS_WIN)
+DEFINE_VARIATION_PARAM(kIPHNewTabFeature, "IPH_NewTab");
+#endif  // OS_WIN
 
 }  // namespace
 
@@ -63,9 +66,11 @@ constexpr flags_ui::FeatureEntry::FeatureVariation
         VARIATION_ENTRY(kIPHDataSaverDetailFeature),
         VARIATION_ENTRY(kIPHDownloadPageFeature),
         VARIATION_ENTRY(kIPHDownloadHomeFeature),
+#elif defined(OS_WIN)
+        VARIATION_ENTRY(kIPHNewTabFeature),
 #else
         VARIATION_ENTRY(kIPHDummyFeature),  // Ensures non-empty array.
-#endif  // OS_ANDROID
+#endif
 };
 
 #undef DEFINE_VARIATION_PARAM

tools/metrics/actions/actions.xml

@@ -5192,7 +5192,9 @@ should be able to be added at any place in this file.
 <action name="InProductHelp.NotifyEvent.IPH_DataSaverPreview">
   <owner>nyquist@chromium.org</owner>
   <owner>xingliu@chromium.org</owner>
-  <description>The user triggered an event in in-product help.</description>
+  <description>
+    A event related to the new tab in-product help experiment.
+  </description>
 </action>
 
 <action name="InProductHelp.NotifyEvent.IPH_DownloadHome">
@@ -5207,36 +5209,40 @@ should be able to be added at any place in this file.
   <description>The user triggered an event in in-product help.</description>
 </action>
 
+<action name="InProductHelp.NotifyEvent.IPH_NewTab">
+  <owner>nyquist@chromium.org</owner>
+  <owner>xingliu@chromium.org</owner>
+  <description>The user triggered an event in in-product help.</description>
+</action>
+
 <action name="InProductHelp.NotifyUsedEvent.IPH_DataSaverDetail">
   <owner>nyquist@chromium.org</owner>
   <owner>xingliu@chromium.org</owner>
-  <description>
-    The user triggered an used event in in-product help.
-  </description>
+  <description>The user triggered a used event in in-product help.</description>
 </action>
 
 <action name="InProductHelp.NotifyUsedEvent.IPH_DataSaverPreview">
   <owner>nyquist@chromium.org</owner>
   <owner>xingliu@chromium.org</owner>
-  <description>
-    The user triggered an used event in in-product help.
-  </description>
+  <description>The user triggered a used event in in-product help.</description>
 </action>
 
 <action name="InProductHelp.NotifyUsedEvent.IPH_DownloadHome">
   <owner>nyquist@chromium.org</owner>
   <owner>xingliu@chromium.org</owner>
-  <description>
-    The user triggered an used event in in-product help.
-  </description>
+  <description>The user triggered a used event in in-product help.</description>
 </action>
 
 <action name="InProductHelp.NotifyUsedEvent.IPH_DownloadPage">
   <owner>nyquist@chromium.org</owner>
   <owner>xingliu@chromium.org</owner>
-  <description>
-    The user triggered an used event in in-product help.
-  </description>
+  <description>The user triggered a used event in in-product help.</description>
+</action>
+
+<action name="InProductHelp.NotifyUsedEvent.IPH_NewTab">
+  <owner>nyquist@chromium.org</owner>
+  <owner>xingliu@chromium.org</owner>
+  <description>The user triggered a used event in in-product help.</description>
 </action>
 
 <action name="InProductHelp.ShouldTriggerHelpUI.IPH_DataSaverDetail">
@@ -5275,6 +5281,15 @@ should be able to be added at any place in this file.
   </description>
 </action>
 
+<action name="InProductHelp.ShouldTriggerHelpUI.IPH_NewTab">
+  <owner>nyquist@chromium.org</owner>
+  <owner>xingliu@chromium.org</owner>
+  <description>
+    The feature engagement tracker tried to determine whether in-product help
+    should be shown to the user.
+  </description>
+</action>
+
 <action name="Indent">
   <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
   <description>Please enter the description of this user action.</description>

tools/metrics/histograms/histograms.xml

@@ -89722,6 +89722,7 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
       label="In product help data saver detail."/>
   <suffix name="IPH_DownloadPage" label="In product help download page."/>
   <suffix name="IPH_DownloadHome" label="In product help download home."/>
+  <suffix name="IPH_NewTab" label="In product help new tab."/>
 </histogram_suffixes>
 
 <histogram_suffixes name="IPProtocolType" separator="_">