Commit a94c4586 authored by Ulan Degenbaev's avatar Ulan Degenbaev Committed by Chromium LUCI CQ

Disable reporting of global detached bytes

The global detached bytes include memory of unrelated frames and
extensions. We need to track per-frame detached bytes and only report
those in the same browsing context group.

Bug: 1085129
Change-Id: I3a562f0b3d898abe7508c46046cbd574db43173a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628987Reviewed-by: default avatarMichael Lippautz <mlippautz@chromium.org>
Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843479}
parent c808eb81
......@@ -210,10 +210,9 @@ MemoryMeasurement* ConvertResult(const WebMemoryMeasurementPtr& measurement) {
breakdown.push_back(ConvertBreakdown(entry));
}
// Add breakdowns for memory that isn't attributed to an execution context.
breakdown.push_back(
CreateUnattributedBreakdown(measurement->detached_memory, "Detached"));
breakdown.push_back(
CreateUnattributedBreakdown(measurement->shared_memory, "Shared"));
// TODO(1085129): Report memory usage of detached frames once implemented.
// Add an empty breakdown entry as required by the spec.
// See https://github.com/WICG/performance-measure-memory/issues/10.
breakdown.push_back(EmptyBreakdown());
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment