[ntp] Add flag to disable shortcuts

Makes shortcuts Finch-configurable. Flag is enabled by default.

Bug: 1166872
Change-Id: I24c1b5cf6a0fe192f580b5dca899480730d000ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633189
Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Esmael Elmoslimany <aee@chromium.org>
Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844321}

chrome/browser/resources/new_tab_page/app.html

@@ -262,10 +262,12 @@
   </ntp-realbox>
   <dom-if if="[[lazyRender_]]" on-dom-change="onLazyRendered_">
     <template>
-      <ntp-most-visited id="mostVisited" dark$="[[theme_.isDark]]"
-          use-white-add-icon$="[[theme_.shortcutUseWhiteAddIcon]]"
-          use-title-pill$="[[theme_.shortcutUseTitlePill]]">
-      </ntp-most-visited>
+      <template is="dom-if" if="[[shortcutsEnabled_]]">
+        <ntp-most-visited id="mostVisited" dark$="[[theme_.isDark]]"
+            use-white-add-icon$="[[theme_.shortcutUseWhiteAddIcon]]"
+            use-title-pill$="[[theme_.shortcutUseTitlePill]]">
+        </ntp-most-visited>
+      </template>
       <ntp-middle-slot-promo
           on-ntp-middle-slot-promo-loaded="onMiddleSlotPromoLoaded_">
       </ntp-middle-slot-promo>

chrome/browser/resources/new_tab_page/app.js

@@ -197,6 +197,12 @@ class AppElement extends PolymerElement {
         computed: 'computeRealboxShown_(theme_)',
       },
 
+      /** @private */
+      shortcutsEnabled_: {
+        type: Boolean,
+        value: () => loadTimeData.getBoolean('shortcutsEnabled'),
+      },
+
       /** @private */
       modulesEnabled_: {
         type: Boolean,

chrome/browser/resources/new_tab_page/customize_dialog.html

@@ -214,7 +214,8 @@
               <div id="backgroundsIcon" class="menu-item-icon"></div>
               $i18n{backgroundsMenuItem}
             </div>
-            <div class="menu-item" page-name="shortcuts" tabindex="0">
+            <div class="menu-item" page-name="shortcuts" tabindex="0"
+                hidden$="[[!shortcutsEnabled_]]">
               <div id="shortcutsIcon" class="menu-item-icon"></div>
               $i18n{shortcutsMenuItem}
             </div>

chrome/browser/resources/new_tab_page/customize_dialog.js

@@ -75,6 +75,12 @@ class CustomizeDialogElement extends PolymerElement {
             backgroundSelection)`,
       },
 
+      /** @private */
+      shortcutsEnabled_: {
+        type: Boolean,
+        value: () => loadTimeData.getBoolean('shortcutsEnabled'),
+      },
+
       /** @private */
       modulesEnabled_: {
         type: Boolean,

chrome/browser/ui/webui/new_tab_page/new_tab_page_ui.cc

@@ -98,6 +98,8 @@ content::WebUIDataSource* CreateNewTabPageUiHtmlSource(Profile* profile) {
   source->AddBoolean(
       "themeModeDoodlesEnabled",
       base::FeatureList::IsEnabled(ntp_features::kWebUIThemeModeDoodles));
+  source->AddBoolean("shortcutsEnabled",
+                     base::FeatureList::IsEnabled(ntp_features::kNtpShortcuts));
   source->AddBoolean("modulesEnabled",
                      base::FeatureList::IsEnabled(ntp_features::kModules));
   source->AddInteger("modulesLoadTimeout",

components/search/ntp_features.cc

@@ -75,6 +75,10 @@ const base::Feature kWebUI{"NtpWebUI", base::FEATURE_ENABLED_BY_DEFAULT};
 const base::Feature kWebUIThemeModeDoodles{"WebUIThemeModeDoodles",
                                            base::FEATURE_ENABLED_BY_DEFAULT};
 
+// If enabled, shortcuts will be shown.
+const base::Feature kNtpShortcuts{"NtpShortcuts",
+                                  base::FEATURE_ENABLED_BY_DEFAULT};
+
 // If enabled, modules will be shown.
 const base::Feature kModules{"NtpModules", base::FEATURE_DISABLED_BY_DEFAULT};
 

components/search/ntp_features.h

@@ -26,6 +26,7 @@ extern const base::Feature kRealboxMatchOmniboxTheme;
 extern const base::Feature kRealboxUseGoogleGIcon;
 extern const base::Feature kWebUI;
 extern const base::Feature kWebUIThemeModeDoodles;
+extern const base::Feature kNtpShortcuts;
 extern const base::Feature kModules;
 extern const base::Feature kNtpRecipeTasksModule;
 extern const base::Feature kNtpShoppingTasksModule;