Remove omnibox suggestions from view tree when hidden.

This ensures we aren't running deferred runnables and reacting
to the omnibox positioning when the omnibox isn't focused.

BUG=512087,444670

Change-Id: Ie353c94caf9bbf753ea2c55dbb7974df78bcc9e4
Reviewed-on: https://chromium-review.googlesource.com/1091505Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565403}

chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java

@@ -1358,7 +1358,6 @@ public class LocationBarLayout
 
         // Ensure the results container is initialized and add the suggestion list to it.
         initOmniboxResultsContainer();
-        mOmniboxResultsContainer.addView(mSuggestionList);
 
         // Start with visibility GONE to ensure that show() is called. http://crbug.com/517438
         mSuggestionList.setVisibility(GONE);
@@ -1453,9 +1452,11 @@ public class LocationBarLayout
             final boolean isShowing = mSuggestionList.isShown();
             if (visible && !isShowing) {
                 mIgnoreOmniboxItemSelection = true; // Reset to default value.
+                mOmniboxResultsContainer.addView(mSuggestionList);
                 mSuggestionList.show();
             } else if (!visible && isShowing) {
                 mSuggestionList.setVisibility(GONE);
+                mOmniboxResultsContainer.removeView(mSuggestionList);
             }
         }
         maybeShowOmniboxResultsContainer();

chrome/android/java/src/org/chromium/chrome/browser/omnibox/SuggestionView.java

@@ -1099,6 +1099,7 @@ class SuggestionView extends ViewGroup {
 
         @Override
         protected void onDetachedFromWindow() {
+            removeCallbacks(mRelayoutRunnable);
             if (mNavigationButton != null) mNavigationButton.removeOnLayoutChangeListener(this);
             if (mUrlBar != null) mUrlBar.removeOnLayoutChangeListener(this);
             if (mLocationBar != null) {