Commit a977d165 authored by Tatiana Buldina's avatar Tatiana Buldina Committed by Commit Bot

[ChromeDriver] Add negative filter for specific os and version

Bug: chromedriver:1408
Change-Id: Ia317f5e00e2b55092c2423f836eb5d04debfedb2
Reviewed-on: https://chromium-review.googlesource.com/1258086Reviewed-by: default avatarJohn Chen <johnchen@chromium.org>
Commit-Queue: Tatiana Buldina <buldina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596286}
parent 5a2a07e4
...@@ -108,8 +108,6 @@ _VERSION_SPECIFIC_FILTER['70'] = [ ...@@ -108,8 +108,6 @@ _VERSION_SPECIFIC_FILTER['70'] = [
] ]
_VERSION_SPECIFIC_FILTER['69'] = [ _VERSION_SPECIFIC_FILTER['69'] = [
# https://bugs.chromium.org/p/chromedriver/issues/detail?id=1945
'ChromeDriverTest.testWindowFullScreen',
# https://bugs.chromium.org/p/chromedriver/issues/detail?id=2515 # https://bugs.chromium.org/p/chromedriver/issues/detail?id=2515
'HeadlessInvalidCertificateTest.*', 'HeadlessInvalidCertificateTest.*',
# Feature not yet supported in this version # Feature not yet supported in this version
...@@ -117,8 +115,6 @@ _VERSION_SPECIFIC_FILTER['69'] = [ ...@@ -117,8 +115,6 @@ _VERSION_SPECIFIC_FILTER['69'] = [
] ]
_VERSION_SPECIFIC_FILTER['68'] = [ _VERSION_SPECIFIC_FILTER['68'] = [
# https://bugs.chromium.org/p/chromedriver/issues/detail?id=1945
'ChromeDriverTest.testWindowFullScreen',
# Feature not yet supported in this version # Feature not yet supported in this version
'ChromeDriverTest.testGenerateTestReport', 'ChromeDriverTest.testGenerateTestReport',
] ]
...@@ -141,6 +137,16 @@ _OS_SPECIFIC_FILTER['mac'] = [ ...@@ -141,6 +137,16 @@ _OS_SPECIFIC_FILTER['mac'] = [
'ChromeDriverTest.testWindowMaximize', 'ChromeDriverTest.testWindowMaximize',
] ]
_OS_VERSION_SPECIFIC_FILTER = {}
_OS_VERSION_SPECIFIC_FILTER['mac', '68'] = [
# https://bugs.chromium.org/p/chromedriver/issues/detail?id=1945
'ChromeDriverTest.testWindowFullScreen',
]
_OS_VERSION_SPECIFIC_FILTER['mac', '69'] = [
# https://bugs.chromium.org/p/chromedriver/issues/detail?id=1945
'ChromeDriverTest.testWindowFullScreen',
]
_DESKTOP_NEGATIVE_FILTER = [ _DESKTOP_NEGATIVE_FILTER = [
# Desktop doesn't support touch (without --touch-events). # Desktop doesn't support touch (without --touch-events).
'ChromeDriverTest.testTouchSingleTapElement', 'ChromeDriverTest.testTouchSingleTapElement',
...@@ -190,6 +196,8 @@ _INTEGRATION_NEGATIVE_FILTER = [ ...@@ -190,6 +196,8 @@ _INTEGRATION_NEGATIVE_FILTER = [
def _GetDesktopNegativeFilter(version_name): def _GetDesktopNegativeFilter(version_name):
filter = _NEGATIVE_FILTER + _DESKTOP_NEGATIVE_FILTER filter = _NEGATIVE_FILTER + _DESKTOP_NEGATIVE_FILTER
os = util.GetPlatformName() os = util.GetPlatformName()
if (os, version_name) in _OS_VERSION_SPECIFIC_FILTER:
filter += _OS_VERSION_SPECIFIC_FILTER[os, version_name]
if os in _OS_SPECIFIC_FILTER: if os in _OS_SPECIFIC_FILTER:
filter += _OS_SPECIFIC_FILTER[os] filter += _OS_SPECIFIC_FILTER[os]
if version_name in _VERSION_SPECIFIC_FILTER: if version_name in _VERSION_SPECIFIC_FILTER:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment