Commit a9ba1bff authored by tasak@google.com's avatar tasak@google.com

Removed v8::Isolate::GetCurrent() and fixed toV8 with empty context.

BUG=369451

Review URL: https://codereview.chromium.org/302973003

git-svn-id: svn://svn.chromium.org/blink/trunk@175279 bbb929c8-8fbe-4397-9dbb-9b2b20218538
parent 8072ca01
......@@ -46,6 +46,13 @@ v8::Handle<v8::Value> WebArrayBufferConverter::toV8Value(WebArrayBuffer* buffer)
return toV8(*buffer, v8::Handle<v8::Object>(), v8::Isolate::GetCurrent());
}
v8::Handle<v8::Value> WebArrayBufferConverter::toV8Value(WebArrayBuffer* buffer, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
{
if (!buffer)
return v8::Handle<v8::Value>();
return toV8(*buffer, creationContext, isolate);
}
WebArrayBuffer* WebArrayBufferConverter::createFromV8Value(v8::Handle<v8::Value> value)
{
if (!V8ArrayBuffer::hasInstance(value, v8::Isolate::GetCurrent()))
......@@ -54,5 +61,13 @@ WebArrayBuffer* WebArrayBufferConverter::createFromV8Value(v8::Handle<v8::Value>
return new WebArrayBuffer(buffer);
}
WebArrayBuffer* WebArrayBufferConverter::createFromV8Value(v8::Handle<v8::Value> value, v8::Isolate* isolate)
{
if (!V8ArrayBuffer::hasInstance(value, isolate))
return 0;
WTF::ArrayBuffer* buffer = V8ArrayBuffer::toNative(value->ToObject());
return new WebArrayBuffer(buffer);
}
} // namespace blink
......@@ -34,6 +34,8 @@
#include "public/platform/WebArrayBuffer.h"
namespace v8 {
class Isolate;
class Object;
class Value;
template <class T> class Handle;
}
......@@ -42,8 +44,12 @@ namespace blink {
class WebArrayBufferConverter {
public:
// FIXME: remove these two APIs which doesn't take either context or
// isolate as their parameters after the embedder side is fixed.
BLINK_EXPORT static v8::Handle<v8::Value> toV8Value(WebArrayBuffer*);
BLINK_EXPORT static WebArrayBuffer* createFromV8Value(v8::Handle<v8::Value>);
BLINK_EXPORT static v8::Handle<v8::Value> toV8Value(WebArrayBuffer*, v8::Handle<v8::Object>, v8::Isolate*);
BLINK_EXPORT static WebArrayBuffer* createFromV8Value(v8::Handle<v8::Value>, v8::Isolate*);
};
} // namespace blink
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment