Commit a9f3bfea authored by Manish Jethani's avatar Manish Jethani Committed by Commit Bot

Use std::find_if to find style sheet by key

Instead of a for loop we use std::find_if with a lambda, which makes the
code easier to follow.

BUG=608854

Change-Id: Ib08efabfb8d0d21da4d3397b4fb27406fe096dc1
Reviewed-on: https://chromium-review.googlesource.com/923348Reviewed-by: default avatarRune Lillesveen <futhark@chromium.org>
Commit-Queue: Manish Jethani <m.jethani@eyeo.com>
Cr-Commit-Position: refs/heads/master@{#537649}
parent cc4adb3c
...@@ -162,16 +162,18 @@ void StyleEngine::RemoveInjectedSheet(const StyleSheetKey& key, ...@@ -162,16 +162,18 @@ void StyleEngine::RemoveInjectedSheet(const StyleSheetKey& key,
injected_style_sheets = origin == WebDocument::kUserOrigin injected_style_sheets = origin == WebDocument::kUserOrigin
? injected_user_style_sheets_ ? injected_user_style_sheets_
: injected_author_style_sheets_; : injected_author_style_sheets_;
for (auto it = injected_style_sheets.rbegin(); // Remove the last sheet that matches.
it != injected_style_sheets.rend(); it++) { const auto& it = std::find_if(injected_style_sheets.rbegin(),
if (it->first == key) { injected_style_sheets.rend(),
injected_style_sheets.erase(std::next(it).base()); [&key](const auto& item) {
if (origin == WebDocument::kUserOrigin) return item.first == key;
MarkUserStyleDirty(); });
else if (it != injected_style_sheets.rend()) {
MarkDocumentDirty(); injected_style_sheets.erase(std::next(it).base());
break; if (origin == WebDocument::kUserOrigin)
} MarkUserStyleDirty();
else
MarkDocumentDirty();
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment