Commit aa074b74 authored by Ambre Williams's avatar Ambre Williams Committed by Commit Bot

[fuchsia] Use /data as DIR_CAST_HOME

There's no concept of home directory on Fuchsia. base::GetHomeDir()
resolves to /tmp, which is not an appropriate place for mutable
persistent data. Use /data (sandboxed persistent storage) as
DIR_CAST_HOME instead.

Bug: None
Change-Id: I7758bc5ba1ad6ccf9f4d4d1a87c098d2f093d7f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120414Reviewed-by: default avatarMichael Spang <spang@chromium.org>
Reviewed-by: default avatarBenjamin Lerman <qsr@chromium.org>
Commit-Queue: Ambre Williams <ambre@google.com>
Cr-Commit-Position: refs/heads/master@{#753962}
parent 78ac18cb
......@@ -18,7 +18,13 @@ namespace chromecast {
bool PathProvider(int key, base::FilePath* result) {
switch (key) {
case DIR_CAST_HOME: {
#if defined(OS_FUCHSIA)
// On Fuchsia, use the component's local /data directory.
base::FilePath home;
CHECK(base::PathService::Get(base::DIR_APP_DATA, &home));
#else
base::FilePath home = base::GetHomeDir();
#endif
#if BUILDFLAG(IS_CAST_DESKTOP_BUILD)
// When running a development instance as a regular user, use
// a data directory under $HOME (similar to Chrome).
......@@ -43,9 +49,6 @@ bool PathProvider(int key, base::FilePath* result) {
#if defined(OS_ANDROID)
CHECK(base::PathService::Get(base::DIR_ANDROID_APP_DATA, &data_dir));
*result = data_dir.Append("cast_shell.conf");
#elif defined(OS_FUCHSIA)
CHECK(base::PathService::Get(base::DIR_APP_DATA, &data_dir));
*result = data_dir.Append(".eureka.conf");
#else
CHECK(base::PathService::Get(DIR_CAST_HOME, &data_dir));
*result = data_dir.Append(".eureka.conf");
......@@ -57,9 +60,6 @@ bool PathProvider(int key, base::FilePath* result) {
#if defined(OS_ANDROID)
CHECK(base::PathService::Get(base::DIR_ANDROID_APP_DATA, &data_dir));
*result = data_dir.Append("cast_shell.crl");
#elif defined(OS_FUCHSIA)
CHECK(base::PathService::Get(base::DIR_APP_DATA, &data_dir));
*result = data_dir.Append(".eureka.crl");
#else
CHECK(base::PathService::Get(DIR_CAST_HOME, &data_dir));
*result = data_dir.Append(".eureka.crl");
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment