Commit aa165da6 authored by Devlin Cronin's avatar Devlin Cronin Committed by Commit Bot

[Sheriff] Disable flaky test ProcessTests

Disable ProcessTest.SetProcessBackgroundedSelf and
ProcessTest.SetProcessBackgrounded on Windows.

Bug: 931721
TBR=fdoray@chromium.org

Change-Id: Ie5b2882c1d9d39ba5527d610c2a56223e01e74ed
Reviewed-on: https://chromium-review.googlesource.com/c/1470996Reviewed-by: default avatarDevlin <rdevlin.cronin@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631862}
parent 30018ef9
......@@ -271,7 +271,13 @@ TEST_F(ProcessTest, WaitForExitWithTimeout) {
// backgrounding and restoring.
// Note: a platform may not be willing or able to lower the priority of
// a process. The calls to SetProcessBackground should be noops then.
TEST_F(ProcessTest, SetProcessBackgrounded) {
// Flaky on Windows: https://crbug.com/931721.
#if defined(OS_WIN)
#define MAYBE_SetProcessBackgrounded DISABLED_SetProcessBackgrounded
#else
#define MAYBE_SetProcessBackgrounded SetProcessBackgrounded
#endif
TEST_F(ProcessTest, MAYBE_SetProcessBackgrounded) {
if (!Process::CanBackgroundProcesses())
return;
Process process(SpawnChild("SimpleChildProcess"));
......@@ -299,9 +305,15 @@ TEST_F(ProcessTest, SetProcessBackgrounded) {
EXPECT_EQ(old_priority, new_priority);
}
// Flaky on Windows: https://crbug.com/931721.
#if defined(OS_WIN)
#define MAYBE_SetProcessBackgroundedSelf DISABLED_SetProcessBackgroundedSelf
#else
#define MAYBE_SetProcessBackgroundedSelf SetProcessBackgroundedSelf
#endif
// Same as SetProcessBackgrounded but to this very process. It uses
// a different code path at least for Windows.
TEST_F(ProcessTest, SetProcessBackgroundedSelf) {
TEST_F(ProcessTest, MAYBE_SetProcessBackgroundedSelf) {
if (!Process::CanBackgroundProcesses())
return;
Process process = Process::Current();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment