[iOS] Removing calls to IsUIRefreshPhase1Enabled() for Sign in promo

Removing calls to IsUIRefreshPhase1Enabled() for Sign in promo.

Bug: 884724
Change-Id: I8417859a633484a1ff46ac440eacb02558ea661f
Reviewed-on: https://chromium-review.googlesource.com/c/1317859
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605396}

ios/chrome/browser/ui/authentication/BUILD.gn

@@ -59,13 +59,11 @@ source_set("authentication") {
     "//ios/chrome/browser/ui/commands",
     "//ios/chrome/browser/ui/material_components",
     "//ios/chrome/browser/ui/signin_interaction/public",
-    "//ios/chrome/browser/ui/util",
     "//ios/chrome/browser/unified_consent",
     "//ios/chrome/common",
     "//ios/public/provider/chrome/browser",
     "//ios/public/provider/chrome/browser/images",
     "//ios/public/provider/chrome/browser/signin",
-    "//ios/third_party/material_components_ios",
     "//services/identity/public/cpp:cpp",
     "//ui/base",
     "//ui/gfx",
@@ -170,7 +168,6 @@ source_set("unit_tests") {
     "//ios/chrome/browser/unified_consent",
     "//ios/chrome/test:test_support",
     "//ios/public/provider/chrome/browser/signin:test_support",
-    "//ios/third_party/material_components_ios",
     "//ios/web/public/test",
     "//testing/gtest",
     "//third_party/ocmock",

ios/chrome/browser/ui/authentication/signin_promo_item.mm

@@ -61,9 +61,7 @@ const CGFloat kSignInPromoViewPadding = 10;
   self = [super initWithFrame:frame];
   if (self) {
     UIView* contentView = self.contentView;
-    _signinPromoView =
-        [[SigninPromoView alloc] initWithFrame:self.bounds
-                                         style:SigninPromoViewUIRefresh];
+    _signinPromoView = [[SigninPromoView alloc] initWithFrame:self.bounds];
     _signinPromoView.translatesAutoresizingMaskIntoConstraints = NO;
     [contentView addSubview:_signinPromoView];
 

ios/chrome/browser/ui/authentication/signin_promo_view.h

@@ -9,18 +9,8 @@
 
 #include "components/signin/core/browser/signin_metrics.h"
 
-@class MDCFlatButton;
 @protocol SigninPromoViewDelegate;
 
-typedef NS_ENUM(NSInteger, SigninPromoViewUI) {
-  // The legacy SigninPromoViewUI style.
-  SigninPromoViewUILegacy,
-  // The SigninPromoViewRefreshUI style. In order for this value to take effect
-  // the UIRefreshPhase1 flag also needs to be enabled. Otherwise
-  // SigninPromoViewUILegacy style will still be used.
-  SigninPromoViewUIRefresh,
-};
-
 typedef NS_ENUM(NSInteger, SigninPromoViewMode) {
   // No identity available on the device.
   SigninPromoViewModeColdState,
@@ -62,12 +52,8 @@ extern NSString* const kSigninPromoCloseButtonId;
 // |textLabel|.
 @property(nonatomic, readonly) CGFloat horizontalPadding;
 
-// Designated initializer. |signinPromoViewUI| sets the style for the
-// SigninPromoView to legacy or refreshed. This same view is used on Collections
-// and Settings, while the Collections UI will be refreshed soon, we still need
-// to support the legacy UI for settings.
+// Designated initializer.
 - (instancetype)initWithFrame:(CGRect)frame
-                        style:(SigninPromoViewUI)signinPromoViewUI
     NS_DESIGNATED_INITIALIZER;
 - (instancetype)initWithFrame:(CGRect)frame NS_UNAVAILABLE;
 - (instancetype)initWithCoder:(NSCoder*)aDecoder NS_UNAVAILABLE;

ios/chrome/browser/ui/authentication/signin_promo_view_unittest.mm

@@ -17,8 +17,7 @@ using SigninPromoViewTest = PlatformTest;
 TEST_F(SigninPromoViewTest, ChromiumLogoImage) {
   UIWindow* currentWindow = [[UIApplication sharedApplication] keyWindow];
   SigninPromoView* view =
-      [[SigninPromoView alloc] initWithFrame:CGRectMake(0, 0, 100, 100)
-                                       style:SigninPromoViewUIRefresh];
+      [[SigninPromoView alloc] initWithFrame:CGRectMake(0, 0, 100, 100)];
   view.mode = SigninPromoViewModeColdState;
   [currentWindow.rootViewController.view addSubview:view];
   UIImage* chromiumLogo = view.imageView.image;
@@ -37,8 +36,7 @@ TEST_F(SigninPromoViewTest, ChromiumLogoImage) {
 TEST_F(SigninPromoViewTest, SecondaryButtonVisibility) {
   UIWindow* currentWindow = [[UIApplication sharedApplication] keyWindow];
   SigninPromoView* view =
-      [[SigninPromoView alloc] initWithFrame:CGRectMake(0, 0, 100, 100)
-                                       style:SigninPromoViewUIRefresh];
+      [[SigninPromoView alloc] initWithFrame:CGRectMake(0, 0, 100, 100)];
   view.mode = SigninPromoViewModeColdState;
   [currentWindow.rootViewController.view addSubview:view];
   EXPECT_TRUE(view.secondaryButton.hidden);

ios/chrome/browser/ui/bookmarks/cells/bookmark_table_signin_promo_cell.mm

@@ -35,9 +35,7 @@ const NSInteger kSigninPromoMargin = 8;
   self = [super initWithStyle:style reuseIdentifier:reuseIdentifier];
   if (self) {
     UIView* contentView = self.contentView;
-    _signinPromoView =
-        [[SigninPromoView alloc] initWithFrame:self.bounds
-                                         style:SigninPromoViewUIRefresh];
+    _signinPromoView = [[SigninPromoView alloc] initWithFrame:self.bounds];
     _signinPromoView.translatesAutoresizingMaskIntoConstraints = NO;
     [contentView addSubview:_signinPromoView];
     NSArray* visualConstraints = @[

ios/chrome/browser/ui/table_view/cells/table_view_signin_promo_item.mm

@@ -58,8 +58,7 @@ const CGFloat kMargin = 16;
   self = [super initWithStyle:style reuseIdentifier:reuseIdentifier];
   if (self) {
     SigninPromoView* signinPromoView =
-        [[SigninPromoView alloc] initWithFrame:CGRectZero
-                                         style:SigninPromoViewUIRefresh];
+        [[SigninPromoView alloc] initWithFrame:CGRectZero];
     self.signinPromoView = signinPromoView;
     self.signinPromoView.translatesAutoresizingMaskIntoConstraints = NO;
     [self.contentView addSubview:self.signinPromoView];