Commit aa4a4e5d authored by Fredrik Söderquist's avatar Fredrik Söderquist Committed by Commit Bot

Remove SVGElementRareData::owner_

This appears to have been dead/unused since the complicated weak
handling for SVGCursorElement was removed in
https://codereview.chromium.org/2522443002 (together with
SVGCursorElement itself.)

Simplify SVGElement::EnsureSVGRareData a little while at it.

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I0e29e2830bc20fd595d41d72eb9c3ec23c2df2ce
Reviewed-on: https://chromium-review.googlesource.com/843023Reviewed-by: default avatarKentaro Hara <haraken@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#526071}
parent cf785f19
...@@ -119,10 +119,8 @@ void SVGElement::BuildPendingResourcesIfNeeded() { ...@@ -119,10 +119,8 @@ void SVGElement::BuildPendingResourcesIfNeeded() {
} }
SVGElementRareData* SVGElement::EnsureSVGRareData() { SVGElementRareData* SVGElement::EnsureSVGRareData() {
if (HasSVGRareData()) if (!svg_rare_data_)
return SvgRareData(); svg_rare_data_ = new SVGElementRareData();
svg_rare_data_ = new SVGElementRareData(this);
return svg_rare_data_.Get(); return svg_rare_data_.Get();
} }
......
...@@ -45,7 +45,6 @@ void SVGElementRareData::Trace(blink::Visitor* visitor) { ...@@ -45,7 +45,6 @@ void SVGElementRareData::Trace(blink::Visitor* visitor) {
visitor->Trace(animated_smil_style_properties_); visitor->Trace(animated_smil_style_properties_);
visitor->Trace(element_instances_); visitor->Trace(element_instances_);
visitor->Trace(corresponding_element_); visitor->Trace(corresponding_element_);
visitor->Trace(owner_);
} }
AffineTransform* SVGElementRareData::AnimateMotionTransform() { AffineTransform* SVGElementRareData::AnimateMotionTransform() {
......
...@@ -34,9 +34,8 @@ class SVGElementProxySet; ...@@ -34,9 +34,8 @@ class SVGElementProxySet;
class SVGElementRareData class SVGElementRareData
: public GarbageCollectedFinalized<SVGElementRareData> { : public GarbageCollectedFinalized<SVGElementRareData> {
public: public:
SVGElementRareData(SVGElement* owner) SVGElementRareData()
: owner_(owner), : corresponding_element_(nullptr),
corresponding_element_(nullptr),
instances_updates_blocked_(false), instances_updates_blocked_(false),
use_override_computed_style_(false), use_override_computed_style_(false),
needs_override_computed_style_update_(false), needs_override_computed_style_update_(false),
...@@ -103,7 +102,6 @@ class SVGElementRareData ...@@ -103,7 +102,6 @@ class SVGElementRareData
void Trace(blink::Visitor*); void Trace(blink::Visitor*);
private: private:
Member<SVGElement> owner_;
SVGElementSet outgoing_references_; SVGElementSet outgoing_references_;
SVGElementSet incoming_references_; SVGElementSet incoming_references_;
HeapHashSet<WeakMember<SVGElement>> element_instances_; HeapHashSet<WeakMember<SVGElement>> element_instances_;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment