Commit aa5a6b60 authored by Evan Stade's avatar Evan Stade Committed by Commit Bot

Re-enable two OmniboxApiTests

Probably fixed by 88094724 but the
tests were never re-enabled. See bug for history.

Bug: 1029568
Change-Id: Iffb9e629c30db1e78be7ab9100e0551f43f7eac0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026190
Commit-Queue: Evan Stade <estade@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Auto-Submit: Evan Stade <estade@chromium.org>
Reviewed-by: default avatarDevlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736132}
parent 2299848d
...@@ -206,8 +206,8 @@ IN_PROC_BROWSER_TEST_F(OmniboxApiTest, DISABLED_Basic) { ...@@ -206,8 +206,8 @@ IN_PROC_BROWSER_TEST_F(OmniboxApiTest, DISABLED_Basic) {
} }
*/ */
} }
// Test is flaky: https://crbug.com/1029568
IN_PROC_BROWSER_TEST_F(OmniboxApiTest, DISABLED_OnInputEntered) { IN_PROC_BROWSER_TEST_F(OmniboxApiTest, OnInputEntered) {
ASSERT_TRUE(RunExtensionTest("omnibox")) << message_; ASSERT_TRUE(RunExtensionTest("omnibox")) << message_;
Profile* profile = browser()->profile(); Profile* profile = browser()->profile();
search_test_utils::WaitForTemplateURLServiceToLoad( search_test_utils::WaitForTemplateURLServiceToLoad(
...@@ -443,9 +443,7 @@ IN_PROC_BROWSER_TEST_F(OmniboxApiTest, MAYBE_DeleteOmniboxSuggestionResult) { ...@@ -443,9 +443,7 @@ IN_PROC_BROWSER_TEST_F(OmniboxApiTest, MAYBE_DeleteOmniboxSuggestionResult) {
} }
// Tests typing something but not staying in keyword mode. // Tests typing something but not staying in keyword mode.
// Test is flaky. crbug.com/1030219 IN_PROC_BROWSER_TEST_F(OmniboxApiTest, ExtensionSuggestionsOnlyInKeywordMode) {
IN_PROC_BROWSER_TEST_F(OmniboxApiTest,
DISABLED_ExtensionSuggestionsOnlyInKeywordMode) {
ASSERT_TRUE(RunExtensionTest("omnibox")) << message_; ASSERT_TRUE(RunExtensionTest("omnibox")) << message_;
// The results depend on the TemplateURLService being loaded. Make sure it is // The results depend on the TemplateURLService being loaded. Make sure it is
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment