Commit aa663ca4 authored by Aran Gilman's avatar Aran Gilman Committed by Commit Bot

Forward column index attribute for rows as well as cells & headers.

Bug: 832289
Change-Id: If82589e3e690fbf31b8806182e61568d8263119f
Reviewed-on: https://chromium-review.googlesource.com/c/1368945Reviewed-by: default avatarDominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: default avatarKinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Aran Gilman <gilmanmh@google.com>
Cr-Commit-Position: refs/heads/master@{#615561}
parent 41ab8b8c
...@@ -846,20 +846,21 @@ void BlinkAXTreeSource::SerializeNode(WebAXObject src, ...@@ -846,20 +846,21 @@ void BlinkAXTreeSource::SerializeNode(WebAXObject src,
src.CellRowIndex()); src.CellRowIndex());
dst->AddIntAttribute(ax::mojom::IntAttribute::kTableCellRowSpan, dst->AddIntAttribute(ax::mojom::IntAttribute::kTableCellRowSpan,
src.CellRowSpan()); src.CellRowSpan());
int aria_colindex = src.AriaColumnIndex();
if (aria_colindex) {
dst->AddIntAttribute(ax::mojom::IntAttribute::kAriaCellColumnIndex,
aria_colindex);
}
} }
if (ui::IsCellOrTableHeader(dst->role) || ui::IsTableRow(dst->role)) { if (ui::IsCellOrTableHeader(dst->role) || ui::IsTableRow(dst->role)) {
// aria-rowindex is supported on cells, headers and rows. // aria-rowindex and aria-colindex are supported on cells, headers and
// rows.
int aria_rowindex = src.AriaRowIndex(); int aria_rowindex = src.AriaRowIndex();
if (aria_rowindex) if (aria_rowindex)
dst->AddIntAttribute(ax::mojom::IntAttribute::kAriaCellRowIndex, dst->AddIntAttribute(ax::mojom::IntAttribute::kAriaCellRowIndex,
aria_rowindex); aria_rowindex);
int aria_colindex = src.AriaColumnIndex();
if (aria_colindex) {
dst->AddIntAttribute(ax::mojom::IntAttribute::kAriaCellColumnIndex,
aria_colindex);
}
} }
if (ui::IsTableHeader(dst->role) && if (ui::IsTableHeader(dst->role) &&
......
...@@ -1096,7 +1096,7 @@ unsigned WebAXObject::AriaColumnIndex() const { ...@@ -1096,7 +1096,7 @@ unsigned WebAXObject::AriaColumnIndex() const {
if (IsDetached()) if (IsDetached())
return 0; return 0;
return private_->IsTableCellLikeRole() ? private_->AriaColumnIndex() : 0; return private_->AriaColumnIndex();
} }
int WebAXObject::AriaRowCount() const { int WebAXObject::AriaRowCount() const {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment