Commit aa6f05df authored by Hajime Hoshi's avatar Hajime Hoshi Committed by Commit Bot

Remove TaskType::kUnthrottled

Now LocalDOMWindow::event_queue_ is no longer used by IndexedDB, the
task type doesn't have to be 'kUnthrottled'. This was the last one usage
of kUnthrottled and we can remove this now.

Bug: 836410, 846618
Change-Id: Ifb5913d93a36cc6f8a5f645c6ecbf0016e424ad4
Reviewed-on: https://chromium-review.googlesource.com/1092225Reviewed-by: default avatarKentaro Hara <haraken@chromium.org>
Reviewed-by: default avatarAlexander Timin <altimin@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565611}
parent 48af825a
......@@ -187,14 +187,6 @@ enum class TaskType : unsigned {
kWorkerThreadTaskQueueV8 = 47,
kWorkerThreadTaskQueueCompositor = 48,
///////////////////////////////////////
// The following task types are DEPRECATED! Use kInternal* instead.
///////////////////////////////////////
// Tasks that must not be throttled should be posted here, but the usage
// should be very limited.
kUnthrottled = 25,
kCount = 49,
};
......
......@@ -317,13 +317,10 @@ Document* LocalDOMWindow::InstallNewDocument(const String& mime_type,
document_ = CreateDocument(mime_type, init, force_xhtml);
// This queue is unthrottled because throttling IndexedDB events may break
// scenarios where several tabs, some of which are backgrounded, access
// the same database concurrently.
// TODO(hajimehoshi): Task type should be determined by a posted event instead
// of specifying here.
event_queue_ =
EventQueueImpl::Create(document_.Get(), TaskType::kUnthrottled);
EventQueueImpl::Create(document_.Get(), TaskType::kInternalDefault);
document_->Initialize();
if (!GetFrame())
......
......@@ -31,8 +31,7 @@ ParentExecutionContextTaskRunners::ParentExecutionContextTaskRunners(
for (auto type : {TaskType::kNetworking, TaskType::kPostedMessage,
TaskType::kInternalDefault, TaskType::kInternalLoading,
TaskType::kInternalTest, TaskType::kInternalMedia,
TaskType::kInternalInspector, TaskType::kInternalWorker,
TaskType::kUnthrottled}) {
TaskType::kInternalInspector, TaskType::kInternalWorker}) {
auto task_runner =
context ? context->GetTaskRunner(type)
: Platform::Current()->CurrentThread()->GetTaskRunner();
......
......@@ -320,7 +320,6 @@ scoped_refptr<base::SingleThreadTaskRunner> FrameSchedulerImpl::GetTaskRunner(
case TaskType::kInternalMediaRealTime:
case TaskType::kInternalUserInteraction:
case TaskType::kInternalIntersectionObserver:
case TaskType::kUnthrottled:
return TaskQueueWithTaskType::Create(PausableTaskQueue(), type);
case TaskType::kInternalIPC:
// The TaskType of Inspector tasks needs to be unpausable because they need
......
......@@ -168,8 +168,6 @@ const char* TaskTypeToString(TaskType task_type) {
return "InternalDefault";
case TaskType::kInternalLoading:
return "InternalLoading";
case TaskType::kUnthrottled:
return "Unthrottled";
case TaskType::kInternalTest:
return "InternalTest";
case TaskType::kInternalWebCrypto:
......
......@@ -114,7 +114,6 @@ scoped_refptr<base::SingleThreadTaskRunner> WorkerScheduler::GetTaskRunner(
case TaskType::kMiscPlatformAPI:
case TaskType::kInternalDefault:
case TaskType::kInternalLoading:
case TaskType::kUnthrottled:
case TaskType::kInternalTest:
case TaskType::kInternalWebCrypto:
case TaskType::kInternalIndexedDB:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment