[Nearby] Fix settings labels to match specs.

This updates the title on the button that opens the device name dialog
and removes the label above the text field in the dialog. These changes
are to match updated specs in the Nearby Share strings spec.

Bug: b:161297140
Change-Id: If77ed7f29cd2ce9f2ae37c810baebfe38688c251
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417057Reviewed-by: James Vecore <vecore@google.com>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Michael Hansen <hansenmichael@google.com>
Cr-Commit-Position: refs/heads/master@{#808449}

chrome/app/shared_settings_strings.grdp

@@ -105,11 +105,8 @@
   <message name="IDS_SETTINGS_NEARBY_SHARE_DEVICE_NAME_DIALOG_TITLE" desc="Title for the dialog which allows a user to set the name of their device which is shown to other devices for the Nearby Share feature.">
     Device Name
   </message>
-  <message name="IDS_SETTINGS_NEARBY_SHARE_DEVICE_NAME_INPUT_LABEL" desc="Label for the input field which allows a user to set the name of their device which is shown to other devices for the Nearby Share feature.">
-    New device name
-  </message>
   <message name="IDS_SETTINGS_NEARBY_SHARE_EDIT_DEVICE_NAME" desc="Label for the button that opens the dialog which allows a user to set the name of their device which is shown to other devices for the Nearby Share feature.">
-    Change name
+    Change device name
   </message>
   <message name="IDS_SETTINGS_NEARBY_SHARE_DEVICE_NAME_ARIA_DESCRIPTION" desc="Description for screen readers, not displayed in UI, specifying the current device name which is shown to other devices for the Nearby Share feature." is_accessibility_with_no_ui="true">
     Current device name is <ph name="DEVICE_NAME">$1<ex>Michael's Chromebook</ex></ph>

chrome/app/shared_settings_strings_grdp/IDS_SETTINGS_NEARBY_SHARE_DEVICE_NAME_INPUT_LABEL.png.sha1

-452d7ccf3cb53494cfaf172367a33e9cc216e4eb
\ No newline at end of file

chrome/app/shared_settings_strings_grdp/IDS_SETTINGS_NEARBY_SHARE_EDIT_DEVICE_NAME.png.sha1

-b7cf3b1dfec2c0bfe12ddad390708579dc06387c
+2fb72f86cfc7c540496ee73766b9ba6488a8ce9b
\ No newline at end of file

chrome/browser/resources/settings/chromeos/nearby_share_page/nearby_share_device_name_dialog.html

@@ -17,8 +17,7 @@
         $i18n{nearbyShareDeviceNameDialogTitle}
       </div>
       <div slot="body">
-        <cr-input label="$i18n{nearbyShareDeviceNameDialogInputLabel}"
-            value="[[prefs.nearby_sharing.device_name.value]]" autofocus>
+        <cr-input value="[[prefs.nearby_sharing.device_name.value]]" autofocus>
         </cr-input>
       </div>
       <div class="layout horizontal center" slot="button-container">

chrome/browser/ui/webui/settings/shared_settings_localized_strings_provider.cc

@@ -253,8 +253,6 @@ void AddNearbyShareData(content::WebUIDataSource* html_source) {
        IDS_SETTINGS_NEARBY_SHARE_DEVICE_NAME_ROW_TITLE},
       {"nearbyShareDeviceNameDialogTitle",
        IDS_SETTINGS_NEARBY_SHARE_DEVICE_NAME_DIALOG_TITLE},
-      {"nearbyShareDeviceNameDialogInputLabel",
-       IDS_SETTINGS_NEARBY_SHARE_DEVICE_NAME_INPUT_LABEL},
       {"nearbyShareEditDeviceName", IDS_SETTINGS_NEARBY_SHARE_EDIT_DEVICE_NAME},
       {"nearbyShareDeviceNameAriaDescription",
        IDS_SETTINGS_NEARBY_SHARE_DEVICE_NAME_ARIA_DESCRIPTION},