Commit aaa73d4c authored by Max Moroz's avatar Max Moroz Committed by Commit Bot

Do not bundle compiler-rt libraries (ASan,UBSan,Profile) for Android on i686.

This change removes 6+ MB of binaries from the build tools bundle:
3.7M	lib/linux/libclang_rt.asan-i686-android.so
2.5M	lib/linux/libclang_rt.ubsan_standalone-i686-android.so
80K	lib/linux/libclang_rt.profile-i686-android.a

It also can break some workflows, but as discussed in person, there is a good
chance that no one is using those libraries on i686 arch.


Bug: 866225
Change-Id: Ifbc85e542359681f60f19f52e5bd7a8a7e1655f3
Reviewed-on: https://chromium-review.googlesource.com/1158708Reviewed-by: default avatarNico Weber <thakis@chromium.org>
Commit-Queue: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579854}
parent 2b8a8366
......@@ -828,9 +828,11 @@ def UpdateClang(args):
RunCommand(['ninja', 'asan', 'ubsan', 'profile'])
# And copy them into the main build tree.
want_archs = '{aarch64,arm}'
want = [
'lib/linux/*.so', # ASan and UBSan shared libraries only.
'lib/linux/*profile*', # Static profile libraries.
'lib/linux/libclang_rt.asan-%s-android.so' % want_archs,
'lib/linux/libclang_rt.ubsan_standalone-%s-android.so' % want_archs,
'lib/linux/libclang_rt.profile-%s-android.a' % want_archs,
]
for p in want:
for f in glob.glob(os.path.join(build_dir, p)):
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment