Commit aaec8331 authored by grunell's avatar grunell Committed by Commit bot

Update log text for glitch info in AudioSyncReader.

Adds total number of render calls, similar to what's logged in AudioInputSyncWriter. This makes it easier to see the proportion of glitches.

Review-Url: https://codereview.chromium.org/2270863002
Cr-Commit-Position: refs/heads/master@{#414340}
parent 2c1178c2
...@@ -6,6 +6,7 @@ ...@@ -6,6 +6,7 @@
#include <algorithm> #include <algorithm>
#include "base/format_macros.h"
#include "base/metrics/histogram.h" #include "base/metrics/histogram.h"
#include "base/strings/stringprintf.h" #include "base/strings/stringprintf.h"
#include "build/build_config.h" #include "build/build_config.h"
...@@ -108,13 +109,8 @@ AudioInputSyncWriter::~AudioInputSyncWriter() { ...@@ -108,13 +109,8 @@ AudioInputSyncWriter::~AudioInputSyncWriter() {
AUDIO_CAPTURER_AUDIO_GLITCHES_MAX + 1); AUDIO_CAPTURER_AUDIO_GLITCHES_MAX + 1);
std::string log_string = base::StringPrintf( std::string log_string = base::StringPrintf(
#if defined(COMPILER_MSVC) "AISW: number of detected audio glitches: %" PRIuS " out of %" PRIuS,
"AISW: number of detected audio glitches: %Iu out of %Iu", write_error_count_, write_count_);
#else
"AISW: number of detected audio glitches: %zu out of %zu",
#endif
write_error_count_,
write_count_);
MediaStreamManager::SendMessageToNativeLog(log_string); MediaStreamManager::SendMessageToNativeLog(log_string);
DVLOG(1) << log_string; DVLOG(1) << log_string;
} }
......
...@@ -7,6 +7,7 @@ ...@@ -7,6 +7,7 @@
#include <algorithm> #include <algorithm>
#include "base/command_line.h" #include "base/command_line.h"
#include "base/format_macros.h"
#include "base/memory/shared_memory.h" #include "base/memory/shared_memory.h"
#include "base/metrics/histogram.h" #include "base/metrics/histogram.h"
#include "base/strings/stringprintf.h" #include "base/strings/stringprintf.h"
...@@ -99,9 +100,9 @@ AudioSyncReader::~AudioSyncReader() { ...@@ -99,9 +100,9 @@ AudioSyncReader::~AudioSyncReader() {
renderer_missed_callback_count_ > 0 ? renderer_missed_callback_count_ > 0 ?
LogAudioGlitchResult(AUDIO_RENDERER_AUDIO_GLITCHES) : LogAudioGlitchResult(AUDIO_RENDERER_AUDIO_GLITCHES) :
LogAudioGlitchResult(AUDIO_RENDERER_NO_AUDIO_GLITCHES); LogAudioGlitchResult(AUDIO_RENDERER_NO_AUDIO_GLITCHES);
std::string log_string = std::string log_string = base::StringPrintf(
base::StringPrintf("ASR: number of detected audio glitches=%d", "ASR: number of detected audio glitches: %" PRIuS " out of %" PRIuS,
static_cast<int>(renderer_missed_callback_count_)); renderer_missed_callback_count_, renderer_callback_count_);
MediaStreamManager::SendMessageToNativeLog(log_string); MediaStreamManager::SendMessageToNativeLog(log_string);
DVLOG(1) << log_string; DVLOG(1) << log_string;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment