instanceof HTMLSourceElement Fails

https://bugs.webkit.org/show_bug.cgi?id=65013

Patch by Tom Zakrajsek <tomz@codeaurora.org> on 2011-08-20
Reviewed by Eric Carlson.

Source/WebCore:

Add HTMLSourceElement to DOMWindow.idl for consistency.  Constructors for
all elements should be available on DOMWindow.

 * bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore::RuntimeEnabledFeatures::htmlSourceElementEnabled):
* bindings/generic/RuntimeEnabledFeatures.h:
* page/DOMWindow.idl:

LayoutTests:

Updated test results after adding HTMLSourceElement to the DOMWindow

* fast/dom/prototype-inheritance-2-expected.txt:
* fast/dom/prototype-inheritance-expected.txt:
* platform/chromium/fast/dom/prototype-inheritance-expected.txt:
* platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
* platform/gtk/fast/dom/prototype-inheritance-expected.txt:
* platform/qt-wk2/fast/dom/prototype-inheritance-2-expected.txt:
* platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
* platform/qt/fast/dom/prototype-inheritance-expected.txt:
* platform/win/fast/dom/prototype-inheritance-expected.txt:

git-svn-id: svn://svn.chromium.org/blink/trunk@93482 bbb929c8-8fbe-4397-9dbb-9b2b20218538
parent ac9cd7e4
2011-08-20 Tom Zakrajsek <tomz@codeaurora.org>
instanceof HTMLSourceElement Fails
https://bugs.webkit.org/show_bug.cgi?id=65013
Reviewed by Eric Carlson.
Updated test results after adding HTMLSourceElement to the DOMWindow
* fast/dom/prototype-inheritance-2-expected.txt:
* fast/dom/prototype-inheritance-expected.txt:
* platform/chromium/fast/dom/prototype-inheritance-expected.txt:
* platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
* platform/gtk/fast/dom/prototype-inheritance-expected.txt:
* platform/qt-wk2/fast/dom/prototype-inheritance-2-expected.txt:
* platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
* platform/qt/fast/dom/prototype-inheritance-expected.txt:
* platform/win/fast/dom/prototype-inheritance-expected.txt:
2011-08-20 Darin Adler <darin@apple.com>
If Range::insertNode is passed an empty document fragment, it creates a broken DOM tree
......@@ -276,6 +276,7 @@ Never found HTMLPreElement
Never found HTMLQuoteElement
Never found HTMLScriptElement
Never found HTMLSelectElement
Never found HTMLSourceElement
Never found HTMLTableCaptionElement
Never found HTMLTableCellElement
Never found HTMLTableColElement
......
......@@ -221,6 +221,8 @@ PASS inner.HTMLScriptElement.isInner is true
PASS inner.HTMLScriptElement.constructor.isInner is true
PASS inner.HTMLSelectElement.isInner is true
PASS inner.HTMLSelectElement.constructor.isInner is true
PASS inner.HTMLSourceElement.isInner is true
PASS inner.HTMLSourceElement.constructor.isInner is true
PASS inner.HTMLStyleElement.isInner is true
PASS inner.HTMLStyleElement.constructor.isInner is true
PASS inner.HTMLTableCaptionElement.isInner is true
......
......@@ -221,6 +221,8 @@ PASS inner.HTMLScriptElement.isInner is true
PASS inner.HTMLScriptElement.constructor.isInner is true
PASS inner.HTMLSelectElement.isInner is true
PASS inner.HTMLSelectElement.constructor.isInner is true
PASS inner.HTMLSourceElement.isInner is true
PASS inner.HTMLSourceElement.constructor.isInner is true
PASS inner.HTMLStyleElement.isInner is true
PASS inner.HTMLStyleElement.constructor.isInner is true
PASS inner.HTMLTableCaptionElement.isInner is true
......
......@@ -276,6 +276,7 @@ Never found HTMLPreElement
Never found HTMLQuoteElement
Never found HTMLScriptElement
Never found HTMLSelectElement
Never found HTMLSourceElement
Never found HTMLTableCaptionElement
Never found HTMLTableCellElement
Never found HTMLTableColElement
......
......@@ -221,6 +221,8 @@ PASS inner.HTMLScriptElement.isInner is true
PASS inner.HTMLScriptElement.constructor.isInner is true
PASS inner.HTMLSelectElement.isInner is true
PASS inner.HTMLSelectElement.constructor.isInner is true
PASS inner.HTMLSourceElement.isInner is true
PASS inner.HTMLSourceElement.constructor.isInner is true
PASS inner.HTMLStyleElement.isInner is true
PASS inner.HTMLStyleElement.constructor.isInner is true
PASS inner.HTMLTableCaptionElement.isInner is true
......
......@@ -279,6 +279,7 @@ Never found HTMLPreElement
Never found HTMLQuoteElement
Never found HTMLScriptElement
Never found HTMLSelectElement
Never found HTMLSourceElement
Never found HTMLTableCaptionElement
Never found HTMLTableCellElement
Never found HTMLTableColElement
......
......@@ -284,6 +284,7 @@ Never found HTMLPreElement
Never found HTMLQuoteElement
Never found HTMLScriptElement
Never found HTMLSelectElement
Never found HTMLSourceElement
Never found HTMLTableCaptionElement
Never found HTMLTableCellElement
Never found HTMLTableColElement
......
......@@ -221,6 +221,8 @@ PASS inner.HTMLScriptElement.isInner is true
PASS inner.HTMLScriptElement.constructor.isInner is true
PASS inner.HTMLSelectElement.isInner is true
PASS inner.HTMLSelectElement.constructor.isInner is true
PASS inner.HTMLSourceElement.isInner is true
PASS inner.HTMLSourceElement.constructor.isInner is true
PASS inner.HTMLStyleElement.isInner is true
PASS inner.HTMLStyleElement.constructor.isInner is true
PASS inner.HTMLTableCaptionElement.isInner is true
......
......@@ -219,6 +219,8 @@ PASS inner.HTMLScriptElement.isInner is true
PASS inner.HTMLScriptElement.constructor.isInner is true
PASS inner.HTMLSelectElement.isInner is true
PASS inner.HTMLSelectElement.constructor.isInner is true
PASS inner.HTMLSourceElement.isInner is true
PASS inner.HTMLSourceElement.constructor.isInner is true
PASS inner.HTMLStyleElement.isInner is true
PASS inner.HTMLStyleElement.constructor.isInner is true
PASS inner.HTMLTableCaptionElement.isInner is true
......
2011-08-20 Tom Zakrajsek <tomz@codeaurora.org>
instanceof HTMLSourceElement Fails
https://bugs.webkit.org/show_bug.cgi?id=65013
Reviewed by Eric Carlson.
Add HTMLSourceElement to DOMWindow.idl for consistency. Constructors for
all elements should be available on DOMWindow.
* bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore::RuntimeEnabledFeatures::htmlSourceElementEnabled):
* bindings/generic/RuntimeEnabledFeatures.h:
* page/DOMWindow.idl:
2011-08-20 Darin Adler <darin@apple.com>
If Range::insertNode is passed an empty document fragment, it creates a broken DOM tree
......@@ -104,6 +104,11 @@ bool RuntimeEnabledFeatures::htmlVideoElementEnabled()
return MediaPlayer::isAvailable();
}
bool RuntimeEnabledFeatures::htmlSourceElementEnabled()
{
return MediaPlayer::isAvailable();
}
bool RuntimeEnabledFeatures::mediaErrorEnabled()
{
return MediaPlayer::isAvailable();
......
......@@ -85,6 +85,7 @@ public:
static bool htmlMediaElementEnabled();
static bool htmlAudioElementEnabled();
static bool htmlVideoElementEnabled();
static bool htmlSourceElementEnabled();
static bool mediaErrorEnabled();
static bool timeRangesEnabled();
#endif
......
......@@ -607,6 +607,7 @@ module window {
attribute [Conditional=VIDEO, EnabledAtRuntime] HTMLVideoElementConstructor HTMLVideoElement;
attribute [Conditional=VIDEO, EnabledAtRuntime] MediaErrorConstructor MediaError;
attribute [Conditional=VIDEO, EnabledAtRuntime] TimeRangesConstructor TimeRanges;
attribute [Conditional=VIDEO, EnabledAtRuntime] HTMLSourceElementConstructor HTMLSourceElement;
#if defined(ENABLE_ANIMATION_API) && ENABLE_ANIMATION_API
attribute WebKitAnimationConstructor WebKitAnimation;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment