Commit ab3a31dc authored by dpapad's avatar dpapad Committed by Chromium LUCI CQ

Settings: Use a cr-link-row for "Choose name and picture".

Previously the "Choose name and picture" label was read twice by
screen readers. cr-link-row already takes care of not having both
the label and the button itself in the linear navigation order of
screen readers.

Bug: None
Change-Id: I658ffdaaf3ca92dfb8bc88f878040704b9177e62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574275Reviewed-by: default avatarJohn Lee <johntlee@chromium.org>
Commit-Queue: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#834416}
parent b8deaf9c
......@@ -118,15 +118,9 @@ shown on non-ChromeOS platforms -->
hidden="[[!shouldShowGoogleAccount_]]"
on-click="openGoogleAccount_" external></cr-link-row>
<div class="cr-row" id="edit-profile" on-click="onProfileTap_"
actionable>
<div class="flex cr-padded-text">
$i18n{profileNameAndPicture}
</div>
<cr-icon-button class="subpage-arrow" aria-label="$i18n{editPerson}"
aria-roledescription="$i18n{subpageArrowRoleDescription}">
</cr-icon-button>
</div>
<cr-link-row id="edit-profile"
label="$i18n{profileNameAndPicture}"
on-click="onProfileTap_" ></cr-link-row>
</template>
</if>
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment