Commit ab787412 authored by Johannes Henkel's avatar Johannes Henkel Committed by Commit Bot

[DevTools] Remove the nobinary-* test suites.

We're removing the --disable-internal-devtools-binary-protocol
flag so these virtual tests are no longer useful.

See also:
https://chromium-review.googlesource.com/c/chromium/src/+/1575999

Bug: 954618

Change-Id: Ia084f42b19ea11c92de9c3dc37d43249ca67d7bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576002Reviewed-by: default avatarAndrey Kosyakov <caseq@chromium.org>
Commit-Queue: Johannes Henkel <johannes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652674}
parent e45c305d
......@@ -48,9 +48,7 @@ crbug.com/438499 [ Linux ] fast/workers/worker-multi-startup.html [ Timeout ]
crbug.com/438499 [ Linux ] http/tests/websocket/workers/worker-simple.html [ Timeout ]
crbug.com/438499 [ Linux ] http/tests/workers/text-encoding.html [ Timeout ]
crbug.com/438499 [ Linux ] http/tests/devtools/profiler/heap-snapshot-loader.js [ Timeout ]
crbug.com/438499 [ Linux ] virtual/nobinary-for-devtools/http/tests/devtools/profiler/heap-snapshot-loader.js [ Timeout ]
crbug.com/438499 [ Linux ] http/tests/devtools/profiler/heap-snapshot-containment-show-all.js [ Timeout ]
crbug.com/438499 [ Linux ] virtual/nobinary-for-devtools/http/tests/devtools/profiler/heap-snapshot-containment-show-all.js [ Timeout ]
crbug.com/438499 [ Linux ] virtual/threaded/animations/unanimated-style.html [ Timeout ]
# Flakily timeout on Linux ASAN bots.
......@@ -58,9 +56,7 @@ crbug.com/243871 [ Linux ] virtual/threaded/fast/scroll-behavior/ [ Skip ]
crbug.com/464065 [ Linux ] media/track/css-cue-for-video-in-shadow.html [ Timeout ]
crbug.com/464065 [ Linux ] media/track/css-cue-for-video-in-shadow-2.html [ Timeout ]
crbug.com/572723 [ Linux ] http/tests/devtools/sources/debugger/debugger-completions-on-call-frame.js [ Timeout Pass ]
crbug.com/572723 [ Linux ] virtual/nobinary-for-devtools/http/tests/devtools/sources/debugger/debugger-completions-on-call-frame.js [ Timeout Pass ]
crbug.com/700795 [ Linux ] http/tests/devtools/animation/animation-transition-setTiming-crash.js [ Skip ]
crbug.com/700795 [ Linux ] virtual/nobinary-for-devtools/http/tests/devtools/animation/animation-transition-setTiming-crash.js [ Skip ]
crbug.com/928941 [ Linux ] external/wpt/background-fetch/fetch.https.window.html [ Timeout ]
# Intentionally failed allocations, via partitionAllocGenericFlags()
......@@ -68,9 +64,7 @@ crbug.com/577889 [ Linux ] fast/js/typed-array-allocation-failure.html [ Crash ]
# Memory allocation hooks are disabled on ASAN/MSAN
crbug.com/803276 inspector-protocol/memory/sampling-native-profile.js [ Skip ]
crbug.com/803276 virtual/nobinary-for-inspector-protocol/inspector-protocol/memory/sampling-native-profile.js [ Skip ]
crbug.com/803276 inspector-protocol/memory/sampling-native-snapshot.js [ Skip ]
crbug.com/803276 virtual/nobinary-for-inspector-protocol/inspector-protocol/memory/sampling-native-snapshot.js [ Skip ]
crbug.com/803276 virtual/sampling-heap-profiler/inspector-protocol/memory/sampling-native-profile.js [ Skip ]
crbug.com/803276 virtual/sampling-heap-profiler/inspector-protocol/memory/sampling-native-snapshot.js [ Skip ]
......
......@@ -7,11 +7,8 @@ crbug.com/800898 external/wpt/workers/shared-worker-from-blob-url.window.html [
crbug.com/800898 virtual/omt-worker-fetch/external/wpt/workers/shared-worker-from-blob-url.window.html [ Skip ]
crbug.com/595993 external/wpt/service-workers/service-worker/request-end-to-end.https.html [ Failure ]
crbug.com/896924 http/tests/inspector-protocol/network/interception-multiclient.js [ Timeout Failure ]
crbug.com/896924 virtual/nobinary-for-http-inspector-protocol/http/tests/inspector-protocol/network/interception-multiclient.js [ Timeout Failure ]
crbug.com/899303 http/tests/inspector-protocol/fetch/fetch-basic.js [ Timeout ]
crbug.com/899303 virtual/nobinary-for-http-inspector-protocol/http/tests/inspector-protocol/fetch/fetch-basic.js [ Timeout ]
crbug.com/899303 http/tests/inspector-protocol/fetch/fetch-renderer.js [ Timeout ]
crbug.com/899303 virtual/nobinary-for-http-inspector-protocol/http/tests/inspector-protocol/fetch/fetch-renderer.js [ Timeout ]
crbug.com/917284 external/wpt/service-workers/service-worker/claim-fetch-with-appcache.https.html [ Failure ]
crbug.com/917284 virtual/disabled-service-worker-servicification/external/wpt/service-workers/service-worker/claim-fetch-with-appcache.https.html [ Failure ]
crbug.com/933880 external/wpt/FileAPI/url/cross-global-revoke.sub.html [ Failure ]
......@@ -19,7 +16,6 @@ crbug.com/933880 external/wpt/FileAPI/url/url-with-fetch.any.html [ Failure ]
crbug.com/933880 external/wpt/FileAPI/url/url-with-xhr.any.html [ Failure ]
crbug.com/950412 [ Linux Debug ] http/tests/inspector-protocol/network/request-interception-request-id.js [ Failure ]
crbug.com/950412 [ Linux Debug ] virtual/nobinary-for-http-inspector-protocol/http/tests/inspector-protocol/network/request-interception-request-id.js [ Failure ]
# This passes in content_shell but not in chrome with network service disabled,
# because content_shell does not add the about: handler. With network service
......@@ -30,4 +26,3 @@ Bug(none) http/tests/misc/redirect-to-about-blank.html [ Pass ]
Bug(none) virtual/omt-worker-fetch [ Skip ]
Bug(none) virtual/outofblink-cors [ Skip ]
Bug(none) http/tests/inspector-protocol/fetch [ Skip ]
Bug(none) virtual/nobinary-for-http-inspector-protocol/http/tests/inspector-protocol/fetch [ Skip ]
......@@ -13,13 +13,8 @@ crbug.com/933880 external/wpt/FileAPI/url/url-with-fetch.any.html [ Failure ]
crbug.com/933880 external/wpt/FileAPI/url/url-with-xhr.any.html [ Failure ]
crbug.com/933880 external/wpt/service-workers/service-worker/request-end-to-end.https.html [ Failure ]
crbug.com/933880 http/tests/inspector-protocol/network/interception-take-stream.js [ Failure ]
crbug.com/933880 virtual/nobinary-for-http-inspector-protocol/http/tests/inspector-protocol/network/interception-take-stream.js [ Failure ]
crbug.com/933880 http/tests/inspector-protocol/network/raw-headers-for-protected-document.js [ Failure ]
crbug.com/933880 virtual/nobinary-for-http-inspector-protocol/http/tests/inspector-protocol/network/raw-headers-for-protected-document.js [ Failure ]
crbug.com/933880 http/tests/inspector-protocol/network/raw-headers-for-websocket.js [ Failure ]
crbug.com/933880 virtual/nobinary-for-http-inspector-protocol/http/tests/inspector-protocol/network/raw-headers-for-websocket.js [ Failure ]
crbug.com/933880 http/tests/inspector-protocol/network/security-info-on-response.js [ Failure ]
crbug.com/933880 virtual/nobinary-for-http-inspector-protocol/http/tests/inspector-protocol/network/security-info-on-response.js [ Failure ]
crbug.com/933880 http/tests/inspector-protocol/network/xhr-interception-auth-fail.js [ Failure ]
crbug.com/933880 virtual/nobinary-for-http-inspector-protocol/http/tests/inspector-protocol/network/xhr-interception-auth-fail.js [ Failure ]
crbug.com/933880 http/tests/misc/redirect-to-about-blank.html [ Timeout ]
# Expectations for CompositeAfterPaint
# See: https://docs.google.com/document/d/1QCM912Dr6u38DqyQqd7pxQxDy8FFOoWMMDq7uAXqKdA/view
Bug(none) http/tests/devtools/tracing/ [ Skip ]
Bug(none) virtual/nobinary-for-devtools/http/tests/devtools/tracing/ [ Skip ]
Bug(none) scrollingcoordinator/ [ Skip ]
Bug(none) virtual/disable-blink-gen-property-trees/ [ Skip ]
......@@ -449,15 +448,11 @@ Bug(none) css3/filters/blur-filter-page-scroll-self.html [ Failure ]
# Crash during PictureLayer::GetPicture() when DisplayItemList is finished twice.
Bug(none) http/tests/devtools/layers/layer-canvas-log.js [ Crash ]
Bug(none) virtual/nobinary-for-devtools/http/tests/devtools/layers/layer-canvas-log.js [ Crash ]
Bug(none) http/tests/devtools/layers/layer-replay-scale.js [ Crash ]
Bug(none) virtual/nobinary-for-devtools/http/tests/devtools/layers/layer-replay-scale.js [ Crash ]
# Missing compositing reasons
Bug(none) http/tests/devtools/layers/layer-compositing-reasons.js [ Failure ]
Bug(none) virtual/nobinary-for-devtools/http/tests/devtools/layers/layer-compositing-reasons.js [ Failure ]
# Missing WheelEventHandler
Bug(none) http/tests/devtools/layers/layer-scroll-rects-get.js [ Failure ]
Bug(none) virtual/nobinary-for-devtools/http/tests/devtools/layers/layer-scroll-rects-get.js [ Failure ]
# Other:
crbug.com/935728 fast/frames/transparent-scrollbar.html [ Failure ]
......
......@@ -356,10 +356,6 @@ crbug.com/591099 virtual/mouseevent_fractional/fast/events/touch/compositor-touc
crbug.com/591099 virtual/mouseevent_fractional/fast/events/touch/compositor-touch-hit-rects-list-translate.html [ Failure ]
crbug.com/591099 virtual/mouseevent_fractional/fast/events/touch/compositor-touch-hit-rects.html [ Failure ]
crbug.com/591099 virtual/new-remote-playback-pipeline/ [ Skip ]
crbug.com/591099 virtual/nobinary-for-devtools/http/tests/devtools/sources/debugger-frameworks/frameworks-jquery.js [ Crash Pass ]
crbug.com/591099 virtual/nobinary-for-devtools/http/tests/devtools/tracing-session-id.js [ Pass ]
crbug.com/591099 virtual/nobinary-for-devtools/http/tests/devtools/tracing/console-timeline.js [ Pass ]
crbug.com/591099 virtual/nobinary-for-inspector-protocol/inspector-protocol/dom-snapshot/dom-snapshot-getSnapshot-origin-url.js [ Crash Pass ]
crbug.com/591099 virtual/omt-worker-fetch/external/wpt/service-workers/service-worker/client-navigate.https.html [ Pass ]
crbug.com/591099 virtual/outofblink-cors/ [ Skip ]
crbug.com/591099 virtual/paint-timing/external/wpt/paint-timing/sibling-painting-first-image.html [ Failure ]
......
......@@ -23,7 +23,6 @@ crbug.com/891575 virtual/android/fullscreen/video-overlay-scroll.html [ Leak Pas
crbug.com/786995 virtual/threaded/http/tests/devtools/tracing/timeline-style/timeline-style-recalc-all-invalidator-types.js [ Leak Pass ]
crbug.com/859640 http/tests/devtools/tracing/timeline-style/timeline-style-recalc-all-invalidator-types.js [ Leak Pass ]
crbug.com/859640 virtual/nobinary-for-devtools/http/tests/devtools/tracing/timeline-style/timeline-style-recalc-all-invalidator-types.js [ Leak Pass ]
# Requests with keepalive specified will be kept alive even when the frame is
# detached, which means leaks reported by the leak detector are by design.
......@@ -36,7 +35,6 @@ crbug.com/651742 external/wpt/content-security-policy/connect-src/connect-src-be
# -----------------------------------------------------------------
crbug.com/780386 external/wpt/html/dom/reflection-grouping.html [ Leak Pass ]
crbug.com/667560 [ Linux ] http/tests/devtools/console/console-search.js [ Leak Pass ]
crbug.com/667560 [ Linux ] virtual/nobinary-for-devtools/http/tests/devtools/console/console-search.js [ Leak Pass ]
crbug.com/835943 [ Linux ] http/tests/appcache/non-html.xhtml [ Leak Pass ]
crbug.com/860117 [ Linux ] editing/pasteboard/drag-drop-iframe-refresh-crash.html [ Pass Leak ]
......@@ -63,14 +61,12 @@ crbug.com/848354 [ Linux ] plugins/fullscreen-plugins-dont-reload.html [ Pass Le
# Sheriff 2018-07-10
# Test flaking on Linux Trusty Leak
crbug.com/862029 [ Linux ] http/tests/devtools/tracing/timeline-misc/timeline-window-filter.js [ Pass Leak ]
crbug.com/862029 [ Linux ] virtual/nobinary-for-devtools/http/tests/devtools/tracing/timeline-misc/timeline-window-filter.js [ Pass Leak ]
# Sheriff 2018-08-15
crbug.com/874442 [ Linux ] svg/animations/mpath-remove-from-dependents-on-delete-crash.html [ Pass Crash ]
# Sheriff 2018-08-17
crbug.com/847114 [ Linux ] http/tests/devtools/tracing/decode-resize.js [ Pass Failure ]
crbug.com/847114 [ Linux ] virtual/nobinary-for-devtools/http/tests/devtools/tracing/decode-resize.js [ Pass Failure ]
crbug.com/847114 [ Linux ] virtual/threaded/http/tests/devtools/tracing/decode-resize.js [ Pass Failure ]
# Sheriff 2018-08-29
......@@ -96,7 +92,6 @@ crbug.com/927454 [ Linux ] external/wpt/pointerevents/pointerevent_lostpointerca
#Sheriff 2019-02-21
crbug.com/934144 [ Linux ] http/tests/devtools/tracing/timeline-misc/timeline-flame-chart-automatically-size-window.js [ Pass Leak ]
crbug.com/934144 [ Linux ] virtual/nobinary-for-devtools/http/tests/devtools/tracing/timeline-misc/timeline-flame-chart-automatically-size-window.js [ Pass Leak ]
#Sheriff 2019-02-25
crbug.com/894651 [ Linux ] virtual/bidi-caret-affinity/editing/selection/modify_move/move_left_word_09_rtl_multi_line.html [ Failure Leak ]
......
......@@ -144,13 +144,10 @@ fast/harness/results.html [ WontFix ]
# Linux layout tests do not have a Myanmar fallback font.
[ Linux ] inspector-protocol/layout-fonts/fallback-myanmar.js [ WontFix ]
[ Linux ] virtual/nobinary-for-inspector-protocol/inspector-protocol/layout-fonts/fallback-myanmar.js [ WontFix ]
# Segoe UI matching is only relevant on Windows
[ Mac ] inspector-protocol/layout-fonts/font-weight-granularity-matching.js [ WontFix ]
[ Mac ] virtual/nobinary-for-inspector-protocol/inspector-protocol/layout-fonts/font-weight-granularity-matching.js [ WontFix ]
[ Linux ] inspector-protocol/layout-fonts/font-weight-granularity-matching.js [ WontFix ]
[ Linux ] virtual/nobinary-for-inspector-protocol/inspector-protocol/layout-fonts/font-weight-granularity-matching.js [ WontFix ]
# Tests in media/stable are only supposed to be run as virtual test (see virtual/stable/media).
media/stable [ WontFix ]
......@@ -2277,7 +2274,6 @@ crbug.com/669083 virtual/outofblink-cors/http/tests/security/frameNavigation/xss
# 3) site isolation is enabled without also enabling
# IsolatedCodeCache (tests disabled by the test expectation below).
Bug(none) http/tests/devtools/isolated-code-cache/cross-origin-test.js [ WontFix ]
Bug(none) virtual/nobinary-for-devtools/http/tests/devtools/isolated-code-cache/cross-origin-test.js [ WontFix ]
# ==== Tests incompatible with the default WPT Origin Isolation end here ==^^
# Tests using testRunner.useUnfortunateSynchronousResizeMode occasionally fail on Win7,
......
This diff is collapsed.
......@@ -291,21 +291,6 @@
"base": "http/tests/devtools/tracing",
"args": ["--enable-threaded-compositing"]
},
{
"prefix": "nobinary-for-devtools",
"base": "http/tests/devtools",
"args": ["--disable-internal-devtools-binary-protocol"]
},
{
"prefix": "nobinary-for-http-inspector-protocol",
"base": "http/tests/inspector-protocol",
"args": ["--disable-internal-devtools-binary-protocol"]
},
{
"prefix": "nobinary-for-inspector-protocol",
"base": "inspector-protocol",
"args": ["--disable-internal-devtools-binary-protocol"]
},
{
"prefix": "composite-after-paint",
"base": "compositing",
......
# This suite runs the tests in http/tests/devtools with
# the additional flag --disable-internal-devtools-binary-protocol.
# This suite runs the tests in http/tests/inspector-protocol with
# the additional flag --disable-internal-devtools-binary-protocol.
# This suite runs the tests in inspector-protocol with
# the additional flag --disable-internal-devtools-binary-protocol.
Tests DOM.getBoxModel method.
DIV style,position:absolute;top:100;left:0;width:100;height:100;background:red [
[0] : 0
[1] : 100
[2] : 100
[3] : 100
[4] : 100
[5] : 200
[6] : 0
[7] : 200
]
DIV style,position:absolute;top:200;left:100;width:100;height:100;background:green [
[0] : 100
[1] : 200
[2] : 200
[3] : 200
[4] : 200
[5] : 300
[6] : 100
[7] : 300
]
DIV style,position:absolute;top:150;left:50;width:100;height:100;background:blue;transform:rotate(45deg); [
[0] : 100
[1] : 129.289321899414
[2] : 170.710678100586
[3] : 200
[4] : 100
[5] : 270.710693359375
[6] : 29.2893218994141
[7] : 200
]
DIV style,width:100px;height:100px;background:orange [
[0] : 210
[1] : 210
[2] : 310
[3] : 210
[4] : 310
[5] : 310
[6] : 210
[7] : 310
]
rect id,theRect,x,30,y,50,width,100,height,100 [
[0] : 432
[1] : 452
[2] : 532
[3] : 452
[4] : 532
[5] : 552
[6] : 432
[7] : 552
]
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment