Fix Clank official build failure. Speculatively revert CL.
Clank Official Build Failure: ~~~ File "../../build/android/gyp/apkbuilder.py", line 383, in <module> main(sys.argv[1:]) File "../../build/android/gyp/apkbuilder.py", line 307, in main with zipfile.ZipFile(options.dex_file, 'r') as dex_zip: File "/usr/lib/python2.7/zipfile.py", line 770, in __init__ self._RealGetContents() File "/usr/lib/python2.7/zipfile.py", line 857, in _RealGetContents x._decodeExtra() File "/usr/lib/python2.7/zipfile.py", line 388, in _decodeExtra tp, ln = unpack('<HH', extra[:4]) struct.error: unpack requires a string argument of length 4 ~~~ This CL speculatively revert the CLs that seems to be linked with build failure. The bug happens while trying to zip dex file: ~~~ with zipfile.ZipFile(options.dex_file, 'r') as dex_zip: ~~~ and the following branch of CL deals with zip + dex files: Revert "dex.py: Remove obsolete flags, code clean-up." commit 35fc212e. https://chromium-review.googlesource.com/c/chromium/src/+/1694090/4 Revert "Android: Zipalign library dex files for incremental install" commit 209eac23. https://chromium-review.googlesource.com/c/chromium/src/+/1692492/6 TBR=agrieve@chromium.org Bug: 983519 Change-Id: Ia90b7f5d16b09ae29cf0617a09a80e5312ed858a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700064 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:Sam Maier <smaier@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#676898}
Showing
This diff is collapsed.
Please register or sign in to comment