Commit aba5567b authored by Giovanni Ortuño Urquidi's avatar Giovanni Ortuño Urquidi Committed by Commit Bot

mojo-js: Fix SIMPLE_OPTIMIZATIONS for mojo_bindings_lite.js

Adds @provideGoog to compile_preamble.js to tell the compiler that the
file provides the goog namespace. Without this, compile_preamble.js is
compiled after bindings_lite.js and causes runtime errors when
"goog" methods get called by bindings_lite.js.

This issue only comes up when compiling with SIMPLE_OPTIMIZATIONS.
Compiling with ADVANCED_OPTIMIZATIONS worked correctly.

Change-Id: Ia26bdc31e13002c60503813a41ba9613cd764a88
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847608Reviewed-by: default avatarKen Rockot <rockot@google.com>
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704356}
parent 7421ea5a
...@@ -7,6 +7,8 @@ ...@@ -7,6 +7,8 @@
* @fileoverview Preamble for JavaScript to be compiled with Closure Compiler. * @fileoverview Preamble for JavaScript to be compiled with Closure Compiler.
* We don't comple against the Closure library, so this provides a minimal set * We don't comple against the Closure library, so this provides a minimal set
* of 'goog' namespace properties to support things like symbol exports. * of 'goog' namespace properties to support things like symbol exports.
*
* @provideGoog
*/ */
/** @const */ /** @const */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment