Commit aba6331a authored by Eugene Zemtsov's avatar Eugene Zemtsov Committed by Chromium LUCI CQ

Switch video frame scaling back to kFilterBox

This reverts: https://crrev.com/670be8adae8396738fb2b9c3ba146b34ff578f38
The overread bug in libyuv has been fixed.

Bug: 1158178
Change-Id: I3440b601fd0a49e5a8b21a7aeb11d04c4a40e471
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605835Reviewed-by: default avatarChrome Cunningham <chcunningham@chromium.org>
Commit-Queue: Eugene Zemtsov <eugene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#839549}
parent 55eba91a
......@@ -503,10 +503,7 @@ bool I420CopyWithPadding(const VideoFrame& src_frame, VideoFrame* dst_frame) {
Status ConvertAndScaleFrame(const VideoFrame& src_frame,
VideoFrame& dst_frame,
std::vector<uint8_t>& tmp_buf) {
// Can't use kFilterBox, because it can cause source buffer overreads while
// scaling.
// TODO(https://bugs.chromium.org/p/libyuv/issues/detail?id=875)
constexpr auto kDefaultFiltering = libyuv::kFilterBilinear;
constexpr auto kDefaultFiltering = libyuv::kFilterBox;
if (!src_frame.IsMappable() || !dst_frame.IsMappable())
return Status(StatusCode::kUnsupportedFrameFormatError);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment