Commit abc72fa5 authored by alemate@chromium.org's avatar alemate@chromium.org

Remove debug in WallpaperManagerBrowserTest.DisplayChange.

Debug messages were added in r267040 to diagnose failures.
They are not needed anymore.

BUG=362847

Review URL: https://codereview.chromium.org/279703005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270080 0039d316-1c4b-4281-b951-d872f2087c98
parent 8422f9fa
...@@ -827,26 +827,6 @@ WallpaperManager::GetAppropriateResolution() { ...@@ -827,26 +827,6 @@ WallpaperManager::GetAppropriateResolution() {
: WALLPAPER_RESOLUTION_SMALL; : WALLPAPER_RESOLUTION_SMALL;
} }
WallpaperManager::WallpaperResolution
WallpaperManager::GetAppropriateResolutionForTesting() {
gfx::Size size =
ash::DesktopBackgroundController::GetMaxDisplaySizeInNative();
const WallpaperResolution result = (size.width() > kSmallWallpaperMaxWidth ||
size.height() > kSmallWallpaperMaxHeight)
? WALLPAPER_RESOLUTION_LARGE
: WALLPAPER_RESOLUTION_SMALL;
LOG(ERROR) << "WallpaperManager::GetAppropriateResolution(): width()="
<< size.width()
<< " vs kSmallWallpaperMaxWidth=" << kSmallWallpaperMaxWidth
<< ", height()=" << size.height()
<< " vs kSmallWallpaperMaxHeight=" << kSmallWallpaperMaxHeight
<< ", result = " << (result == WALLPAPER_RESOLUTION_LARGE
? "WALLPAPER_RESOLUTION_LARGE"
: "WALLPAPER_RESOLUTION_SMALL");
return result;
}
void WallpaperManager::SetPolicyControlledWallpaper( void WallpaperManager::SetPolicyControlledWallpaper(
const std::string& user_id, const std::string& user_id,
const UserImage& user_image) { const UserImage& user_image) {
......
...@@ -222,9 +222,6 @@ class WallpaperManager: public content::NotificationObserver { ...@@ -222,9 +222,6 @@ class WallpaperManager: public content::NotificationObserver {
// Returns the appropriate wallpaper resolution for all root windows. // Returns the appropriate wallpaper resolution for all root windows.
static WallpaperResolution GetAppropriateResolution(); static WallpaperResolution GetAppropriateResolution();
// This is a temporary variant of the previous method to investigate
// a problem with WallpaperManagetBrowserTest.
static WallpaperResolution GetAppropriateResolutionForTesting();
void SetCommandLineForTesting(base::CommandLine* command_line); void SetCommandLineForTesting(base::CommandLine* command_line);
......
...@@ -95,9 +95,6 @@ class WallpaperManagerBrowserTest : public InProcessBrowserTest, ...@@ -95,9 +95,6 @@ class WallpaperManagerBrowserTest : public InProcessBrowserTest,
ash::test::DisplayManagerTestApi display_manager_test_api( ash::test::DisplayManagerTestApi display_manager_test_api(
ash::Shell::GetInstance()->display_manager()); ash::Shell::GetInstance()->display_manager());
display_manager_test_api.UpdateDisplay(display_specs); display_manager_test_api.UpdateDisplay(display_specs);
LOG(ERROR) << "UpdateDisplay(display_specs='" << display_specs
<< "') done.";
WallpaperManager::GetAppropriateResolutionForTesting();
} }
void WaitAsyncWallpaperLoadStarted() { void WaitAsyncWallpaperLoadStarted() {
...@@ -642,7 +639,6 @@ IN_PROC_BROWSER_TEST_P(WallpaperManagerBrowserTest, DisplayChange) { ...@@ -642,7 +639,6 @@ IN_PROC_BROWSER_TEST_P(WallpaperManagerBrowserTest, DisplayChange) {
// Wait for asynchronous DisplayBackgroundController::UpdateDisplay() call. // Wait for asynchronous DisplayBackgroundController::UpdateDisplay() call.
base::RunLoop().RunUntilIdle(); base::RunLoop().RunUntilIdle();
wallpaper_manager_test_utils::WaitAsyncWallpaperLoadFinished(); wallpaper_manager_test_utils::WaitAsyncWallpaperLoadFinished();
WallpaperManager::GetAppropriateResolutionForTesting();
EXPECT_EQ(WallpaperManager::WALLPAPER_RESOLUTION_SMALL, EXPECT_EQ(WallpaperManager::WALLPAPER_RESOLUTION_SMALL,
WallpaperManager::Get()->GetAppropriateResolution()); WallpaperManager::Get()->GetAppropriateResolution());
EXPECT_EQ(0, observer.GetUpdateWallpaperCountAndReset()); EXPECT_EQ(0, observer.GetUpdateWallpaperCountAndReset());
...@@ -651,7 +647,6 @@ IN_PROC_BROWSER_TEST_P(WallpaperManagerBrowserTest, DisplayChange) { ...@@ -651,7 +647,6 @@ IN_PROC_BROWSER_TEST_P(WallpaperManagerBrowserTest, DisplayChange) {
// Wait for asynchronous DisplayBackgroundController::UpdateDisplay() call. // Wait for asynchronous DisplayBackgroundController::UpdateDisplay() call.
base::RunLoop().RunUntilIdle(); base::RunLoop().RunUntilIdle();
wallpaper_manager_test_utils::WaitAsyncWallpaperLoadFinished(); wallpaper_manager_test_utils::WaitAsyncWallpaperLoadFinished();
WallpaperManager::GetAppropriateResolutionForTesting();
EXPECT_EQ(WallpaperManager::WALLPAPER_RESOLUTION_SMALL, EXPECT_EQ(WallpaperManager::WALLPAPER_RESOLUTION_SMALL,
WallpaperManager::Get()->GetAppropriateResolution()); WallpaperManager::Get()->GetAppropriateResolution());
EXPECT_EQ(0, observer.GetUpdateWallpaperCountAndReset()); EXPECT_EQ(0, observer.GetUpdateWallpaperCountAndReset());
...@@ -660,7 +655,6 @@ IN_PROC_BROWSER_TEST_P(WallpaperManagerBrowserTest, DisplayChange) { ...@@ -660,7 +655,6 @@ IN_PROC_BROWSER_TEST_P(WallpaperManagerBrowserTest, DisplayChange) {
// Wait for asynchronous DisplayBackgroundController::UpdateDisplay() call. // Wait for asynchronous DisplayBackgroundController::UpdateDisplay() call.
base::RunLoop().RunUntilIdle(); base::RunLoop().RunUntilIdle();
wallpaper_manager_test_utils::WaitAsyncWallpaperLoadFinished(); wallpaper_manager_test_utils::WaitAsyncWallpaperLoadFinished();
WallpaperManager::GetAppropriateResolutionForTesting();
EXPECT_EQ(WallpaperManager::WALLPAPER_RESOLUTION_SMALL, EXPECT_EQ(WallpaperManager::WALLPAPER_RESOLUTION_SMALL,
WallpaperManager::Get()->GetAppropriateResolution()); WallpaperManager::Get()->GetAppropriateResolution());
EXPECT_EQ(1, observer.GetUpdateWallpaperCountAndReset()); EXPECT_EQ(1, observer.GetUpdateWallpaperCountAndReset());
...@@ -670,7 +664,6 @@ IN_PROC_BROWSER_TEST_P(WallpaperManagerBrowserTest, DisplayChange) { ...@@ -670,7 +664,6 @@ IN_PROC_BROWSER_TEST_P(WallpaperManagerBrowserTest, DisplayChange) {
// Wait for asynchronous DisplayBackgroundController::UpdateDisplay() call. // Wait for asynchronous DisplayBackgroundController::UpdateDisplay() call.
base::RunLoop().RunUntilIdle(); base::RunLoop().RunUntilIdle();
wallpaper_manager_test_utils::WaitAsyncWallpaperLoadFinished(); wallpaper_manager_test_utils::WaitAsyncWallpaperLoadFinished();
WallpaperManager::GetAppropriateResolutionForTesting();
EXPECT_EQ(WallpaperManager::WALLPAPER_RESOLUTION_LARGE, EXPECT_EQ(WallpaperManager::WALLPAPER_RESOLUTION_LARGE,
WallpaperManager::Get()->GetAppropriateResolution()); WallpaperManager::Get()->GetAppropriateResolution());
EXPECT_EQ(1, observer.GetUpdateWallpaperCountAndReset()); EXPECT_EQ(1, observer.GetUpdateWallpaperCountAndReset());
...@@ -679,7 +672,6 @@ IN_PROC_BROWSER_TEST_P(WallpaperManagerBrowserTest, DisplayChange) { ...@@ -679,7 +672,6 @@ IN_PROC_BROWSER_TEST_P(WallpaperManagerBrowserTest, DisplayChange) {
// Wait for asynchronous DisplayBackgroundController::UpdateDisplay() call. // Wait for asynchronous DisplayBackgroundController::UpdateDisplay() call.
base::RunLoop().RunUntilIdle(); base::RunLoop().RunUntilIdle();
wallpaper_manager_test_utils::WaitAsyncWallpaperLoadFinished(); wallpaper_manager_test_utils::WaitAsyncWallpaperLoadFinished();
WallpaperManager::GetAppropriateResolutionForTesting();
EXPECT_EQ(WallpaperManager::WALLPAPER_RESOLUTION_LARGE, EXPECT_EQ(WallpaperManager::WALLPAPER_RESOLUTION_LARGE,
WallpaperManager::Get()->GetAppropriateResolution()); WallpaperManager::Get()->GetAppropriateResolution());
EXPECT_EQ(1, observer.GetUpdateWallpaperCountAndReset()); EXPECT_EQ(1, observer.GetUpdateWallpaperCountAndReset());
...@@ -688,7 +680,6 @@ IN_PROC_BROWSER_TEST_P(WallpaperManagerBrowserTest, DisplayChange) { ...@@ -688,7 +680,6 @@ IN_PROC_BROWSER_TEST_P(WallpaperManagerBrowserTest, DisplayChange) {
// Wait for asynchronous DisplayBackgroundController::UpdateDisplay() call. // Wait for asynchronous DisplayBackgroundController::UpdateDisplay() call.
base::RunLoop().RunUntilIdle(); base::RunLoop().RunUntilIdle();
wallpaper_manager_test_utils::WaitAsyncWallpaperLoadFinished(); wallpaper_manager_test_utils::WaitAsyncWallpaperLoadFinished();
WallpaperManager::GetAppropriateResolutionForTesting();
EXPECT_EQ(WallpaperManager::WALLPAPER_RESOLUTION_LARGE, EXPECT_EQ(WallpaperManager::WALLPAPER_RESOLUTION_LARGE,
WallpaperManager::Get()->GetAppropriateResolution()); WallpaperManager::Get()->GetAppropriateResolution());
EXPECT_EQ(1, observer.GetUpdateWallpaperCountAndReset()); EXPECT_EQ(1, observer.GetUpdateWallpaperCountAndReset());
...@@ -698,7 +689,6 @@ IN_PROC_BROWSER_TEST_P(WallpaperManagerBrowserTest, DisplayChange) { ...@@ -698,7 +689,6 @@ IN_PROC_BROWSER_TEST_P(WallpaperManagerBrowserTest, DisplayChange) {
// Wait for asynchronous DisplayBackgroundController::UpdateDisplay() call. // Wait for asynchronous DisplayBackgroundController::UpdateDisplay() call.
base::RunLoop().RunUntilIdle(); base::RunLoop().RunUntilIdle();
wallpaper_manager_test_utils::WaitAsyncWallpaperLoadFinished(); wallpaper_manager_test_utils::WaitAsyncWallpaperLoadFinished();
WallpaperManager::GetAppropriateResolutionForTesting();
EXPECT_EQ(WallpaperManager::WALLPAPER_RESOLUTION_SMALL, EXPECT_EQ(WallpaperManager::WALLPAPER_RESOLUTION_SMALL,
WallpaperManager::Get()->GetAppropriateResolution()); WallpaperManager::Get()->GetAppropriateResolution());
EXPECT_EQ(1, observer.GetUpdateWallpaperCountAndReset()); EXPECT_EQ(1, observer.GetUpdateWallpaperCountAndReset());
...@@ -707,7 +697,6 @@ IN_PROC_BROWSER_TEST_P(WallpaperManagerBrowserTest, DisplayChange) { ...@@ -707,7 +697,6 @@ IN_PROC_BROWSER_TEST_P(WallpaperManagerBrowserTest, DisplayChange) {
// Wait for asynchronous DisplayBackgroundController::UpdateDisplay() call. // Wait for asynchronous DisplayBackgroundController::UpdateDisplay() call.
base::RunLoop().RunUntilIdle(); base::RunLoop().RunUntilIdle();
wallpaper_manager_test_utils::WaitAsyncWallpaperLoadFinished(); wallpaper_manager_test_utils::WaitAsyncWallpaperLoadFinished();
WallpaperManager::GetAppropriateResolutionForTesting();
EXPECT_EQ(WallpaperManager::WALLPAPER_RESOLUTION_SMALL, EXPECT_EQ(WallpaperManager::WALLPAPER_RESOLUTION_SMALL,
WallpaperManager::Get()->GetAppropriateResolution()); WallpaperManager::Get()->GetAppropriateResolution());
EXPECT_EQ(1, observer.GetUpdateWallpaperCountAndReset()); EXPECT_EQ(1, observer.GetUpdateWallpaperCountAndReset());
...@@ -715,7 +704,6 @@ IN_PROC_BROWSER_TEST_P(WallpaperManagerBrowserTest, DisplayChange) { ...@@ -715,7 +704,6 @@ IN_PROC_BROWSER_TEST_P(WallpaperManagerBrowserTest, DisplayChange) {
// Wait for asynchronous DisplayBackgroundController::UpdateDisplay() call. // Wait for asynchronous DisplayBackgroundController::UpdateDisplay() call.
base::RunLoop().RunUntilIdle(); base::RunLoop().RunUntilIdle();
wallpaper_manager_test_utils::WaitAsyncWallpaperLoadFinished(); wallpaper_manager_test_utils::WaitAsyncWallpaperLoadFinished();
WallpaperManager::GetAppropriateResolutionForTesting();
EXPECT_EQ(WallpaperManager::WALLPAPER_RESOLUTION_LARGE, EXPECT_EQ(WallpaperManager::WALLPAPER_RESOLUTION_LARGE,
WallpaperManager::Get()->GetAppropriateResolution()); WallpaperManager::Get()->GetAppropriateResolution());
EXPECT_EQ(1, observer.GetUpdateWallpaperCountAndReset()); EXPECT_EQ(1, observer.GetUpdateWallpaperCountAndReset());
...@@ -724,7 +712,6 @@ IN_PROC_BROWSER_TEST_P(WallpaperManagerBrowserTest, DisplayChange) { ...@@ -724,7 +712,6 @@ IN_PROC_BROWSER_TEST_P(WallpaperManagerBrowserTest, DisplayChange) {
UpdateDisplay("900x800/r,400x1366"); UpdateDisplay("900x800/r,400x1366");
// Wait for asynchronous DisplayBackgroundController::UpdateDisplay() call. // Wait for asynchronous DisplayBackgroundController::UpdateDisplay() call.
base::RunLoop().RunUntilIdle(); base::RunLoop().RunUntilIdle();
WallpaperManager::GetAppropriateResolutionForTesting();
wallpaper_manager_test_utils::WaitAsyncWallpaperLoadFinished(); wallpaper_manager_test_utils::WaitAsyncWallpaperLoadFinished();
EXPECT_EQ(0, observer.GetUpdateWallpaperCountAndReset()); EXPECT_EQ(0, observer.GetUpdateWallpaperCountAndReset());
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment