avoid linearly-blended sRGB in image_bitmap
We're (unintentionally?) triggering linear sRGB 8888 drawing here by copying the color space directly off the source image for our resized surfaces. That we don't notice this is a testament to the perfect round tripping of our from_srgb and to_srgb conversion functions. I'm trying to land https://skia-review.googlesource.com/c/skia/+/132261 to intentionally break linearly blended sRGB 8888, to flush out accidental uses just like this one. With that CL applied, our drawing pipeline for linear-blended sRGB 8888 is intentionally _very_ broken, and will do broken things like linearize sources but not linearize the destination or re-encode the result of the blend. We caught this with layout tests, https://test-results.appspot.com/data/layout_results/linux_trusty_blink_rel/30657/layout-test-results/results.html Change-Id: I5814c43d861deab8a2720790fb826ed2f0a9b2bf Reviewed-on: https://chromium-review.googlesource.com/1089135Reviewed-by:Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#564994}
Showing
Please register or sign in to comment