Changed Reauth message for Copy password.

Changed Reauth dialog message for Copy password into clipboard feature.
Added new Reauth Purpose reason.

Bug: 917337
Change-Id: If805234969a39a98b24af1816f33c88388a06b87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061814
Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743012}

chrome/app/chromium_strings.grd

@@ -367,6 +367,9 @@ Chromium is unable to recover your settings.
         <message name="IDS_PASSWORDS_PAGE_AUTHENTICATION_PROMPT" desc="Text for the dialog box that prompts the user for their OS account password before revealing plaintext passwords on the password page.">
           Chromium is trying to show passwords.
         </message>
+        <message name="IDS_PASSWORDS_PAGE_COPY_AUTHENTICATION_PROMPT" desc="Text for the dialog box that prompts the user for their OS account password before copying plaintext passwords into the clipboard.">
+          Chromium is trying to copy passwords.
+        </message>
         <message name="IDS_PASSWORDS_PAGE_EXPORT_AUTHENTICATION_PROMPT" desc="Text for the dialog box that prompts the user for their OS account password before exporting passwords to a file.">
           Chromium wants to export your passwords.
         </message>
@@ -375,6 +378,9 @@ Chromium is unable to recover your settings.
         <message name="IDS_PASSWORDS_PAGE_AUTHENTICATION_PROMPT" desc="Text for the dialog box that prompts the user for their OS account password before revealing plaintext passwords on the password page.">
           Chromium is trying to show passwords. Type your Windows password to allow this.
         </message>
+        <message name="IDS_PASSWORDS_PAGE_COPY_AUTHENTICATION_PROMPT" desc="Text for the dialog box that prompts the user for their OS account password before copying plaintext passwords into the clipboard.">
+          Chromium is trying to copy passwords. Type your Windows password to allow this.
+        </message>
         <message name="IDS_PASSWORDS_PAGE_EXPORT_AUTHENTICATION_PROMPT" desc="Text for the dialog box that prompts the user for their OS account password before exporting passwords to a file.">
           Chromium wants to export your passwords. Type your Windows password to allow this.
         </message>

chrome/app/chromium_strings_grd/IDS_PASSWORDS_PAGE_COPY_AUTHENTICATION_PROMPT.png.sha1

+697e5a773ff312d6fbc54e36099bda6bbcc76189
\ No newline at end of file

chrome/app/google_chrome_strings.grd

@@ -378,6 +378,9 @@ Google Chrome is unable to recover your settings.
         <message name="IDS_PASSWORDS_PAGE_AUTHENTICATION_PROMPT" desc="Text for the dialog box that prompts the user for their OS account password before revealing plaintext passwords on the password page.">
           Google Chrome is trying to show passwords.
         </message>
+        <message name="IDS_PASSWORDS_PAGE_COPY_AUTHENTICATION_PROMPT" desc="Text for the dialog box that prompts the user for their OS account password before copying plaintext passwords into the clipbord.">
+          Google Chrome is trying to copy passwords.
+        </message>
         <message name="IDS_PASSWORDS_PAGE_EXPORT_AUTHENTICATION_PROMPT" desc="Text for the dialog box that prompts the user for their OS account password before exporting passwords to a file.">
           Google Chrome wants to export your passwords.
         </message>
@@ -386,6 +389,9 @@ Google Chrome is unable to recover your settings.
         <message name="IDS_PASSWORDS_PAGE_AUTHENTICATION_PROMPT" desc="Text for the dialog box that prompts the user for their OS account password before revealing plaintext passwords on the password page.">
           Google Chrome is trying to show passwords. Type your Windows password to allow this.
         </message>
+        <message name="IDS_PASSWORDS_PAGE_COPY_AUTHENTICATION_PROMPT" desc="Text for the dialog box that prompts the user for their OS account password before copying plaintext passwords into the clipbord.">
+          Google Chrome is trying to copy passwords. Type your Windows password to allow this.
+        </message>
         <message name="IDS_PASSWORDS_PAGE_EXPORT_AUTHENTICATION_PROMPT" desc="Text for the dialog box that prompts the user for their OS account password before exporting passwords to a file.">
           Google Chrome wants to export your passwords. Type your Windows password to allow this.
         </message>

chrome/app/google_chrome_strings_grd/IDS_PASSWORDS_PAGE_COPY_AUTHENTICATION_PROMPT.png.sha1

+58398e2c9151e361bad0882d348a182a94193fee
\ No newline at end of file

chrome/browser/extensions/api/passwords_private/passwords_private_delegate_impl.cc

@@ -205,10 +205,13 @@ void PasswordsPrivateDelegateImpl::RequestPlaintextPassword(
   // exiting this method.
   // TODO(crbug.com/495290): Pass the native window directly to the
   // reauth-handling code.
-  // TODO(crbug.com/1047726): Make use of the different values for reason.
+  // TODO(crbug.com/1047726): Handle Edit case.
   web_contents_ = web_contents;
+  auto reauth_purpose = reason == api::passwords_private::PLAINTEXT_REASON_COPY
+                            ? password_manager::ReauthPurpose::COPY_PASSWORD
+                            : password_manager::ReauthPurpose::VIEW_PASSWORD;
   if (!password_access_authenticator_.EnsureUserIsAuthenticated(
-          password_manager::ReauthPurpose::VIEW_PASSWORD)) {
+          reauth_purpose)) {
     std::move(callback).Run(base::nullopt);
     return;
   }

chrome/browser/extensions/api/passwords_private/passwords_private_delegate_impl_unittest.cc

@@ -254,7 +254,7 @@ TEST_F(PasswordsPrivateDelegateImplTest, TestCopyPasswordCallbackResult) {
   MockReauthCallback callback;
   delegate.set_os_reauth_call(callback.Get());
 
-  EXPECT_CALL(callback, Run(ReauthPurpose::VIEW_PASSWORD))
+  EXPECT_CALL(callback, Run(ReauthPurpose::COPY_PASSWORD))
       .WillOnce(Return(true));
 
   MockPlaintextPasswordCallback password_callback;
@@ -277,7 +277,7 @@ TEST_F(PasswordsPrivateDelegateImplTest, TestCopyPasswordCallbackResultFail) {
   MockReauthCallback callback;
   delegate.set_os_reauth_call(callback.Get());
 
-  EXPECT_CALL(callback, Run(ReauthPurpose::VIEW_PASSWORD))
+  EXPECT_CALL(callback, Run(ReauthPurpose::COPY_PASSWORD))
       .WillOnce(Return(false));
 
   base::Time before_call = test_clipboard_->GetLastModifiedTime();

chrome/browser/password_manager/password_manager_util_mac.mm

@@ -33,6 +33,10 @@ bool AuthenticateUser(password_manager::ReauthPurpose purpose) {
     case password_manager::ReauthPurpose::VIEW_PASSWORD:
       prompt = l10n_util::GetNSString(IDS_PASSWORDS_PAGE_AUTHENTICATION_PROMPT);
       break;
+    case password_manager::ReauthPurpose::COPY_PASSWORD:
+      prompt =
+          l10n_util::GetNSString(IDS_PASSWORDS_PAGE_COPY_AUTHENTICATION_PROMPT);
+      break;
     case password_manager::ReauthPurpose::EXPORT:
       prompt = l10n_util::GetNSString(
           IDS_PASSWORDS_PAGE_EXPORT_AUTHENTICATION_PROMPT);

chrome/browser/password_manager/password_manager_util_win.cc

@@ -365,6 +365,10 @@ bool AuthenticateUserOld(gfx::NativeWindow window,
       password_prompt =
           l10n_util::GetStringUTF16(IDS_PASSWORDS_PAGE_AUTHENTICATION_PROMPT);
       break;
+    case password_manager::ReauthPurpose::COPY_PASSWORD:
+      password_prompt = l10n_util::GetStringUTF16(
+          IDS_PASSWORDS_PAGE_COPY_AUTHENTICATION_PROMPT);
+      break;
     case password_manager::ReauthPurpose::EXPORT:
       password_prompt = l10n_util::GetStringUTF16(
           IDS_PASSWORDS_PAGE_EXPORT_AUTHENTICATION_PROMPT);
@@ -485,6 +489,10 @@ bool AuthenticateUserNew(gfx::NativeWindow window,
       password_prompt =
           l10n_util::GetStringUTF16(IDS_PASSWORDS_PAGE_AUTHENTICATION_PROMPT);
       break;
+    case password_manager::ReauthPurpose::COPY_PASSWORD:
+      password_prompt = l10n_util::GetStringUTF16(
+          IDS_PASSWORDS_PAGE_COPY_AUTHENTICATION_PROMPT);
+      break;
     case password_manager::ReauthPurpose::EXPORT:
       password_prompt = l10n_util::GetStringUTF16(
           IDS_PASSWORDS_PAGE_EXPORT_AUTHENTICATION_PROMPT);

components/password_manager/core/browser/password_access_authenticator_unittest.cc

@@ -107,6 +107,7 @@ TEST_P(PasswordAccessAuthenticatorTest, Failed) {
 INSTANTIATE_TEST_SUITE_P(,
                          PasswordAccessAuthenticatorTest,
                          Values(ReauthPurpose::VIEW_PASSWORD,
+                                ReauthPurpose::COPY_PASSWORD,
                                 ReauthPurpose::EXPORT));
 
 }  // namespace password_manager

components/password_manager/core/browser/reauth_purpose.h

@@ -10,7 +10,8 @@ namespace password_manager {
 // The reason why the user is asked to pass a reauthentication challenge.
 enum class ReauthPurpose {
   VIEW_PASSWORD,  // A password value will be made visible on the UI
-  EXPORT          // Password values will be written to the filesystem without
+  COPY_PASSWORD,  // A password value will be copied into the clipboard
+  EXPORT,         // Password values will be written to the filesystem without
                   // protection
 };