CodeHealthRotation: Migrate Bind to BindOnce/Repeating in extensions/renderer/bindings/

This CL migrates uses of base::Bind to BindOnce/BindRepeating, and
uses of base::Closure to OnceClosure/RepeatingClosure.

Bug: 1152265
Change-Id: Idfbc16778639cc6668c38b2be47ef839a6e2ca33
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569960Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Hui Yingst <nigi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#835394}

extensions/renderer/bindings/binding_access_checker_unittest.cc

@@ -62,7 +62,7 @@ TEST_F(BindingAccessCheckerTest, TestHasAccessOrThrowError) {
 
 TEST_F(BindingAccessCheckerTest, TestHasPromiseAccess) {
   bool context_allows_promises = true;
-  auto promises_available = base::Bind(
+  auto promises_available = base::BindRepeating(
       [](bool* flag, v8::Local<v8::Context> context) { return *flag; },
       &context_allows_promises);
 

extensions/renderer/bindings/test_js_runner.cc

@@ -58,10 +58,10 @@ TestJSRunner::PendingCall::PendingCall() {}
 TestJSRunner::PendingCall::~PendingCall() = default;
 TestJSRunner::PendingCall::PendingCall(PendingCall&& other) = default;
 
-TestJSRunner::TestJSRunner() {}
-TestJSRunner::TestJSRunner(const base::Closure& will_call_js)
+TestJSRunner::TestJSRunner() = default;
+TestJSRunner::TestJSRunner(const base::RepeatingClosure& will_call_js)
     : will_call_js_(will_call_js) {}
-TestJSRunner::~TestJSRunner() {}
+TestJSRunner::~TestJSRunner() = default;
 
 void TestJSRunner::RunJSFunction(v8::Local<v8::Function> function,
                                  v8::Local<v8::Context> context,

extensions/renderer/bindings/test_js_runner.h

@@ -71,7 +71,7 @@ class TestJSRunner : public JSRunner {
 
   TestJSRunner();
   // Provides a callback to be called just before JS will be executed.
-  explicit TestJSRunner(const base::Closure& will_call_js);
+  explicit TestJSRunner(const base::RepeatingClosure& will_call_js);
   ~TestJSRunner() override;
 
   // JSRunner:
@@ -104,7 +104,7 @@ class TestJSRunner : public JSRunner {
   // Runs all pending calls.
   void Flush();
 
-  base::Closure will_call_js_;
+  base::RepeatingClosure will_call_js_;
   std::vector<PendingCall> pending_calls_;
 
   DISALLOW_COPY_AND_ASSIGN(TestJSRunner);