Commit abe62cbe authored by Nathan Parker's avatar Nathan Parker Committed by Commit Bot

Add PasswordCaptured field to GaiaPasswordReuse event log.

Chrome-side change. Logs CL: http://cl/200254698

Bug: 849781
Change-Id: I4348263c7e7bbfb868626141bc6a142cb738375d
Reviewed-on: https://chromium-review.googlesource.com/1102165
Commit-Queue: Nathan Parker <nparker@chromium.org>
Reviewed-by: default avatarVarun Khaneja <vakh@chromium.org>
Reviewed-by: default avatarTim Schumann <tschumann@chromium.org>
Reviewed-by: default avatarvitaliii <vitaliii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575782}
parent ef98ea02
...@@ -472,6 +472,23 @@ const char* ProtoEnumToString( ...@@ -472,6 +472,23 @@ const char* ProtoEnumToString(
return ""; return "";
} }
const char* ProtoEnumToString(sync_pb::UserEventSpecifics::GaiaPasswordReuse::
PasswordCaptured::EventTrigger trigger) {
ASSERT_ENUM_BOUNDS(
sync_pb::UserEventSpecifics::GaiaPasswordReuse::PasswordCaptured,
EventTrigger, UNSPECIFIED, EXPIRED_28D_TIMER);
switch (trigger) {
ENUM_CASE(sync_pb::UserEventSpecifics::GaiaPasswordReuse::PasswordCaptured,
UNSPECIFIED);
ENUM_CASE(sync_pb::UserEventSpecifics::GaiaPasswordReuse::PasswordCaptured,
USER_LOGGED_IN);
ENUM_CASE(sync_pb::UserEventSpecifics::GaiaPasswordReuse::PasswordCaptured,
EXPIRED_28D_TIMER);
}
NOTREACHED();
return "";
}
const char* ProtoEnumToString( const char* ProtoEnumToString(
sync_pb::WalletMaskedCreditCard::WalletCardClass wallet_card_class) { sync_pb::WalletMaskedCreditCard::WalletCardClass wallet_card_class) {
ASSERT_ENUM_BOUNDS(sync_pb::WalletMaskedCreditCard, WalletCardClass, ASSERT_ENUM_BOUNDS(sync_pb::WalletMaskedCreditCard, WalletCardClass,
......
...@@ -92,6 +92,9 @@ const char* ProtoEnumToString( ...@@ -92,6 +92,9 @@ const char* ProtoEnumToString(
sync_pb::UserEventSpecifics::GaiaPasswordReuse::PasswordReuseLookup:: sync_pb::UserEventSpecifics::GaiaPasswordReuse::PasswordReuseLookup::
ReputationVerdict verdict); ReputationVerdict verdict);
const char* ProtoEnumToString(sync_pb::UserEventSpecifics::GaiaPasswordReuse::
PasswordCaptured::EventTrigger trigger);
const char* ProtoEnumToString( const char* ProtoEnumToString(
sync_pb::WalletMaskedCreditCard::WalletCardClass wallet_card_class); sync_pb::WalletMaskedCreditCard::WalletCardClass wallet_card_class);
......
...@@ -803,6 +803,7 @@ VISIT_PROTO_FIELDS( ...@@ -803,6 +803,7 @@ VISIT_PROTO_FIELDS(
VISIT(reuse_detected); VISIT(reuse_detected);
VISIT(reuse_lookup); VISIT(reuse_lookup);
VISIT(dialog_interaction); VISIT(dialog_interaction);
VISIT(password_captured);
} }
VISIT_PROTO_FIELDS( VISIT_PROTO_FIELDS(
...@@ -830,6 +831,12 @@ VISIT_PROTO_FIELDS( ...@@ -830,6 +831,12 @@ VISIT_PROTO_FIELDS(
VISIT(verdict_token); VISIT(verdict_token);
} }
VISIT_PROTO_FIELDS(
const sync_pb::UserEventSpecifics::GaiaPasswordReuse::PasswordCaptured&
proto) {
VISIT_ENUM(event_trigger);
}
VISIT_PROTO_FIELDS(const sync_pb::TabNavigation& proto) { VISIT_PROTO_FIELDS(const sync_pb::TabNavigation& proto) {
VISIT(virtual_url); VISIT(virtual_url);
VISIT(referrer); VISIT(referrer);
......
...@@ -254,6 +254,19 @@ message UserEventSpecifics { ...@@ -254,6 +254,19 @@ message UserEventSpecifics {
optional InteractionResult interaction_result = 1; optional InteractionResult interaction_result = 1;
} }
optional PasswordReuseDialogInteraction dialog_interaction = 3; optional PasswordReuseDialogInteraction dialog_interaction = 3;
// Logged when the user logs into Google, and at least once per 28d.
message PasswordCaptured {
enum EventTrigger {
UNSPECIFIED = 0;
// Event added because user logged in.
USER_LOGGED_IN = 1;
// Event added because 28d timer fired.
EXPIRED_28D_TIMER = 2;
}
optional EventTrigger event_trigger = 1;
}
optional PasswordCaptured password_captured = 4;
} }
oneof event { oneof event {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment