Commit ac44b7e2 authored by Daniel Rubery's avatar Daniel Rubery Committed by Commit Bot

Fix accessible alert for deep scanning prompt

The accessible alert while prompting the user for deep scanning is still
"Downloading, 0% remaining", which is jarring. This CL fixes that.

Bug: 1056350
Change-Id: I5e10dcc702c6bef8368492819ce67e432dd469b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076429Reviewed-by: default avatarXing Liu <xingliu@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745122}
parent 261bb749
......@@ -1985,6 +1985,20 @@ are declared in tools/grit/grit_rule.gni.
</message>
</else>
</if>
<if expr="is_macosx">
<then>
<message name="IDS_PROMPT_APP_DEEP_SCANNING_ACCESSIBLE_ALERT"
desc="The title of a download notification inidcating that the file may be malicious, and the Advanced Protection Program recommends sending the file to Google. This message is for screen reader users">
Advanced Protection recommends sending <ph name="FILE_NAME">$1<ex>file.exe</ex></ph> to Google to check for malware.
</message>
</then>
<else>
<message name="IDS_PROMPT_APP_DEEP_SCANNING_ACCESSIBLE_ALERT"
desc="The title of a download notification inidcating that the file may be malicious, and the Advanced Protection Program recommends sending the file to Google. This message is for screen reader users">
Advanced Protection recommends sending <ph name="FILE_NAME">$1<ex>file.exe</ex></ph> to Google to check for malware. Press Shift+F6 to cycle to the downloads bar area.
</message>
</else>
</if>
<!-- Download Notification Labels -->
<message name="IDS_DOWNLOAD_NOTIFICATION_COPY_TO_CLIPBOARD"
......
......@@ -1109,6 +1109,12 @@ void DownloadItemView::TransitionToDeepScanningDialog() {
ShowDeepScanningDialog();
UpdateAccessibleAlert(
l10n_util::GetStringFUTF16(
IDS_PROMPT_APP_DEEP_SCANNING_ACCESSIBLE_ALERT,
model_->GetFileNameToReportUser().LossyDisplayName()),
false);
// We need to load the icon now that the download has the real path.
LoadIcon();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment