Disable menu button for disabled extensions

This removes the confusing behavior where a user clicks a button,
expecting an action to happen, but there is no associated action so we
would instead spawn a context menu.

This now does not look like a clickable button (no hover state) and the
three-dot menu is used to access the context menu for extensions without
actions.

Bug: chromium:943702
Change-Id: I9ae6fe7d549dd2dac2d003fb6f1fecdab66e9c83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575859Reviewed-by: Collin Baker <collinbaker@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652618}

chrome/browser/ui/views/extensions/extensions_menu_button.cc

@@ -91,6 +91,7 @@ void ExtensionsMenuButton::UpdateState() {
   SetTitleTextWithHintRange(controller_->GetActionName(),
                             gfx::Range::InvalidRange());
   SetTooltipText(controller_->GetTooltip(GetCurrentWebContents()));
+  SetEnabled(controller_->IsEnabled(GetCurrentWebContents()));
 }
 
 bool ExtensionsMenuButton::IsMenuRunning() const {

chrome/browser/ui/views/extensions/extensions_menu_button_unittest.cc

@@ -94,3 +94,11 @@ TEST_F(ExtensionsMenuButtonTest, UpdatesToDisplayTooltip) {
 
   EXPECT_EQ(button_->GetTooltipText(gfx::Point()), tooltip);
 }
+
+TEST_F(ExtensionsMenuButtonTest, ButtonMatchesEnabledStateOfExtension) {
+  EXPECT_TRUE(button_->enabled());
+  controller_->SetEnabled(false);
+  EXPECT_FALSE(button_->enabled());
+  controller_->SetEnabled(true);
+  EXPECT_TRUE(button_->enabled());
+}