Commit ac6c4e8e authored by Matthias Körber's avatar Matthias Körber Committed by Commit Bot

Removed unused methods from |PasswordFormMetricsRecorder|.

Change-Id: Ib09a8ab819e2160c20c4424173d1e92fb1efc18f
Bug: 875768
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823843
Commit-Queue: Matthias Körber <koerber@google.com>
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Auto-Submit: Matthias Körber <koerber@google.com>
Reviewed-by: default avatarVadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700672}
parent 1158a2b6
...@@ -16,7 +16,6 @@ ...@@ -16,7 +16,6 @@
#include "components/password_manager/core/browser/password_bubble_experiment.h" #include "components/password_manager/core/browser/password_bubble_experiment.h"
#include "components/password_manager/core/browser/password_manager_metrics_util.h" #include "components/password_manager/core/browser/password_manager_metrics_util.h"
#include "components/password_manager/core/browser/statistics_table.h" #include "components/password_manager/core/browser/statistics_table.h"
#include "password_form_metrics_recorder.h"
using autofill::FieldPropertiesFlags; using autofill::FieldPropertiesFlags;
using autofill::FormData; using autofill::FormData;
...@@ -234,10 +233,6 @@ PasswordFormMetricsRecorder::~PasswordFormMetricsRecorder() { ...@@ -234,10 +233,6 @@ PasswordFormMetricsRecorder::~PasswordFormMetricsRecorder() {
ukm_entry_builder_.SetGeneration_PopupShown( ukm_entry_builder_.SetGeneration_PopupShown(
static_cast<int64_t>(password_generation_popup_shown_)); static_cast<int64_t>(password_generation_popup_shown_));
} }
if (spec_priority_of_generated_password_) {
ukm_entry_builder_.SetGeneration_SpecPriority(
spec_priority_of_generated_password_.value());
}
if (showed_manual_fallback_for_saving_) { if (showed_manual_fallback_for_saving_) {
ukm_entry_builder_.SetSaving_ShowedManualFallbackForSaving( ukm_entry_builder_.SetSaving_ShowedManualFallbackForSaving(
...@@ -294,11 +289,6 @@ void PasswordFormMetricsRecorder::SetGeneratedPasswordStatus( ...@@ -294,11 +289,6 @@ void PasswordFormMetricsRecorder::SetGeneratedPasswordStatus(
generated_password_status_ = status; generated_password_status_ = status;
} }
void PasswordFormMetricsRecorder::ReportSpecPriorityForGeneratedPassword(
uint32_t spec_priority) {
spec_priority_of_generated_password_ = spec_priority;
}
void PasswordFormMetricsRecorder::SetManagerAction( void PasswordFormMetricsRecorder::SetManagerAction(
ManagerAction manager_action) { ManagerAction manager_action) {
manager_action_ = manager_action; manager_action_ = manager_action;
......
...@@ -304,13 +304,6 @@ class PasswordFormMetricsRecorder ...@@ -304,13 +304,6 @@ class PasswordFormMetricsRecorder
// Stores the user action associated with a generated password. // Stores the user action associated with a generated password.
void SetGeneratedPasswordStatus(GeneratedPasswordStatus status); void SetGeneratedPasswordStatus(GeneratedPasswordStatus status);
// Reports the priority of a PasswordGenerationRequirementsSpec for a
// generated password. This can be used for debugging as a 0 means that
// no spec was used, a 10 means that the spec came from autofill and was crowd
// sourced, a 20 means that it was overrideen per domain and a 30 means that
// is was overridden for the form.
void ReportSpecPriorityForGeneratedPassword(uint32_t spec_priority);
// Stores the password manager action. During destruction the last // Stores the password manager action. During destruction the last
// set value will be logged. // set value will be logged.
void SetManagerAction(ManagerAction manager_action); void SetManagerAction(ManagerAction manager_action);
...@@ -458,8 +451,6 @@ class PasswordFormMetricsRecorder ...@@ -458,8 +451,6 @@ class PasswordFormMetricsRecorder
// action. // action.
base::Optional<GeneratedPasswordStatus> generated_password_status_; base::Optional<GeneratedPasswordStatus> generated_password_status_;
base::Optional<uint32_t> spec_priority_of_generated_password_;
// Tracks which bubble is currently being displayed to the user. // Tracks which bubble is currently being displayed to the user.
CurrentBubbleOfInterest current_bubble_ = CurrentBubbleOfInterest::kNone; CurrentBubbleOfInterest current_bubble_ = CurrentBubbleOfInterest::kNone;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment